Skip to content

Commit 26527a0

Browse files
authored
Make ValueChanged type nullable to match FormField (#786)
* make onChanged value <T?> to match form * Make FormBuilderTextField maxLines nullable * Revert "Make FormBuilderTextField maxLines nullable" This reverts commit 7a86c8b. Co-authored-by: csomers <[email protected]>
1 parent ff9b07e commit 26527a0

14 files changed

+14
-14
lines changed

lib/src/fields/form_builder_checkbox.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class FormBuilderCheckbox extends FormBuilderField<bool> {
7979
errorBorder: InputBorder.none,
8080
disabledBorder: InputBorder.none,
8181
),
82-
ValueChanged<bool>? onChanged,
82+
ValueChanged<bool?>? onChanged,
8383
ValueTransformer<bool>? valueTransformer,
8484
bool enabled = true,
8585
FormFieldSetter<bool>? onSaved,

lib/src/fields/form_builder_checkbox_group.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class FormBuilderCheckboxGroup<T> extends FormBuilderField<List<T>> {
3333
FormFieldValidator<List<T>>? validator,
3434
List<T>? initialValue,
3535
InputDecoration decoration = const InputDecoration(),
36-
ValueChanged<List<T>>? onChanged,
36+
ValueChanged<List<T>?>? onChanged,
3737
ValueTransformer<List<T>>? valueTransformer,
3838
bool enabled = true,
3939
FormFieldSetter<List<T>>? onSaved,

lib/src/fields/form_builder_choice_chips.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ class FormBuilderChoiceChip<T> extends FormBuilderField<T> {
247247
FormFieldValidator<T>? validator,
248248
T? initialValue,
249249
InputDecoration decoration = const InputDecoration(),
250-
ValueChanged<T>? onChanged,
250+
ValueChanged<T?>? onChanged,
251251
ValueTransformer<T>? valueTransformer,
252252
bool enabled = true,
253253
FormFieldSetter<T>? onSaved,

lib/src/fields/form_builder_date_range_picker.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class FormBuilderDateRangePicker extends FormBuilderField<DateTimeRange> {
6868
FormFieldValidator<DateTimeRange>? validator,
6969
DateTimeRange? initialValue,
7070
InputDecoration decoration = const InputDecoration(),
71-
ValueChanged<DateTimeRange>? onChanged,
71+
ValueChanged<DateTimeRange?>? onChanged,
7272
ValueTransformer<DateTimeRange>? valueTransformer,
7373
bool enabled = true,
7474
FormFieldSetter<DateTimeRange>? onSaved,

lib/src/fields/form_builder_date_time_picker.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ class FormBuilderDateTimePicker extends FormBuilderField<DateTime> {
135135
FormFieldValidator<DateTime>? validator,
136136
DateTime? initialValue,
137137
InputDecoration decoration = const InputDecoration(),
138-
ValueChanged<DateTime>? onChanged,
138+
ValueChanged<DateTime?>? onChanged,
139139
ValueTransformer<DateTime>? valueTransformer,
140140
bool enabled = true,
141141
FormFieldSetter<DateTime>? onSaved,

lib/src/fields/form_builder_dropdown.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class FormBuilderDropdown<T> extends FormBuilderField<T> {
189189
FormFieldValidator<T>? validator,
190190
T? initialValue,
191191
InputDecoration decoration = const InputDecoration(),
192-
ValueChanged<T>? onChanged,
192+
ValueChanged<T?>? onChanged,
193193
ValueTransformer<T>? valueTransformer,
194194
bool enabled = true,
195195
FormFieldSetter<T>? onSaved,

lib/src/fields/form_builder_filter_chips.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class FormBuilderFilterChip<T> extends FormBuilderField<List<T>> {
4747
errorBorder: InputBorder.none,
4848
disabledBorder: InputBorder.none,
4949
),
50-
ValueChanged<List<T>>? onChanged,
50+
ValueChanged<List<T>?>? onChanged,
5151
ValueTransformer<List<T>>? valueTransformer,
5252
bool enabled = true,
5353
FormFieldSetter<List<T>>? onSaved,

lib/src/fields/form_builder_radio_group.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class FormBuilderRadioGroup<T> extends FormBuilderField<T> {
3131
FormFieldValidator<T>? validator,
3232
T? initialValue,
3333
InputDecoration decoration = const InputDecoration(),
34-
ValueChanged<T>? onChanged,
34+
ValueChanged<T?>? onChanged,
3535
ValueTransformer<T>? valueTransformer,
3636
bool enabled = true,
3737
FormFieldSetter<T>? onSaved,

lib/src/fields/form_builder_range_slider.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class FormBuilderRangeSlider extends FormBuilderField<RangeValues> {
112112
FormFieldValidator<RangeValues>? validator,
113113
RangeValues? initialValue,
114114
InputDecoration decoration = const InputDecoration(),
115-
ValueChanged<RangeValues>? onChanged,
115+
ValueChanged<RangeValues?>? onChanged,
116116
ValueTransformer<RangeValues>? valueTransformer,
117117
bool enabled = true,
118118
FormFieldSetter<RangeValues>? onSaved,

lib/src/fields/form_builder_segmented_control.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class FormBuilderSegmentedControl<T extends Object>
4545
FormFieldValidator<T>? validator,
4646
T? initialValue,
4747
InputDecoration decoration = const InputDecoration(),
48-
ValueChanged<T>? onChanged,
48+
ValueChanged<T?>? onChanged,
4949
ValueTransformer<T>? valueTransformer,
5050
bool enabled = true,
5151
FormFieldSetter<T>? onSaved,

0 commit comments

Comments
 (0)