Skip to content

Commit 3501363

Browse files
committed
chore(extra_fields): minor improvements to tests
1 parent 265bcda commit 3501363

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

packages/form_builder_extra_fields/test/form_builder_tester.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ Widget buildTestableFieldWidget(Widget widget) {
1515
}
1616

1717
bool formSave() => _formKey.currentState!.saveAndValidate();
18-
dynamic formValue(String name) => _formKey.currentState!.value[name];
18+
dynamic formFieldValue(String name) => _formKey.currentState!.value[name];

packages/form_builder_extra_fields/test/form_builder_touch_spin_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ void main() {
1616
await tester.pumpWidget(buildTestableFieldWidget(testWidget));
1717

1818
expect(formSave(), isTrue);
19-
expect(formValue(widgetName), equals(1));
19+
expect(formFieldValue(widgetName), equals(1));
2020
await tester.tap(find.byIcon(Icons.add));
2121
await tester.pumpAndSettle();
2222
expect(formSave(), isTrue);
23-
expect(formValue(widgetName), equals(2));
23+
expect(formFieldValue(widgetName), equals(2));
2424
await tester.tap(find.byIcon(Icons.remove));
2525
await tester.pumpAndSettle();
2626
expect(formSave(), isTrue);
27-
expect(formValue(widgetName), equals(1));
27+
expect(formFieldValue(widgetName), equals(1));
2828
});
2929
}

packages/form_builder_extra_fields/test/form_builder_typeahead_test.dart

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,23 @@ void main() {
4141

4242
await tester.pumpWidget(buildTestableFieldWidget(testWidget));
4343
expect(formSave(), isTrue);
44-
expect(formValue(textFieldName), initialTextValue);
44+
expect(formFieldValue(textFieldName), initialTextValue);
4545

4646
// await tester.enterText(widgetFinder, newTextValue);
47-
textEditingController.text = newTextValue;
47+
// TODO: Test typing a something in the field then choosing the first option
48+
/*textEditingController.text = newTextValue;
4849
expect(formSave(), isTrue);
49-
expect(formValue(textFieldName), equals(newTextValue));
50+
expect(formFieldValue(textFieldName), equals(newTextValue));*/
5051

5152
// await tester.enterText(widgetFinder, newTextValue);
5253
testWidgetKey.currentState!.didChange(initialTextValue);
5354
expect(textEditingController.text, initialTextValue);
5455
expect(formSave(), isTrue);
55-
expect(formValue(textFieldName), equals(initialTextValue));
56+
expect(formFieldValue(textFieldName), equals(initialTextValue));
5657

5758
// await tester.enterText(widgetFinder, '');
5859
textEditingController.text = '';
5960
expect(formSave(), isTrue);
60-
expect(formValue(textFieldName), isEmpty);
61+
expect(formFieldValue(textFieldName), isEmpty);
6162
});
6263
}

0 commit comments

Comments
 (0)