Enabled strict-inference and enabled stricter type checks. (#549)

* Enabled strict-inference and enabled stricter type checks.
* Revised validators to eradicate dynamic types.
* Added type safety to equalErrorText message.
* Removed dynamic from example since we do not need to draw too much attention to it.
* Reverted some excessive typing.

Author: awhitford

analysis_options.yaml

@@ -3,3 +3,10 @@ include: package:pedantic/analysis_options.yaml
 analyzer:
   exclude:
     - lib/l10n/**
+
+  language:
+    strict-inference: true
+
+  strong-mode:
+    implicit-casts: false
+    implicit-dynamic: false

example/analysis_options.yaml

@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml

example/lib/sources/complete_form.dart

@@ -14,7 +14,6 @@ class CompleteForm extends StatefulWidget {
 }
 
 class CompleteFormState extends State<CompleteForm> {
-  var data;
   bool autoValidate = true;
   bool readOnly = false;
   bool showSegmentedControl = true;
@@ -102,7 +101,7 @@ class CompleteFormState extends State<CompleteForm> {
                     colorPickerType: ColorPickerType.MaterialPicker,
                     decoration: const InputDecoration(labelText: 'Pick Color'),
                   ),
-                  FormBuilderChipsInput(
+                  FormBuilderChipsInput<Contact>(
                     decoration: const InputDecoration(labelText: 'Chips'),
                     name: 'chips_test',
                     onChanged: _onChanged,
@@ -258,7 +257,7 @@ class CompleteFormState extends State<CompleteForm> {
                     keyboardType: TextInputType.number,
                     textInputAction: TextInputAction.next,
                   ),
-                  FormBuilderDropdown(
+                  FormBuilderDropdown<String>(
                     // autovalidate: true,
                     name: 'gender',
                     decoration: InputDecoration(
@@ -286,7 +285,7 @@ class CompleteFormState extends State<CompleteForm> {
                       });
                     },
                   ),
-                  FormBuilderTypeAhead(
+                  FormBuilderTypeAhead<String>(
                     decoration: const InputDecoration(
                       labelText: 'Country',
                     ),
@@ -315,7 +314,7 @@ class CompleteFormState extends State<CompleteForm> {
                       }
                     },
                   ),
-                  FormBuilderRadioGroup(
+                  FormBuilderRadioGroup<String>(
                     decoration: const InputDecoration(
                       labelText: 'My chosen language',
                     ),

lib/localization/form_builder_localizations.dart

@@ -38,35 +38,35 @@ class FormBuilderLocalizations {
     );
   }
 
-  String equalErrorText(value) => Intl.message(
+  String equalErrorText<T>(T value) => Intl.message(
         'This field value must be equal to $value.',
         name: 'equalErrorText',
         args: [value],
         desc: 'Error Text for equal validator',
       );
 
-  String minErrorText(min) => Intl.message(
+  String minErrorText(num min) => Intl.message(
         'Value must be greater than or equal to $min.',
         name: 'minErrorText',
         args: [min],
         desc: 'Error Text for required field',
       );
 
-  String minLengthErrorText(minLength) => Intl.message(
+  String minLengthErrorText(int minLength) => Intl.message(
         'Value must have a length greater than or equal to $minLength',
         name: 'minLengthErrorText',
         args: [minLength],
         desc: 'Error Text for minLength validator',
       );
 
-  String maxErrorText(max) => Intl.message(
+  String maxErrorText(num max) => Intl.message(
         'Value must be less than or equal to $max',
         name: 'maxErrorText',
         args: [max],
         desc: 'Error Text for max validator',
       );
 
-  String maxLengthErrorText(maxLength) => Intl.message(
+  String maxLengthErrorText(int maxLength) => Intl.message(
         'Value must have a length less than or equal to $maxLength',
         name: 'maxLengthErrorText',
         args: [maxLength],

lib/src/fields/form_builder_checkbox.dart

@@ -102,7 +102,7 @@ class FormBuilderCheckbox extends FormBuilderField<bool> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<bool> field) {
-            final _FormBuilderCheckboxState state = field;
+            final state = field as _FormBuilderCheckboxState;
 
             return InputDecorator(
               decoration: state.decoration(),

lib/src/fields/form_builder_checkbox_group.dart

@@ -28,7 +28,7 @@ class FormBuilderCheckboxGroup<T> extends FormBuilderField<List<T>> {
     Key key,
     //From Super
     @required String name,
-    FormFieldValidator validator,
+    FormFieldValidator<List<T>> validator,
     List<T> initialValue,
     InputDecoration decoration = const InputDecoration(),
     ValueChanged<List<T>> onChanged,
@@ -71,7 +71,7 @@ class FormBuilderCheckboxGroup<T> extends FormBuilderField<List<T>> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<List<T>> field) {
-            final _FormBuilderCheckboxGroupState<T> state = field;
+            final state = field as _FormBuilderCheckboxGroupState<T>;
 
             return InputDecorator(
               decoration: state.decoration(),

lib/src/fields/form_builder_chips_input.dart

@@ -67,7 +67,7 @@ class FormBuilderChipsInput<T> extends FormBuilderField<List<T>> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<List<T>> field) {
-            final _FormBuilderChipsInputState<T> state = field;
+            final state = field as _FormBuilderChipsInputState<T>;
 
             return ChipsInput<T>(
               key: ObjectKey(state.value),

lib/src/fields/form_builder_choice_chips.dart

@@ -288,7 +288,7 @@ class FormBuilderChoiceChip<T> extends FormBuilderField<T> {
             decoration: decoration,
             focusNode: focusNode,
             builder: (FormFieldState<T> field) {
-              final _FormBuilderChoiceChipState<T> state = field;
+              final state = field as _FormBuilderChoiceChipState<T>;
 
               return InputDecorator(
                 decoration: state.decoration(),

lib/src/fields/form_builder_color_picker.dart

@@ -123,7 +123,7 @@ class FormBuilderColorPickerField extends FormBuilderField<Color> {
           onReset: onReset,
           decoration: decoration,
           builder: (FormFieldState<Color> field) {
-            final _FormBuilderColorPickerFieldState state = field;
+            final state = field as _FormBuilderColorPickerFieldState;
             return TextField(
               style: style,
               decoration: state.decoration().copyWith(

lib/src/fields/form_builder_date_range_picker.dart

@@ -128,7 +128,7 @@ class FormBuilderDateRangePicker extends FormBuilderField<List<DateTime>> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<List<DateTime>> field) {
-            final FormBuilderDateRangePickerState state = field;
+            final state = field as FormBuilderDateRangePickerState;
 
             return TextField(
               enabled: enabled,
@@ -258,7 +258,7 @@ class FormBuilderDateRangePickerState
   }
 
   @override
-  void didChange(value) {
+  void didChange(List<DateTime> value) {
     super.didChange(value);
     _setTextFieldString();
   }