chore: fix static analysis warnings

Author: danvick

packages/form_builder_extra_fields/lib/src/fields/form_builder_chips_input.dart

@@ -70,7 +70,7 @@ class FormBuilderChipsInput<T> extends FormBuilderField<List<T>> {
           validator: validator,
           valueTransformer: valueTransformer,
           builder: (FormFieldState<List<T>?> field) {
-            final state = field as _FormBuilderChipsInputState<T>;
+            final state = field as FormBuilderChipsInputState<T>;
 
             return ChipsInput<T>(
               key: UniqueKey(),
@@ -102,9 +102,9 @@ class FormBuilderChipsInput<T> extends FormBuilderField<List<T>> {
         );
 
   @override
-  _FormBuilderChipsInputState<T> createState() =>
-      _FormBuilderChipsInputState<T>();
+  FormBuilderChipsInputState<T> createState() =>
+      FormBuilderChipsInputState<T>();
 }
 
-class _FormBuilderChipsInputState<T>
+class FormBuilderChipsInputState<T>
     extends FormBuilderFieldState<FormBuilderChipsInput<T>, List<T>> {}

packages/form_builder_extra_fields/lib/src/fields/form_builder_color_picker.dart

@@ -123,7 +123,7 @@ class FormBuilderColorPickerField extends FormBuilderField<Color> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<Color?> field) {
-            final state = field as _FormBuilderColorPickerFieldState;
+            final state = field as FormBuilderColorPickerFieldState;
             return TextField(
               style: style,
               decoration: state.decoration.copyWith(
@@ -178,11 +178,11 @@ class FormBuilderColorPickerField extends FormBuilderField<Color> {
         );
 
   @override
-  _FormBuilderColorPickerFieldState createState() =>
-      _FormBuilderColorPickerFieldState();
+  FormBuilderColorPickerFieldState createState() =>
+      FormBuilderColorPickerFieldState();
 }
 
-class _FormBuilderColorPickerFieldState
+class FormBuilderColorPickerFieldState
     extends FormBuilderFieldState<FormBuilderColorPickerField, Color> {
   late TextEditingController _effectiveController;
 

packages/form_builder_extra_fields/lib/src/fields/form_builder_cupertino_date_time_picker.dart

@@ -134,7 +134,7 @@ class FormBuilderCupertinoDateTimePicker extends FormBuilderField<DateTime> {
           validator: validator,
           valueTransformer: valueTransformer,
           builder: (FormFieldState<DateTime?> field) {
-            final state = field as _FormBuilderCupertinoDateTimePickerState;
+            final state = field as FormBuilderCupertinoDateTimePickerState;
 
             return TextField(
               autocorrect: autocorrect,
@@ -172,11 +172,11 @@ class FormBuilderCupertinoDateTimePicker extends FormBuilderField<DateTime> {
         );
 
   @override
-  _FormBuilderCupertinoDateTimePickerState createState() =>
-      _FormBuilderCupertinoDateTimePickerState();
+  FormBuilderCupertinoDateTimePickerState createState() =>
+      FormBuilderCupertinoDateTimePickerState();
 }
 
-class _FormBuilderCupertinoDateTimePickerState extends FormBuilderFieldState<
+class FormBuilderCupertinoDateTimePickerState extends FormBuilderFieldState<
     FormBuilderCupertinoDateTimePicker, DateTime> {
   late TextEditingController _textFieldController;
 
@@ -237,6 +237,7 @@ class _FormBuilderCupertinoDateTimePickerState extends FormBuilderFieldState<
       case CupertinoDateTimePickerInputType.both:
         final date = await _showDatePicker(context, currentValue);
         if (date != null) {
+          if (!mounted) return null;
           final time = await _showTimePicker(context, currentValue);
           newValue = combine(date, time);
         }
@@ -293,9 +294,10 @@ class _FormBuilderCupertinoDateTimePickerState extends FormBuilderFieldState<
       time == null ? null : DateTime(1, 1, 1, time.hour, time.minute);
 
   @override
-  void didChange(DateTime? val) {
-    super.didChange(val);
-    _textFieldController.text = (val == null) ? '' : _dateFormat.format(val);
+  void didChange(DateTime? value) {
+    super.didChange(value);
+    _textFieldController.text =
+        (value == null) ? '' : _dateFormat.format(value);
   }
 
   LocaleType _localeType() {

packages/form_builder_extra_fields/lib/src/fields/form_builder_rating_bar.dart

@@ -142,7 +142,7 @@ class FormBuilderRatingBar extends FormBuilderField<double> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<double?> field) {
-            final state = field as _FormBuilderRatingBarState;
+            final state = field as FormBuilderRatingBarState;
             final widget = state.widget;
 
             return InputDecorator(
@@ -185,8 +185,8 @@ class FormBuilderRatingBar extends FormBuilderField<double> {
         );
 
   @override
-  _FormBuilderRatingBarState createState() => _FormBuilderRatingBarState();
+  FormBuilderRatingBarState createState() => FormBuilderRatingBarState();
 }
 
-class _FormBuilderRatingBarState
+class FormBuilderRatingBarState
     extends FormBuilderFieldState<FormBuilderRatingBar, double> {}

packages/form_builder_extra_fields/lib/src/fields/form_builder_searchable_dropdown.dart

@@ -155,7 +155,7 @@ class FormBuilderSearchableDropdown<T> extends FormBuilderField<T> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<T?> field) {
-            final state = field as _FormBuilderSearchableDropdownState<T>;
+            final state = field as FormBuilderSearchableDropdownState<T>;
             return dropdown_search.DropdownSearch<T>(
               // Hack to rebuild when didChange is called
               key: UniqueKey(),
@@ -188,9 +188,9 @@ class FormBuilderSearchableDropdown<T> extends FormBuilderField<T> {
         );
 
   @override
-  _FormBuilderSearchableDropdownState<T> createState() =>
-      _FormBuilderSearchableDropdownState<T>();
+  FormBuilderSearchableDropdownState<T> createState() =>
+      FormBuilderSearchableDropdownState<T>();
 }
 
-class _FormBuilderSearchableDropdownState<T>
+class FormBuilderSearchableDropdownState<T>
     extends FormBuilderFieldState<FormBuilderSearchableDropdown<T>, T> {}

packages/form_builder_extra_fields/lib/src/fields/form_builder_signature_pad.dart

@@ -62,7 +62,7 @@ class FormBuilderSignaturePad extends FormBuilderField<Uint8List> {
           validator: validator,
           valueTransformer: valueTransformer,
           builder: (FormFieldState<Uint8List?> field) {
-            final state = field as _FormBuilderSignaturePadState;
+            final state = field as FormBuilderSignaturePadState;
             final theme = Theme.of(state.context);
             final localizations = MaterialLocalizations.of(state.context);
             final cancelButtonColor =
@@ -122,11 +122,10 @@ class FormBuilderSignaturePad extends FormBuilderField<Uint8List> {
         );
 
   @override
-  _FormBuilderSignaturePadState createState() =>
-      _FormBuilderSignaturePadState();
+  FormBuilderSignaturePadState createState() => FormBuilderSignaturePadState();
 }
 
-class _FormBuilderSignaturePadState
+class FormBuilderSignaturePadState
     extends FormBuilderFieldState<FormBuilderSignaturePad, Uint8List> {
   late SignatureController _controller;
 

packages/form_builder_extra_fields/lib/src/fields/form_builder_touch_spin.dart

@@ -85,7 +85,7 @@ class FormBuilderTouchSpin extends FormBuilderField<num> {
           validator: validator,
           valueTransformer: valueTransformer,
           builder: (FormFieldState<num?> field) {
-            final state = field as _FormBuilderTouchSpinState;
+            final state = field as FormBuilderTouchSpinState;
             final theme = Theme.of(state.context);
 
             return InputDecorator(
@@ -119,8 +119,8 @@ class FormBuilderTouchSpin extends FormBuilderField<num> {
         );
 
   @override
-  _FormBuilderTouchSpinState createState() => _FormBuilderTouchSpinState();
+  FormBuilderTouchSpinState createState() => FormBuilderTouchSpinState();
 }
 
-class _FormBuilderTouchSpinState
+class FormBuilderTouchSpinState
     extends FormBuilderFieldState<FormBuilderTouchSpin, num> {}

packages/form_builder_extra_fields/lib/src/fields/form_builder_typeahead.dart

@@ -316,7 +316,7 @@ class FormBuilderTypeAhead<T> extends FormBuilderField<T> {
           decoration: decoration,
           focusNode: focusNode,
           builder: (FormFieldState<T?> field) {
-            final state = field as _FormBuilderTypeAheadState<T>;
+            final state = field as FormBuilderTypeAheadState<T>;
             final theme = Theme.of(state.context);
 
             return TypeAheadField<T>(
@@ -366,11 +366,10 @@ class FormBuilderTypeAhead<T> extends FormBuilderField<T> {
         );
 
   @override
-  _FormBuilderTypeAheadState<T> createState() =>
-      _FormBuilderTypeAheadState<T>();
+  FormBuilderTypeAheadState<T> createState() => FormBuilderTypeAheadState<T>();
 }
 
-class _FormBuilderTypeAheadState<T>
+class FormBuilderTypeAheadState<T>
     extends FormBuilderFieldState<FormBuilderTypeAhead<T>, T> {
   late TextEditingController _typeAheadController;