chore: added flutter_linting for code analysis & linting

Author: danvick

analysis_options.yaml

@@ -1,4 +1,4 @@
-include: package:pedantic/analysis_options.yaml
+include: package:flutter_lints/flutter.yaml
 
 analyzer:
   exclude:

packages/flutter_form_builder/analysis_options.yaml

@@ -0,0 +1 @@
+include: package:flutter_lints/flutter.yaml

packages/flutter_form_builder/lib/src/form_builder.dart

@@ -111,7 +111,7 @@ class FormBuilderState extends State<FormBuilder> {
     // assistance to accidental duplicate names, we check and emit a warning.
     assert(() {
       if (_fields.containsKey(name)) {
-        print('Warning! Replacing duplicate Field for $name'
+        debugPrint('Warning! Replacing duplicate Field for $name'
             ' -- this is OK to ignore as long as the field was intentionally replaced');
       }
       return true;
@@ -131,7 +131,7 @@ class FormBuilderState extends State<FormBuilder> {
       assert(() {
         // This is OK to ignore when you are intentionally replacing a field
         // with another field using the same name.
-        print('Warning! Ignoring Field unregistration for $name'
+        debugPrint('Warning! Ignoring Field unregistration for $name'
             ' -- this is OK to ignore as long as the field was intentionally replaced');
         return true;
       }());

packages/flutter_form_builder/lib/src/form_builder_field.dart

@@ -161,8 +161,8 @@ class FormBuilderFieldState<F extends FormBuilderField<T>, T>
   }
 
   @override
-  void didChange(T? val) {
-    super.didChange(val);
+  void didChange(T? value) {
+    super.didChange(value);
     widget.onChanged?.call(value);
   }
 

packages/flutter_form_builder/lib/src/widgets/grouped_checkbox.dart

@@ -179,7 +179,7 @@ class GroupedCheckbox<T> extends StatefulWidget {
 
   final ControlAffinity controlAffinity;
 
-  GroupedCheckbox({
+  const GroupedCheckbox({
     Key? key,
     required this.options,
     required this.orientation,

packages/flutter_form_builder/lib/src/widgets/grouped_radio.dart

@@ -171,7 +171,8 @@ class GroupedRadio<T> extends StatefulWidget {
 
   final ControlAffinity controlAffinity;
 
-  GroupedRadio({
+  const GroupedRadio({
+    Key? key,
     required this.options,
     required this.orientation,
     required this.onChanged,
@@ -191,7 +192,7 @@ class GroupedRadio<T> extends StatefulWidget {
     this.wrapVerticalDirection = VerticalDirection.down,
     this.separator,
     this.controlAffinity = ControlAffinity.leading,
-  });
+  }) : super(key: key);
 
   @override
   _GroupedRadioState<T> createState() => _GroupedRadioState<T>();

packages/flutter_form_builder/pubspec.yaml

@@ -12,6 +12,7 @@ dependencies:
   intl: ^0.17.0
 
 dev_dependencies:
+  flutter_lints: ^1.0.4
   flutter_test:
     sdk: flutter
 

packages/flutter_form_builder/test/flutter_form_builder_test.dart

@@ -13,7 +13,7 @@ void main() {
       name: textFieldName,
       builder: (FormFieldState<String?> field) {
         return InputDecorator(
-          decoration: InputDecoration(),
+          decoration: const InputDecoration(),
           child: TextField(
             onChanged: (value) => field.didChange(value),
           ),

packages/flutter_form_builder/test/form_builder_checkbox_group_test.dart

@@ -19,11 +19,11 @@ void main() {
 
     expect(formSave(), isTrue);
     expect(formValue(widgetName), isNull);
-    await tester.tap(find.byKey(ValueKey('1')));
+    await tester.tap(find.byKey(const ValueKey('1')));
     await tester.pumpAndSettle();
     expect(formSave(), isTrue);
     expect(formValue(widgetName), equals(const [1]));
-    await tester.tap(find.byKey(ValueKey('3')));
+    await tester.tap(find.byKey(const ValueKey('3')));
     await tester.pumpAndSettle();
     expect(formSave(), isTrue);
     expect(formValue(widgetName), equals(const [1, 3]));

packages/flutter_form_builder/test/form_builder_choice_chips_test.dart

@@ -19,11 +19,11 @@ void main() {
 
     expect(formSave(), isTrue);
     expect(formValue(widgetName), isNull);
-    await tester.tap(find.byKey(ValueKey('1')));
+    await tester.tap(find.byKey(const ValueKey('1')));
     await tester.pumpAndSettle();
     expect(formSave(), isTrue);
     expect(formValue(widgetName), equals(1));
-    await tester.tap(find.byKey(ValueKey('3')));
+    await tester.tap(find.byKey(const ValueKey('3')));
     await tester.pumpAndSettle();
     expect(formSave(), isTrue);
     expect(formValue(widgetName), equals(3));