feat: WIP remove decoration from default form field

Author: deandreamatias

lib/src/fields/form_builder_slider.dart

@@ -1,17 +1,7 @@
 import 'package:flutter/material.dart';
-
 import 'package:intl/intl.dart';
-
 import 'package:flutter_form_builder/flutter_form_builder.dart';
 
-/// Configuration to what values show on sliders
-///
-/// - `all`: Show all values
-/// - `current`: Show only the current value (middle)
-/// - `minMax`: Show only the min and max values (start and finish)
-/// - `none`: No show any values
-enum DisplayValues { all, current, minMax, none }
-
 /// Field for selection of a numerical value on a slider
 class FormBuilderSlider extends FormBuilderField<double> {
   /// Called when the user starts selecting a new value for the slider.

lib/src/fields/form_builder_text_field.dart

@@ -6,7 +6,7 @@ import 'package:flutter/services.dart';
 import 'package:flutter_form_builder/flutter_form_builder.dart';
 
 /// A Material Design text field input.
-class FormBuilderTextField extends FormBuilderField<String> {
+class FormBuilderTextField extends FormBuilderFieldDecoration<String> {
   /// Controls the text being edited.
   ///
   /// If null, this widget will create its own [TextEditingController].
@@ -271,13 +271,14 @@ class FormBuilderTextField extends FormBuilderField<String> {
   ///{@macro flutter.widgets.text_selection.TextMagnifierConfiguration.details}
   final TextMagnifierConfiguration? magnifierConfiguration;
 
+  /// By default `false`
+  final bool readOnly;
+
   /// Creates a Material Design text field input.
   FormBuilderTextField({
     super.key,
     required super.name,
     super.validator,
-    String? initialValue,
-    bool readOnly = false,
     super.decoration,
     super.onChanged,
     super.valueTransformer,
@@ -287,6 +288,8 @@ class FormBuilderTextField extends FormBuilderField<String> {
     super.onReset,
     super.focusNode,
     super.restorationId,
+    String? initialValue,
+    this.readOnly = false,
     this.maxLines = 1,
     this.obscureText = false,
     this.textCapitalization = TextCapitalization.none,
@@ -348,8 +351,6 @@ class FormBuilderTextField extends FormBuilderField<String> {
           initialValue: controller != null ? controller.text : initialValue,
           builder: (FormFieldState<String?> field) {
             final state = field as _FormBuilderTextFieldState;
-            /*final effectiveDecoration = (decoration ?? const InputDecoration())
-                .applyDefaults(Theme.of(field.context).inputDecorationTheme);*/
 
             return TextField(
               restorationId: restorationId,
@@ -414,12 +415,12 @@ class FormBuilderTextField extends FormBuilderField<String> {
   }
 
   @override
-  FormBuilderFieldState<FormBuilderTextField, String> createState() =>
+  FormBuilderFieldDecorationState<FormBuilderTextField, String> createState() =>
       _FormBuilderTextFieldState();
 }
 
 class _FormBuilderTextFieldState
-    extends FormBuilderFieldState<FormBuilderTextField, String> {
+    extends FormBuilderFieldDecorationState<FormBuilderTextField, String> {
   TextEditingController? get _effectiveController =>
       widget.controller ?? _controller;
 

lib/src/form_builder_field.dart

@@ -38,8 +38,8 @@ class FormBuilderField<T> extends FormField<T> {
   /// Called when the field value is changed.
   final ValueChanged<T?>? onChanged;
 
-  /// The border, labels, icons, and styles used to decorate the field.
-  final InputDecoration decoration;
+  // /// The border, labels, icons, and styles used to decorate the field.
+  // final InputDecoration decoration;
 
   /// Called when the field value is reset.
   final VoidCallback? onReset;
@@ -60,11 +60,27 @@ class FormBuilderField<T> extends FormField<T> {
     required this.name,
     this.valueTransformer,
     this.onChanged,
-    this.decoration = const InputDecoration(),
     this.onReset,
     this.focusNode,
   });
 
+  const factory FormBuilderField.decoration({
+    Key? key,
+    void Function(T?)? onSaved,
+    T? initialValue,
+    AutovalidateMode? autovalidateMode,
+    bool enabled,
+    String? Function(T?)? validator,
+    String? restorationId,
+    required Widget Function(FormFieldState<T>) builder,
+    required String name,
+    ValueTransformer<T?>? valueTransformer,
+    ValueChanged<T?>? onChanged,
+    VoidCallback? onReset,
+    FocusNode? focusNode,
+    InputDecoration decoration,
+  }) = FormBuilderFieldDecoration;
+
   @override
   FormBuilderFieldState<FormBuilderField<T>, T> createState() =>
       FormBuilderFieldState<FormBuilderField<T>, T>();
@@ -98,12 +114,10 @@ class FormBuilderFieldState<F extends FormBuilderField<T>, T>
   String? get errorText => super.errorText ?? _customErrorText;
 
   @override
-  bool get hasError =>
-      super.hasError || decoration.errorText != null || errorText != null;
+  bool get hasError => super.hasError || errorText != null;
 
   @override
-  bool get isValid =>
-      super.isValid && decoration.errorText == null && errorText == null;
+  bool get isValid => super.isValid && errorText == null;
 
   bool get enabled => widget.enabled && (_formBuilderState?.enabled ?? true);
   bool get _readOnly => !(_formBuilderState?.widget.skipDisabled ?? false);
@@ -124,12 +138,12 @@ class FormBuilderFieldState<F extends FormBuilderField<T>, T>
   /// The field is focused by user or by logic code
   bool get isTouched => _touched;
 
-  InputDecoration get decoration => widget.decoration.copyWith(
-        errorText: widget.enabled || _readOnly
-            ? widget.decoration.errorText ?? errorText
-            : null,
-        enabled: widget.enabled || _readOnly,
-      );
+  // InputDecoration get decoration => widget.decoration.copyWith(
+  //       errorText: widget.enabled || _readOnly
+  //           ? widget.decoration.errorText ?? errorText
+  //           : null,
+  //       enabled: widget.enabled || _readOnly,
+  //     );
 
   void registerTransformer(Map<String, Function> map) {
     final fun = widget.valueTransformer;
@@ -298,3 +312,47 @@ class FormBuilderFieldState<F extends FormBuilderField<T>, T>
     Scrollable.ensureVisible(context);
   }
 }
+
+class FormBuilderFieldDecoration<T> extends FormBuilderField<T> {
+  const FormBuilderFieldDecoration({
+    super.key,
+    super.onSaved,
+    super.initialValue,
+    super.autovalidateMode,
+    super.enabled = true,
+    super.validator,
+    super.restorationId,
+    required super.name,
+    super.valueTransformer,
+    super.onChanged,
+    super.onReset,
+    super.focusNode,
+    required super.builder,
+    this.decoration = const InputDecoration(),
+  });
+  final InputDecoration decoration;
+
+  @override
+  FormBuilderFieldDecorationState<FormBuilderFieldDecoration<T>, T>
+      createState() =>
+          FormBuilderFieldDecorationState<FormBuilderFieldDecoration<T>, T>();
+}
+
+class FormBuilderFieldDecorationState<F extends FormBuilderFieldDecoration<T>,
+    T> extends FormBuilderFieldState<FormBuilderField<T>, T> {
+  @override
+  F get widget => super.widget as F;
+
+  InputDecoration get decoration => widget.decoration.copyWith(
+        errorText: widget.enabled || _readOnly
+            ? widget.decoration.errorText ?? errorText
+            : null,
+        enabled: widget.enabled || _readOnly,
+      );
+
+  @override
+  bool get hasError => super.hasError || widget.decoration.errorText != null;
+
+  @override
+  bool get isValid => super.isValid && widget.decoration.errorText == null;
+}

lib/src/form_builder_input_decoration.dart

@@ -0,0 +1,9 @@
+import 'package:flutter/material.dart';
+
+mixin FormBuilderInputDecoration {
+  final InputDecoration decoration = const InputDecoration();
+
+  InputDecoration get getdecoration => decoration.copyWith();
+
+  bool get hasDecorationError => decoration.errorText != null;
+}