Fix more analysis issues

Author: danvick

analysis_options.yaml

@@ -1 +1,5 @@
 include: package:pedantic/analysis_options.yaml
+
+analyzer:
+  exclude:
+    - lib/l10n/**

lib/src/fields/form_builder_checkbox.dart

@@ -82,5 +82,6 @@ class FormBuilderCheckbox extends FormBuilderField<bool> {
 }
 
 class _FormBuilderCheckboxState extends FormBuilderFieldState<bool> {
+  @override
   FormBuilderCheckbox get widget => super.widget;
 }

lib/src/fields/form_builder_chips_input.dart

@@ -33,6 +33,7 @@ class FormBuilderChipsInput<T> extends FormBuilderField {
   final bool obscureText;
   final double suggestionsBoxMaxHeight;
   final TextCapitalization textCapitalization;
+  @override
   final FormFieldSetter onSaved;
   final FocusNode focusNode;
   final bool allowChipEditing;

lib/src/fields/form_builder_color_picker.dart

@@ -151,6 +151,7 @@ class FormBuilderColorPickerField extends FormBuilderField<Color> {
 }
 
 class _FormBuilderColorPickerFieldState extends FormBuilderFieldState<Color> {
+  @override
   FormBuilderColorPickerField get widget => super.widget;
 
   FocusNode _effectiveFocusNode;
@@ -208,7 +209,7 @@ class _FormBuilderColorPickerFieldState extends FormBuilderFieldState<Color> {
     }
   }
 
-  _buildColorPicker() {
+  Widget _buildColorPicker() {
     switch (widget.colorPickerType) {
       case ColorPickerType.ColorPicker:
         return ColorPicker(

lib/src/fields/form_builder_radio_list.dart

@@ -47,7 +47,7 @@ class FormBuilderRadioList extends FormBuilderField {
           readOnly: readOnly,
           builder: (FormFieldState field) {
             final _FormBuilderRadioState state = field;
-            List<Widget> radioList = [];
+            var radioList = [];
             for (var i = 0; i < options.length; i++) {
               radioList.addAll([
                 RadioListTile(
@@ -75,7 +75,7 @@ class FormBuilderRadioList extends FormBuilderField {
                 errorText: field.errorText,
               ),
               child: Column(
-                children: radioList,
+                children: List<Widget>.from(radioList),
               ),
             );
           },

lib/src/fields/form_builder_switch.dart

@@ -133,5 +133,6 @@ class FormBuilderSwitch extends FormBuilderField {
 }
 
 class _FormBuilderSwitchState extends FormBuilderFieldState {
+  @override
   FormBuilderSwitch get widget => super.widget;
 }

lib/src/fields/form_builder_typeahead.dart

@@ -4,7 +4,7 @@ import 'package:flutter_form_builder/flutter_form_builder.dart';
 import 'package:flutter_form_builder/src/always_disabled_focus_node.dart';
 import 'package:flutter_typeahead/flutter_typeahead.dart';
 
-typedef String SelectionToTextTransformer<T>(T suggestion);
+typedef SelectionToTextTransformer<T> = String Function(T suggestion);
 
 class FormBuilderTypeAhead<T> extends FormBuilderField {
   @override

test/flutter_form_builder_test.dart

@@ -3,54 +3,54 @@ import 'package:flutter_form_builder/flutter_form_builder.dart';
 
 void main() {
   test('FormBuilderValidators.required', () {
-    expect(FormBuilderValidators.required()("something long"), isNull);
+    expect(FormBuilderValidators.required()('something long'), isNull);
     expect(FormBuilderValidators.required()(DateTime.now()), isNull);
     expect(FormBuilderValidators.required()(''), isNotNull);
     expect(FormBuilderValidators.required()([]), isNotNull);
     // expect(FormBuilderValidators.maxLength(5)(5), equals(null));
   });
 
   test('FormBuilderValidators.maxLength', () {
-    expect(FormBuilderValidators.maxLength(5)("something long"), equals("Value must have a length less than or equal to 5"));
-    expect(FormBuilderValidators.maxLength(5)("two"), equals(null));
+    expect(FormBuilderValidators.maxLength(5)('something long'), equals('Value must have a length less than or equal to 5'));
+    expect(FormBuilderValidators.maxLength(5)('two'), equals(null));
     // expect(FormBuilderValidators.maxLength(5)(5), equals(null));
   });
 
   test('FormBuilderValidators.email', () {
-    expect(FormBuilderValidators.email()("john@flutter"), isNotNull);
-    expect(FormBuilderValidators.email()("[email protected]"), isNull);
-    expect(FormBuilderValidators.email()(" [email protected] "), isNull);
-    expect(FormBuilderValidators.email()("[email protected] "), isNull);
-    expect(FormBuilderValidators.email()(" [email protected]"), isNull);
+    expect(FormBuilderValidators.email()('john@flutter'), isNotNull);
+    expect(FormBuilderValidators.email()('[email protected]'), isNull);
+    expect(FormBuilderValidators.email()(' [email protected] '), isNull);
+    expect(FormBuilderValidators.email()('[email protected] '), isNull);
+    expect(FormBuilderValidators.email()(' [email protected]'), isNull);
     expect(FormBuilderValidators.email()(null), isNull);
-    expect(FormBuilderValidators.email()(""),isNull);
+    expect(FormBuilderValidators.email()(''),isNull);
   });
 
   test('FormBuilderValidators.max', () {
-    expect(FormBuilderValidators.max(20)("70"), isNotNull);
+    expect(FormBuilderValidators.max(20)('70'), isNotNull);
     expect(FormBuilderValidators.max(30)(70), isNotNull);
     expect(FormBuilderValidators.max(30)(20), isNull);
   });
 
   test('FormBuilderValidators.min', () {
-    expect(FormBuilderValidators.min(30)("10"), isNotNull);
+    expect(FormBuilderValidators.min(30)('10'), isNotNull);
     expect(FormBuilderValidators.min(30)(10), isNotNull);
     expect(FormBuilderValidators.min(30)(70), isNull);
   });
 
   test('FormBuilderValidators.url', () {
     expect(FormBuilderValidators.url()(null), isNull);
-    expect(FormBuilderValidators.url()("https://www.google.com"), isNull);
-    expect(FormBuilderValidators.url()("www.google.com"), isNull);
-    expect(FormBuilderValidators.url()("google.com"), isNull);
-    expect(FormBuilderValidators.url()("http://google.com"), isNull);
-    expect(FormBuilderValidators.url()(".com"), isNotNull);
-    expect(FormBuilderValidators.url(protocols: ['https', 'http'], errorText: "Only HTTP and HTTPS allowed")("ftp://www.google.com"), isNotNull);
+    expect(FormBuilderValidators.url()('https://www.google.com'), isNull);
+    expect(FormBuilderValidators.url()('www.google.com'), isNull);
+    expect(FormBuilderValidators.url()('google.com'), isNull);
+    expect(FormBuilderValidators.url()('http://google.com'), isNull);
+    expect(FormBuilderValidators.url()('.com'), isNotNull);
+    expect(FormBuilderValidators.url(protocols: ['https', 'http'], errorText: 'Only HTTP and HTTPS allowed')('ftp://www.google.com'), isNotNull);
   });
 
   test('FormBuilderValidators.IP', () {
     expect(FormBuilderValidators.IP()(null), isNull);
-    expect(FormBuilderValidators.IP()("192.168.0.1"), isNull);
-    expect(FormBuilderValidators.IP()("256.168.0.1"), isNotNull);
+    expect(FormBuilderValidators.IP()('192.168.0.1'), isNull);
+    expect(FormBuilderValidators.IP()('256.168.0.1'), isNotNull);
   });
 }