Skip to content

Commit ea398fa

Browse files
committed
Fix bug where ValueTransformer called with null. Fixes #804
1 parent 56c8c27 commit ea398fa

14 files changed

+17
-16
lines changed

example/lib/sources/complete_form.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,19 +184,20 @@ class CompleteFormState extends State<CompleteForm> {
184184
))
185185
.toList(),
186186
onChanged: (val) {
187-
print(val);
188187
setState(() {
189188
_genderHasError = !(_formKey
190189
.currentState?.fields['gender']
191190
?.validate() ??
192191
false);
193192
});
194193
},
194+
valueTransformer: (val) => val?.toString(),
195195
),
196196
FormBuilderRadioGroup<String>(
197197
decoration: const InputDecoration(
198198
labelText: 'My chosen language',
199199
),
200+
initialValue: null,
200201
name: 'best_language',
201202
onChanged: _onChanged,
202203
validator: FormBuilderValidators.compose(
@@ -238,7 +239,7 @@ class CompleteFormState extends State<CompleteForm> {
238239
decoration: const InputDecoration(
239240
labelText: 'The language of my people'),
240241
name: 'languages',
241-
initialValue: const ['Dart'],
242+
// initialValue: const ['Dart'],
242243
options: const [
243244
FormBuilderFieldOption(value: 'Dart'),
244245
FormBuilderFieldOption(value: 'Kotlin'),

lib/src/fields/form_builder_checkbox.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,9 @@ class FormBuilderCheckbox extends FormBuilderField<bool> {
8080
disabledBorder: InputBorder.none,
8181
),
8282
ValueChanged<bool?>? onChanged,
83-
ValueTransformer<bool>? valueTransformer,
83+
ValueTransformer<bool?>? valueTransformer,
8484
bool enabled = true,
85-
FormFieldSetter<bool>? onSaved,
85+
FormFieldSetter<bool?>? onSaved,
8686
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,
8787
VoidCallback? onReset,
8888
FocusNode? focusNode,

lib/src/fields/form_builder_checkbox_group.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class FormBuilderCheckboxGroup<T> extends FormBuilderField<List<T>> {
3434
List<T>? initialValue,
3535
InputDecoration decoration = const InputDecoration(),
3636
ValueChanged<List<T>?>? onChanged,
37-
ValueTransformer<List<T>>? valueTransformer,
37+
ValueTransformer<List<T>?>? valueTransformer,
3838
bool enabled = true,
3939
FormFieldSetter<List<T>>? onSaved,
4040
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

lib/src/fields/form_builder_choice_chips.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ class FormBuilderChoiceChip<T> extends FormBuilderField<T> {
248248
T? initialValue,
249249
InputDecoration decoration = const InputDecoration(),
250250
ValueChanged<T?>? onChanged,
251-
ValueTransformer<T>? valueTransformer,
251+
ValueTransformer<T?>? valueTransformer,
252252
bool enabled = true,
253253
FormFieldSetter<T>? onSaved,
254254
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

lib/src/fields/form_builder_date_range_picker.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class FormBuilderDateRangePicker extends FormBuilderField<DateTimeRange> {
6969
DateTimeRange? initialValue,
7070
InputDecoration decoration = const InputDecoration(),
7171
ValueChanged<DateTimeRange?>? onChanged,
72-
ValueTransformer<DateTimeRange>? valueTransformer,
72+
ValueTransformer<DateTimeRange?>? valueTransformer,
7373
bool enabled = true,
7474
FormFieldSetter<DateTimeRange>? onSaved,
7575
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

lib/src/fields/form_builder_date_time_picker.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ class FormBuilderDateTimePicker extends FormBuilderField<DateTime> {
136136
DateTime? initialValue,
137137
InputDecoration decoration = const InputDecoration(),
138138
ValueChanged<DateTime?>? onChanged,
139-
ValueTransformer<DateTime>? valueTransformer,
139+
ValueTransformer<DateTime?>? valueTransformer,
140140
bool enabled = true,
141141
FormFieldSetter<DateTime>? onSaved,
142142
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

lib/src/fields/form_builder_dropdown.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ class FormBuilderDropdown<T> extends FormBuilderField<T> {
190190
T? initialValue,
191191
InputDecoration decoration = const InputDecoration(),
192192
ValueChanged<T?>? onChanged,
193-
ValueTransformer<T>? valueTransformer,
193+
ValueTransformer<T?>? valueTransformer,
194194
bool enabled = true,
195195
FormFieldSetter<T>? onSaved,
196196
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

lib/src/fields/form_builder_filter_chips.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class FormBuilderFilterChip<T> extends FormBuilderField<List<T>> {
4848
disabledBorder: InputBorder.none,
4949
),
5050
ValueChanged<List<T>?>? onChanged,
51-
ValueTransformer<List<T>>? valueTransformer,
51+
ValueTransformer<List<T>?>? valueTransformer,
5252
bool enabled = true,
5353
FormFieldSetter<List<T>>? onSaved,
5454
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

lib/src/fields/form_builder_radio_group.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class FormBuilderRadioGroup<T> extends FormBuilderField<T> {
3232
T? initialValue,
3333
InputDecoration decoration = const InputDecoration(),
3434
ValueChanged<T?>? onChanged,
35-
ValueTransformer<T>? valueTransformer,
35+
ValueTransformer<T?>? valueTransformer,
3636
bool enabled = true,
3737
FormFieldSetter<T>? onSaved,
3838
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

lib/src/fields/form_builder_range_slider.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ class FormBuilderRangeSlider extends FormBuilderField<RangeValues> {
113113
RangeValues? initialValue,
114114
InputDecoration decoration = const InputDecoration(),
115115
ValueChanged<RangeValues?>? onChanged,
116-
ValueTransformer<RangeValues>? valueTransformer,
116+
ValueTransformer<RangeValues?>? valueTransformer,
117117
bool enabled = true,
118118
FormFieldSetter<RangeValues>? onSaved,
119119
AutovalidateMode autovalidateMode = AutovalidateMode.disabled,

0 commit comments

Comments
 (0)