chore: proper code analysis and clean-up

Author: danvick

analysis_options.yaml

@@ -0,0 +1 @@
+include: package:flutter_lints/flutter.yaml

example/lib/main.dart

@@ -4,10 +4,12 @@ import 'package:flutter_form_builder/flutter_form_builder.dart';
 import 'package:form_builder_image_picker/form_builder_image_picker.dart';
 
 void main() {
-  runApp(MyApp());
+  runApp(const MyApp());
 }
 
 class MyApp extends StatelessWidget {
+  const MyApp({Key? key}) : super(key: key);
+
   // This widget is the root of your application.
   @override
   Widget build(BuildContext context) {
@@ -33,11 +35,13 @@ class ApiImage {
 class MyHomePage extends StatelessWidget {
   final _formKey = GlobalKey<FormBuilderState>();
 
+  MyHomePage({Key? key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     return Scaffold(
       appBar: AppBar(
-        title: Text('FormBuilderImagePicker Example'),
+        title: const Text('FormBuilderImagePicker Example'),
       ),
       body: Padding(
         padding: const EdgeInsets.all(8.0),
@@ -55,7 +59,7 @@ class MyHomePage extends StatelessWidget {
                   maxImages: 5,
                   initialValue: [
                     'https://images.pexels.com/photos/7078045/pexels-photo-7078045.jpeg?auto=compress&cs=tinysrgb&dpr=2&h=750&w=1260',
-                    Text('this is an image\nas a widget !'),
+                    const Text('this is an image\nas a widget !'),
                     ApiImage(
                       id: 'whatever',
                       imageUrl:
@@ -65,15 +69,15 @@ class MyHomePage extends StatelessWidget {
                 ),
                 const SizedBox(height: 15),
                 ElevatedButton(
-                  child: Text('Submit'),
+                  child: const Text('Submit'),
                   onPressed: () {
                     if (_formKey.currentState?.saveAndValidate() == true) {
-                      print(_formKey.currentState!.value);
+                      debugPrint(_formKey.currentState!.value.toString());
                     }
                   },
                 ),
                 ElevatedButton(
-                  child: Text('Reset'),
+                  child: const Text('Reset'),
                   onPressed: () {
                     _formKey.currentState?.reset();
                   },

example/pubspec.lock

@@ -95,6 +95,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "7.0.0"
+  flutter_lints:
+    dependency: "direct dev"
+    description:
+      name: flutter_lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.4"
   flutter_plugin_android_lifecycle:
     dependency: transitive
     description:
@@ -178,6 +185,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "0.6.3"
+  lints:
+    dependency: transitive
+    description:
+      name: lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.1"
   matcher:
     dependency: transitive
     description:

example/pubspec.yaml

@@ -14,6 +14,7 @@ dependencies:
     path: ../
 
 dev_dependencies:
+  flutter_lints: ^1.0.4
   flutter_test:
     sdk: flutter
   integration_test:

example/test/widget_test.dart

@@ -5,15 +5,14 @@
 // gestures. You can also use WidgetTester to find child widgets in the widget
 // tree, read text, and verify that the values of widget properties are correct.
 
+import 'package:example/main.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 
-import 'package:example/main.dart';
-
 void main() {
   testWidgets('Counter increments smoke test', (WidgetTester tester) async {
     // Build our app and trigger a frame.
-    await tester.pumpWidget(MyApp());
+    await tester.pumpWidget(const MyApp());
 
     // Verify that our counter starts at 0.
     expect(find.text('0'), findsOneWidget);

lib/src/form_builder_image_picker.dart

@@ -1,4 +1,5 @@
 import 'dart:typed_data';
+
 import 'package:async/async.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
@@ -119,7 +120,7 @@ class FormBuilderImagePicker extends FormBuilderField<List<dynamic>> {
 
             return InputDecorator(
               decoration: state.decoration,
-              child: Container(
+              child: SizedBox(
                 height: previewHeight,
                 child: ListView.builder(
                   scrollDirection: Axis.horizontal,
@@ -277,6 +278,7 @@ class _FormBuilderImagePickerState
     extends FormBuilderFieldState<FormBuilderImagePicker, List<dynamic>> {
   List<dynamic> get effectiveValue =>
       value?.where((element) => element != null).toList() ?? [];
+
   bool get hasMaxImages {
     final ev = effectiveValue;
     return widget.maxImages != null && ev.length >= widget.maxImages!;
@@ -293,6 +295,7 @@ class XFileImage extends StatefulWidget {
   final XFile file;
   final BoxFit? fit;
   final WidgetBuilder? loadingWidget;
+
   @override
   State<XFileImage> createState() => _XFileImageState();
 }
@@ -308,9 +311,7 @@ class _XFileImageState extends State<XFileImage> {
         final data = snapshot.data;
         if (data == null) {
           return widget.loadingWidget?.call(context) ??
-              Center(
-                child: CircularProgressIndicator(),
-              );
+              const Center(child: CircularProgressIndicator());
         }
         return Image.memory(data, fit: widget.fit);
       },

lib/src/image_source_sheet.dart

@@ -32,7 +32,7 @@ class ImageSourceBottomSheet extends StatefulWidget {
   final EdgeInsets? bottomSheetPadding;
   final bool preventPop;
 
-  ImageSourceBottomSheet({
+  const ImageSourceBottomSheet({
     Key? key,
     this.remainingImages,
     this.preventPop = false,
@@ -79,7 +79,7 @@ class _ImageSourceBottomSheetState extends State<ImageSourceBottomSheet> {
           imageQuality: widget.imageQuality,
         );
         _isPickingImage = false;
-        if (pickedFiles != null && pickedFiles.length > 0) {
+        if (pickedFiles != null && pickedFiles.isNotEmpty) {
           widget.onImageSelected(pickedFiles);
         }
       }

pubspec.lock

@@ -49,7 +49,7 @@ packages:
       name: cross_file
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.3.1+5"
+    version: "0.3.2"
   fake_async:
     dependency: transitive
     description:
@@ -68,19 +68,21 @@ packages:
       name: flutter_form_builder
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "6.1.0+1"
-  flutter_localizations:
-    dependency: transitive
-    description: flutter
-    source: sdk
-    version: "0.0.0"
+    version: "7.0.0"
+  flutter_lints:
+    dependency: "direct dev"
+    description:
+      name: flutter_lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.4"
   flutter_plugin_android_lifecycle:
     dependency: transitive
     description:
       name: flutter_plugin_android_lifecycle
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.1"
+    version: "2.0.4"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -92,12 +94,12 @@ packages:
     source: sdk
     version: "0.0.0"
   http:
-    dependency: "direct main"
+    dependency: transitive
     description:
       name: http
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.13.3"
+    version: "0.13.4"
   http_parser:
     dependency: transitive
     description:
@@ -111,14 +113,14 @@ packages:
       name: image_picker
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.8.4"
+    version: "0.8.4+4"
   image_picker_for_web:
-    dependency: "direct main"
+    dependency: transitive
     description:
       name: image_picker_for_web
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.1.3"
+    version: "2.1.4"
   image_picker_platform_interface:
     dependency: transitive
     description:
@@ -140,6 +142,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "0.6.3"
+  lints:
+    dependency: transitive
+    description:
+      name: lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.1"
   matcher:
     dependency: transitive
     description:
@@ -161,20 +170,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.8.0"
-  pedantic:
-    dependency: transitive
-    description:
-      name: pedantic
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "1.11.0"
   plugin_platform_interface:
     dependency: transitive
     description:
       name: plugin_platform_interface
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.0"
+    version: "2.0.2"
   sky_engine:
     dependency: transitive
     description: flutter
@@ -237,5 +239,5 @@ packages:
     source: hosted
     version: "2.1.0"
 sdks:
-  dart: ">=2.12.0 <3.0.0"
-  flutter: ">=2.0.0"
+  dart: ">=2.14.0 <3.0.0"
+  flutter: ">=2.5.0"

pubspec.yaml

@@ -16,6 +16,7 @@ dependencies:
   # http: ^0.13.1
 
 dev_dependencies:
+  flutter_lints: ^1.0.4
   flutter_test:
     sdk: flutter