Fixes

Author: martijn00

lib/localization/l10n.dart

@@ -1,3 +1,4 @@
+// coverage:ignore-file
 import 'dart:async';
 
 import 'package:flutter/foundation.dart';

lib/src/network/url_validator.dart

@@ -99,34 +99,34 @@ class UrlValidator extends BaseValidator<String> {
     } else if (requireProtocol == true) {
       return false;
     }
-    str = split.join('://');
+    final String str1 = split.join('://');
 
     // check hash
-    split = str.split('#');
-    str = shift(split);
+    split = str1.split('#');
+    final String str2 = shift(split);
     hash = split.join('#');
     if (hash.isNotEmpty && RegExp(r'\s').hasMatch(hash)) {
       return false;
     }
 
     // check query params
-    split = str.split('?');
-    str = shift(split);
+    split = str2.split('?');
+    final String str3 = shift(split);
     query = split.join('?');
     if (query.isNotEmpty && RegExp(r'\s').hasMatch(query)) {
       return false;
     }
 
     // check path
-    split = str.split('/');
-    str = shift(split);
+    split = str3.split('/');
+    final String str4 = shift(split);
     path = split.join('/');
     if (path.isNotEmpty && RegExp(r'\s').hasMatch(path)) {
       return false;
     }
 
     // check auth type urls
-    split = str.split('@');
+    split = str4.split('@');
     if (split.length > 1) {
       auth = shift(split);
       if (auth?.contains(':') ?? false) {

test/src/identity/username_validator_test.dart

@@ -206,5 +206,187 @@ void main() {
       // Assert
       expect(result, isNull);
     });
+
+    // Additional tests to cover FormBuilderLocalizations
+    test('should return localized error if username is too short', () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        minLength: 5,
+        errorText: FormBuilderLocalizations.current.minLengthErrorText(5),
+      );
+      const String shortUsername = 'usr';
+
+      // Act
+      final String? result = validator.validate(shortUsername);
+
+      // Assert
+      expect(result, FormBuilderLocalizations.current.minLengthErrorText(5));
+    });
+
+    test('should return localized error if username is too long', () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        maxLength: 10,
+        errorText: FormBuilderLocalizations.current.maxLengthErrorText(10),
+      );
+      const String longUsername = 'thisIsAVeryLongUsername';
+
+      // Act
+      final String? result = validator.validate(longUsername);
+
+      // Assert
+      expect(result, FormBuilderLocalizations.current.maxLengthErrorText(10));
+    });
+
+    test(
+        'should return localized error if numbers are not allowed and username contains numbers',
+        () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        allowNumbers: false,
+        errorText: FormBuilderLocalizations
+            .current.usernameCannotContainNumbersErrorText,
+      );
+      const String usernameWithNumbers = 'user123';
+
+      // Act
+      final String? result = validator.validate(usernameWithNumbers);
+
+      // Assert
+      expect(
+        result,
+        FormBuilderLocalizations.current.usernameCannotContainNumbersErrorText,
+      );
+    });
+
+    test(
+        'should return localized error if underscores are not allowed and username contains underscores',
+        () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        errorText: FormBuilderLocalizations
+            .current.usernameCannotContainUnderscoreErrorText,
+      );
+      const String usernameWithUnderscore = 'user_name';
+
+      // Act
+      final String? result = validator.validate(usernameWithUnderscore);
+
+      // Assert
+      expect(
+        result,
+        FormBuilderLocalizations
+            .current.usernameCannotContainUnderscoreErrorText,
+      );
+    });
+
+    test(
+        'should return localized error if dots are not allowed and username contains dots',
+        () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        errorText:
+            FormBuilderLocalizations.current.usernameCannotContainDotsErrorText,
+      );
+      const String usernameWithDot = 'user.name';
+
+      // Act
+      final String? result = validator.validate(usernameWithDot);
+
+      // Assert
+      expect(
+        result,
+        FormBuilderLocalizations.current.usernameCannotContainDotsErrorText,
+      );
+    });
+
+    test(
+        'should return localized error if dashes are not allowed and username contains dashes',
+        () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        errorText: FormBuilderLocalizations
+            .current.usernameCannotContainDashesErrorText,
+      );
+      const String usernameWithDash = 'user-name';
+
+      // Act
+      final String? result = validator.validate(usernameWithDash);
+
+      // Assert
+      expect(
+        result,
+        FormBuilderLocalizations.current.usernameCannotContainDashesErrorText,
+      );
+    });
+
+    test(
+        'should return localized error if spaces are not allowed and username contains spaces',
+        () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        errorText: FormBuilderLocalizations
+            .current.usernameCannotContainSpacesErrorText,
+      );
+      const String usernameWithSpace = 'user name';
+
+      // Act
+      final String? result = validator.validate(usernameWithSpace);
+
+      // Assert
+      expect(
+        result,
+        FormBuilderLocalizations.current.usernameCannotContainSpacesErrorText,
+      );
+    });
+
+    test(
+        'should return localized error if special characters are not allowed and username contains special characters',
+        () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        errorText: FormBuilderLocalizations
+            .current.usernameCannotContainSpecialCharErrorText,
+      );
+      const String usernameWithSpecialChar = 'user@name';
+
+      // Act
+      final String? result = validator.validate(usernameWithSpecialChar);
+
+      // Assert
+      expect(
+        result,
+        FormBuilderLocalizations
+            .current.usernameCannotContainSpecialCharErrorText,
+      );
+    });
+
+    test('should return localized error if value is null', () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        errorText: FormBuilderLocalizations.current.usernameErrorText,
+      );
+      const String? value = null;
+
+      // Act
+      final String? result = validator.validate(value);
+
+      // Assert
+      expect(result, FormBuilderLocalizations.current.usernameErrorText);
+    });
+
+    test('should return localized error if value is empty', () {
+      // Arrange
+      final UsernameValidator validator = UsernameValidator(
+        errorText: FormBuilderLocalizations.current.usernameErrorText,
+      );
+      const String value = '';
+
+      // Act
+      final String? result = validator.validate(value);
+
+      // Assert
+      expect(result, FormBuilderLocalizations.current.usernameErrorText);
+    });
   });
 }