Skip to content

Commit 000e106

Browse files
committed
fix: I have addressed the bug where the headlines feed would get stuck on the initial loading screen.
1 parent fc77f5b commit 000e106

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

lib/headlines-feed/bloc/headlines_feed_bloc.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class HeadlinesFeedBloc extends Bloc<HeadlinesFeedEvent, HeadlinesFeedState> {
2828
/// Requires a [HtDataRepository<Headline>] to interact with the data layer.
2929
HeadlinesFeedBloc({required HtDataRepository<Headline> headlinesRepository})
3030
: _headlinesRepository = headlinesRepository,
31-
super(HeadlinesFeedLoading()) {
31+
super(HeadlinesFeedInitial()) {
3232
on<HeadlinesFeedFetchRequested>(
3333
_onHeadlinesFeedFetchRequested,
3434
transformer:

lib/headlines-feed/bloc/headlines_feed_state.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ sealed class HeadlinesFeedState extends Equatable {
1111
List<Object?> get props => [];
1212
}
1313

14+
/// {@template headlines_feed_initial}
15+
/// The initial state of the headlines feed before any loading has begun.
16+
/// {@endtemplate}
17+
final class HeadlinesFeedInitial extends HeadlinesFeedState {}
18+
1419
/// {@template headlines_feed_loading}
1520
/// State indicating that the headlines feed is currently being fetched,
1621
/// typically shown with a full-screen loading indicator. This is used for

lib/headlines-feed/view/headlines_feed_page.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ class _HeadlinesFeedPageState extends State<HeadlinesFeedPage> {
151151
(previous, current) => current is! HeadlinesFeedLoadingSilently,
152152
builder: (context, state) {
153153
switch (state) {
154+
case HeadlinesFeedInitial(): // Handle initial state
154155
case HeadlinesFeedLoading():
155156
// Display full-screen loading indicator
156157
return LoadingStateWidget(

0 commit comments

Comments
 (0)