refactor: remove AdaptiveScaffold

- Simplifies routing
- Removes unused dependency

Author: fulleni

lib/app/view/app_scaffold.dart

@@ -2,7 +2,6 @@ import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:go_router/go_router.dart';
 import 'package:ht_main/app/bloc/app_bloc.dart';
-import 'package:ht_main/app/view/app_scaffold.dart';
 import 'package:ht_main/authentication/view/authentication_page.dart';
 import 'package:ht_main/headline-details/view/headline_details_page.dart';
 import 'package:ht_main/headlines-feed/view/headlines_feed_page.dart';
@@ -13,34 +12,57 @@ final appRouter = GoRouter(
   initialLocation: Routes.headlinesFeed,
   redirect: (BuildContext context, GoRouterState state) {
     final appStatus = context.read<AppBloc>().state.status;
-    if (appStatus == AppStatus.authenticated) {
+    if (appStatus != AppStatus.authenticated) {
       return Routes.headlinesFeed;
     } else {
       return Routes.authentication;
     }
   },
   routes: [
-    ShellRoute(
-      builder: (context, state, child) {
-        return AppScaffold(child: child);
+    GoRoute(
+      path: Routes.authentication,
+      name: Routes.authenticationName,
+      builder: (BuildContext context, GoRouterState state) {
+        return const AuthenticationPage();
       },
       routes: [
         GoRoute(
-          path: Routes.headlinesFeed,
-          name: Routes.headlinesFeedName,
+          path: Routes.forgotPassword,
+          name: Routes.forgotPasswordName,
           builder: (BuildContext context, GoRouterState state) {
-            return const HeadlinesFeedPage();
+            return const Placeholder(child: Text('Forgot Password Page'));
+          },
+        ),
+        GoRoute(
+          path: Routes.resetPassword,
+          name: Routes.resetPasswordName,
+          builder: (BuildContext context, GoRouterState state) {
+            return const Placeholder(child: Text('Reset Password Page'));
+          },
+        ),
+        GoRoute(
+          path: Routes.confirmEmail,
+          name: Routes.confirmEmailName,
+          builder: (BuildContext context, GoRouterState state) {
+            return const Placeholder(child: Text('Confirm Email Page'));
+          },
+        ),
+      ],
+    ),
+    GoRoute(
+      path: Routes.headlinesFeed,
+      name: Routes.headlinesFeedName,
+      builder: (BuildContext context, GoRouterState state) {
+        return const HeadlinesFeedPage();
+      },
+      routes: [
+        GoRoute(
+          path: 'article/:id',
+          name: Routes.articleDetailsName,
+          builder: (BuildContext context, GoRouterState state) {
+            final id = state.pathParameters['id']!;
+            return HeadlineDetailsPage(headlineId: id);
           },
-          routes: [
-            GoRoute(
-              path: 'article/:id',
-              name: Routes.articleDetailsName,
-              builder: (BuildContext context, GoRouterState state) {
-                final id = state.pathParameters['id']!;
-                return HeadlineDetailsPage(headlineId: id);
-              },
-            ),
-          ],
         ),
         GoRoute(
           path: Routes.search,
@@ -58,36 +80,6 @@ final appRouter = GoRouter(
             );
           },
         ),
-        GoRoute(
-          path: Routes.authentication,
-          name: Routes.authenticationName,
-          builder: (BuildContext context, GoRouterState state) {
-            return const AuthenticationPage();
-          },
-          routes: [
-            GoRoute(
-              path: Routes.forgotPassword,
-              name: Routes.forgotPasswordName,
-              builder: (BuildContext context, GoRouterState state) {
-                return const Placeholder(child: Text('Forgot Password Page'));
-              },
-            ),
-            GoRoute(
-              path: Routes.resetPassword,
-              name: Routes.resetPasswordName,
-              builder: (BuildContext context, GoRouterState state) {
-                return const Placeholder(child: Text('Reset Password Page'));
-              },
-            ),
-            GoRoute(
-              path: Routes.confirmEmail,
-              name: Routes.confirmEmailName,
-              builder: (BuildContext context, GoRouterState state) {
-                return const Placeholder(child: Text('Confirm Email Page'));
-              },
-            ),
-          ],
-        ),
       ],
     ),
   ],

lib/router/router.dart

@@ -262,14 +262,6 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.0"
-  flutter_adaptive_scaffold:
-    dependency: "direct main"
-    description:
-      name: flutter_adaptive_scaffold
-      sha256: "7279d74da2f2531a16d21c2ec327308778c3aedd672dfe4eaf3bf416463501f8"
-      url: "https://pub.dev"
-    source: hosted
-    version: "0.3.2"
   flutter_bloc:
     dependency: "direct main"
     description:

pubspec.lock

@@ -15,7 +15,6 @@ dependencies:
   flex_color_scheme: ^8.1.1
   flutter:
     sdk: flutter
-  flutter_adaptive_scaffold: ^0.3.2
   flutter_bloc: ^9.1.0
   flutter_localizations:
     sdk: flutter