Skip to content

Commit 63f38a3

Browse files
fullenifulleni
committed
style: misc
1 parent 8953168 commit 63f38a3

File tree

7 files changed

+29
-36
lines changed

7 files changed

+29
-36
lines changed

‎lib/account/view/saved_headlines_page.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class SavedHeadlinesPage extends StatelessWidget {
7272
return ListView.separated(
7373
padding: const EdgeInsets.symmetric(vertical: AppSpacing.paddingSmall), // Add padding
7474
itemCount: savedHeadlines.length,
75-
separatorBuilder: (context, index) => Divider(
75+
separatorBuilder: (context, index) => const Divider(
7676
height: 1,
7777
indent: AppSpacing.paddingMedium, // Indent divider
7878
endIndent: AppSpacing.paddingMedium,

‎lib/app/view/app.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ class _AppViewState extends State<_AppView> {
239239
final l10n = innerContext.l10n;
240240
return FailureStateWidget(
241241
message: l10n.unknownError, // "An unknown error occurred."
242-
retryButtonText: "Retry", // Hardcoded for now
242+
retryButtonText: 'Retry', // Hardcoded for now
243243
onRetry: () {
244244
// Use outer context for BLoC access
245245
context

‎lib/authentication/view/email_code_verification_page.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class EmailCodeVerificationPage extends StatelessWidget {
6868
l10n.emailCodeSentInstructions,
6969
style: textTheme.bodyLarge?.copyWith(
7070
color: colorScheme
71-
.onSurfaceVariant), // Softer color
71+
.onSurfaceVariant,), // Softer color
7272
textAlign: TextAlign.center,
7373
),
7474
const SizedBox(height: AppSpacing.xl), // Increased spacing

‎lib/entity_details/view/entity_details_page.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,11 @@ class _EntityDetailsViewState extends State<EntityDetailsView> {
114114
switch (type) {
115115
case EntityType.category:
116116
name = l10n.entityDetailsCategoryTitle; // Use direct l10n string
117-
break;
118117
case EntityType.source:
119118
name = l10n.entityDetailsSourceTitle; // Use direct l10n string
120-
break;
121119
// EntityType.country does not exist, remove or map if added later
122120
default:
123121
name = l10n.detailsPageTitle; // Fallback
124-
break;
125122
}
126123
// Manual capitalization
127124
return name.isNotEmpty ? '${name[0].toUpperCase()}${name.substring(1)}' : name;
@@ -400,7 +397,7 @@ class _EntityDetailsViewState extends State<EntityDetailsView> {
400397
),
401398
),
402399
),
403-
SliverToBoxAdapter(child: SizedBox(height: AppSpacing.xxl)),
400+
const SliverToBoxAdapter(child: SizedBox(height: AppSpacing.xxl)),
404401
],
405402
);
406403
},

‎lib/headline-details/view/headline_details_page.dart

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
174174
final textTheme = theme.textTheme;
175175
final colorScheme = theme.colorScheme;
176176

177-
final horizontalPadding = EdgeInsets.symmetric(
177+
const horizontalPadding = EdgeInsets.symmetric(
178178
horizontal: AppSpacing.paddingLarge,
179179
);
180180

@@ -295,14 +295,14 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
295295
fit: BoxFit.cover,
296296
loadingBuilder: (context, child, loadingProgress) {
297297
if (loadingProgress == null) return child;
298-
return Container(
298+
return ColoredBox(
299299
color: colorScheme.surfaceContainerHighest,
300300
child: const Center(
301301
child: CircularProgressIndicator(strokeWidth: 2),
302302
),
303303
);
304304
},
305-
errorBuilder: (context, error, stackTrace) => Container(
305+
errorBuilder: (context, error, stackTrace) => ColoredBox(
306306
color: colorScheme.surfaceContainerHighest,
307307
child: Icon(
308308
Icons.broken_image_outlined,
@@ -386,9 +386,9 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
386386
),
387387
),
388388
if (headline.url == null || headline.url!.isEmpty) // Ensure bottom padding
389-
SliverPadding(
389+
const SliverPadding(
390390
padding: EdgeInsets.only(bottom: AppSpacing.xl),
391-
sliver: const SliverToBoxAdapter(child: SizedBox.shrink()),
391+
sliver: SliverToBoxAdapter(child: SizedBox.shrink()),
392392
),
393393
SliverPadding(
394394
padding: horizontalPadding,
@@ -421,7 +421,7 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
421421
final chipBackgroundColor = colorScheme.secondaryContainer;
422422
final chipAvatarColor = colorScheme.onSecondaryContainer;
423423
const chipAvatarSize = AppSpacing.md;
424-
final chipPadding = EdgeInsets.symmetric(
424+
const chipPadding = EdgeInsets.symmetric(
425425
horizontal: AppSpacing.sm,
426426
vertical: AppSpacing.xs,
427427
);
@@ -512,7 +512,7 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
512512
}
513513

514514
Widget _buildSimilarHeadlinesSection(
515-
BuildContext context, EdgeInsets hPadding) {
515+
BuildContext context, EdgeInsets hPadding,) {
516516
final l10n = context.l10n;
517517
final theme = Theme.of(context);
518518
final textTheme = theme.textTheme;
@@ -522,16 +522,16 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
522522
builder: (context, state) {
523523
return switch (state) {
524524
SimilarHeadlinesInitial() ||
525-
SimilarHeadlinesLoading() => SliverToBoxAdapter(
525+
SimilarHeadlinesLoading() => const SliverToBoxAdapter(
526526
child: Padding(
527527
padding: EdgeInsets.symmetric(vertical: AppSpacing.xl),
528-
child: const Center(child: CircularProgressIndicator()),
528+
child: Center(child: CircularProgressIndicator()),
529529
),
530530
),
531531
final SimilarHeadlinesError errorState => SliverToBoxAdapter(
532532
child: Padding(
533533
padding: hPadding.copyWith(
534-
top: AppSpacing.md, bottom: AppSpacing.xl),
534+
top: AppSpacing.md, bottom: AppSpacing.xl,),
535535
child: Text(
536536
errorState.message,
537537
textAlign: TextAlign.center,
@@ -543,7 +543,7 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
543543
SimilarHeadlinesEmpty() => SliverToBoxAdapter(
544544
child: Padding(
545545
padding: hPadding.copyWith(
546-
top: AppSpacing.md, bottom: AppSpacing.xl),
546+
top: AppSpacing.md, bottom: AppSpacing.xl,),
547547
child: Text(
548548
l10n.similarHeadlinesEmpty,
549549
textAlign: TextAlign.center,

‎lib/headlines-feed/view/headlines_filter_page.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ import 'package:ht_main/shared/constants/constants.dart';
1414
import 'package:ht_shared/ht_shared.dart'
1515
show
1616
Category,
17+
HtHttpException,
18+
NotFoundException,
1719
Source,
1820
SourceType,
19-
UserContentPreferences,
20-
User,
21-
HtHttpException, // Added
22-
NotFoundException; // Added
21+
User, // Added
22+
UserContentPreferences; // Added
2323

2424
// Keys for passing data to/from SourceFilterPage
2525
const String keySelectedSources = 'selectedSources';
@@ -64,7 +64,7 @@ class _HeadlinesFilterPageState extends State<HeadlinesFilterPage> {
6464
final headlinesFeedState =
6565
BlocProvider.of<HeadlinesFeedBloc>(context).state;
6666

67-
bool initialUseFollowedFilters = false;
67+
var initialUseFollowedFilters = false;
6868

6969
if (headlinesFeedState is HeadlinesFeedLoaded) {
7070
final currentFilter = headlinesFeedState.filter;
@@ -111,7 +111,7 @@ class _HeadlinesFilterPageState extends State<HeadlinesFilterPage> {
111111
});
112112

113113
final appState = context.read<AppBloc>().state;
114-
final User? currentUser = appState.user;
114+
final currentUser = appState.user;
115115

116116
if (currentUser == null) {
117117
setState(() {

‎lib/headlines-search/view/headlines_search_page.dart

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
128128
width: 150, // Adjusted width for potentially longer translations
129129
child: DropdownButtonFormField<SearchModelType>(
130130
value: _selectedModelType,
131-
decoration: InputDecoration(
131+
decoration: const InputDecoration(
132132
border: InputBorder.none, // Clean look
133133
contentPadding: EdgeInsets.symmetric(
134134
horizontal: AppSpacing.sm, // Adjusted padding
@@ -202,11 +202,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
202202
color: appBarTheme.iconTheme?.color ??
203203
colorScheme.onSurfaceVariant,
204204
),
205-
onPressed: () {
206-
_textController.clear();
207-
// Optionally clear search results when text is cleared
208-
// context.read<HeadlinesSearchBloc>().add(HeadlinesSearchTermCleared());
209-
},
205+
onPressed: _textController.clear,
210206
)
211207
: null,
212208
),
@@ -222,7 +218,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
222218
onPressed: _performSearch,
223219
// color: appBarTheme.actionsIconTheme?.color, // Use theme
224220
),
225-
const SizedBox(width: AppSpacing.xs) // Add a bit of padding
221+
const SizedBox(width: AppSpacing.xs), // Add a bit of padding
226222
],
227223
),
228224
body: BlocBuilder<HeadlinesSearchBloc, HeadlinesSearchState>(
@@ -279,7 +275,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
279275
if (index >= items.length) {
280276
return const Padding(
281277
padding: EdgeInsets.symmetric(
282-
vertical: AppSpacing.lg),
278+
vertical: AppSpacing.lg,),
283279
child:
284280
Center(child: CircularProgressIndicator()),
285281
);
@@ -331,7 +327,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
331327
} else if (feedItem is Ad) {
332328
return Card(
333329
margin: const EdgeInsets.symmetric(
334-
vertical: AppSpacing.xs),
330+
vertical: AppSpacing.xs,),
335331
color: currentColorScheme.surfaceContainerHighest,
336332
child: Padding(
337333
padding: const EdgeInsets.all(AppSpacing.md),
@@ -368,7 +364,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
368364
} else if (feedItem is AccountAction) {
369365
return Card(
370366
margin: const EdgeInsets.symmetric(
371-
vertical: AppSpacing.xs),
367+
vertical: AppSpacing.xs,),
372368
color: currentColorScheme.secondaryContainer,
373369
child: ListTile(
374370
leading: Icon(
@@ -415,7 +411,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
415411
if (feedItem.callToActionUrl !=
416412
null) {
417413
context.push(
418-
feedItem.callToActionUrl!);
414+
feedItem.callToActionUrl!,);
419415
}
420416
},
421417
child:
@@ -444,7 +440,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
444440
'Failed to search "$lastSearchTerm" in ${failedModelType.displayName.toLowerCase()}:\n$errorMessage', // Improved message
445441
onRetry: () => context.read<HeadlinesSearchBloc>().add(
446442
HeadlinesSearchFetchRequested(
447-
searchTerm: lastSearchTerm),
443+
searchTerm: lastSearchTerm,),
448444
),
449445
),
450446
_ => const SizedBox.shrink(), // Fallback for any other state

0 commit comments

Comments
 (0)