Skip to content

Commit 6f7338e

Browse files
committed
style: misc
1 parent 9fe3eb4 commit 6f7338e

File tree

7 files changed

+49
-29
lines changed

7 files changed

+49
-29
lines changed

lib/headlines-feed/bloc/sources_filter_bloc.dart

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,11 @@ class SourcesFilterBloc extends Bloc<SourcesFilterEvent, SourcesFilterState> {
6161
state.copyWith(
6262
availableCountries: availableCountries.items,
6363
allAvailableSources: allAvailableSources,
64-
displayableSources: displayableSources, // Now correctly filtered if initial capsules were set
64+
displayableSources:
65+
displayableSources, // Now correctly filtered if initial capsules were set
6566
finallySelectedSourceIds: initialSelectedSourceIds,
66-
selectedCountryIsoCodes: initialSelectedCountryIsoCodes, // Use event's data
67+
selectedCountryIsoCodes:
68+
initialSelectedCountryIsoCodes, // Use event's data
6769
selectedSourceTypes: initialSelectedSourceTypes, // Use event's data
6870
dataLoadingStatus: SourceFilterDataLoadingStatus.success,
6971
clearErrorMessage: true,
@@ -191,10 +193,12 @@ class SourcesFilterBloc extends Bloc<SourcesFilterEvent, SourcesFilterState> {
191193
}
192194

193195
return allSources.where((source) {
194-
final matchesCountry = selectedCountries.isEmpty ||
196+
final matchesCountry =
197+
selectedCountries.isEmpty ||
195198
(source.headquarters != null &&
196199
selectedCountries.contains(source.headquarters!.isoCode));
197-
final matchesType = selectedTypes.isEmpty ||
200+
final matchesType =
201+
selectedTypes.isEmpty ||
198202
(source.sourceType != null &&
199203
selectedTypes.contains(source.sourceType!));
200204
return matchesCountry && matchesType;

lib/headlines-feed/bloc/sources_filter_event.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ class LoadSourceFilterData extends SourcesFilterEvent {
2222

2323
@override
2424
List<Object?> get props => [
25-
initialSelectedSources,
26-
initialSelectedCountryIsoCodes,
27-
initialSelectedSourceTypes,
28-
];
25+
initialSelectedSources,
26+
initialSelectedCountryIsoCodes,
27+
initialSelectedSourceTypes,
28+
];
2929
}
3030

3131
class CountryCapsuleToggled extends SourcesFilterEvent {

lib/headlines-feed/bloc/sources_filter_state.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ class SourcesFilterState extends Equatable {
4545
selectedCountryIsoCodes ?? this.selectedCountryIsoCodes,
4646
availableSourceTypes: availableSourceTypes ?? this.availableSourceTypes,
4747
selectedSourceTypes: selectedSourceTypes ?? this.selectedSourceTypes,
48-
allAvailableSources: allAvailableSources ?? this.allAvailableSources, // Added
48+
allAvailableSources:
49+
allAvailableSources ?? this.allAvailableSources, // Added
4950
displayableSources: displayableSources ?? this.displayableSources,
5051
finallySelectedSourceIds:
5152
finallySelectedSourceIds ?? this.finallySelectedSourceIds,

lib/headlines-feed/models/headline_filter.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ class HeadlineFilter extends Equatable {
2929

3030
@override
3131
List<Object?> get props => [
32-
categories,
33-
sources,
34-
selectedSourceCountryIsoCodes,
35-
selectedSourceSourceTypes,
36-
];
32+
categories,
33+
sources,
34+
selectedSourceCountryIsoCodes,
35+
selectedSourceSourceTypes,
36+
];
3737

3838
/// Creates a copy of this [HeadlineFilter] with the given fields
3939
/// replaced with the new values.
@@ -46,8 +46,8 @@ class HeadlineFilter extends Equatable {
4646
return HeadlineFilter(
4747
categories: categories ?? this.categories,
4848
sources: sources ?? this.sources,
49-
selectedSourceCountryIsoCodes: selectedSourceCountryIsoCodes ??
50-
this.selectedSourceCountryIsoCodes,
49+
selectedSourceCountryIsoCodes:
50+
selectedSourceCountryIsoCodes ?? this.selectedSourceCountryIsoCodes,
5151
selectedSourceSourceTypes:
5252
selectedSourceSourceTypes ?? this.selectedSourceSourceTypes,
5353
);

lib/headlines-feed/view/headlines_filter_page.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ import 'package:ht_main/headlines-feed/models/headline_filter.dart';
99
import 'package:ht_main/l10n/l10n.dart';
1010
import 'package:ht_main/router/routes.dart';
1111
import 'package:ht_main/shared/constants/constants.dart';
12-
import 'package:ht_shared/ht_shared.dart'
13-
show Category, Source, SourceType;
12+
import 'package:ht_shared/ht_shared.dart' show Category, Source, SourceType;
1413

1514
// Keys for passing data to/from SourceFilterPage
1615
const String keySelectedSources = 'selectedSources';
@@ -56,10 +55,12 @@ class _HeadlinesFilterPageState extends State<HeadlinesFilterPage> {
5655
_tempSelectedCategories = List.from(currentState.filter.categories ?? []);
5756
_tempSelectedSources = List.from(currentState.filter.sources ?? []);
5857
// Initialize source capsule states from the BLoC's current filter
59-
_tempSelectedSourceCountryIsoCodes =
60-
Set.from(currentState.filter.selectedSourceCountryIsoCodes ?? {});
61-
_tempSelectedSourceSourceTypes =
62-
Set.from(currentState.filter.selectedSourceSourceTypes ?? {});
58+
_tempSelectedSourceCountryIsoCodes = Set.from(
59+
currentState.filter.selectedSourceCountryIsoCodes ?? {},
60+
);
61+
_tempSelectedSourceSourceTypes = Set.from(
62+
currentState.filter.selectedSourceSourceTypes ?? {},
63+
);
6364
} else {
6465
_tempSelectedCategories = [];
6566
_tempSelectedSources = [];

lib/headlines-feed/view/source_filter_page.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ class _SourceFilterView extends StatelessWidget {
118118
// Or, we could try to persist/retrieve the last known good capsule state.
119119
// For now, simple retry reloads all.
120120
const LoadSourceFilterData(
121-
initialSelectedSources: [], // Or pass current selections if needed
121+
initialSelectedSources:
122+
[], // Or pass current selections if needed
122123
initialSelectedCountryIsoCodes: {},
123124
initialSelectedSourceTypes: {},
124125
),

lib/router/router.dart

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -403,15 +403,28 @@ GoRouter createRouter({
403403
// Pass initialSelectedSources, country ISO codes, and source types from state.extra
404404
child: Builder(
405405
builder: (context) {
406-
final extraData = state.extra as Map<String, dynamic>? ?? const {};
407-
final initialSources = extraData[keySelectedSources] as List<Source>? ?? const [];
408-
final initialCountryIsoCodes = extraData[keySelectedCountryIsoCodes] as Set<String>? ?? const {};
409-
final initialSourceTypes = extraData[keySelectedSourceTypes] as Set<SourceType>? ?? const {};
406+
final extraData =
407+
state.extra as Map<String, dynamic>? ??
408+
const {};
409+
final initialSources =
410+
extraData[keySelectedSources]
411+
as List<Source>? ??
412+
const [];
413+
final initialCountryIsoCodes =
414+
extraData[keySelectedCountryIsoCodes]
415+
as Set<String>? ??
416+
const {};
417+
final initialSourceTypes =
418+
extraData[keySelectedSourceTypes]
419+
as Set<SourceType>? ??
420+
const {};
410421

411422
return SourceFilterPage(
412423
initialSelectedSources: initialSources,
413-
initialSelectedCountryIsoCodes: initialCountryIsoCodes,
414-
initialSelectedSourceTypes: initialSourceTypes,
424+
initialSelectedCountryIsoCodes:
425+
initialCountryIsoCodes,
426+
initialSelectedSourceTypes:
427+
initialSourceTypes,
415428
);
416429
},
417430
),

0 commit comments

Comments
 (0)