Skip to content

Commit 7c2f5dc

Browse files
committed
refactor(feed): use constant for headlines limit
- Defined limit as constant - Replaced inline value with constant
1 parent bc56561 commit 7c2f5dc

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

lib/headlines-feed/bloc/headlines_feed_bloc.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:bloc/bloc.dart';
22
import 'package:bloc_concurrency/bloc_concurrency.dart';
33
import 'package:equatable/equatable.dart';
4+
45
import 'package:ht_headlines_repository/ht_headlines_repository.dart';
56
import 'package:ht_main/headlines-feed/models/headline_filter.dart';
67

@@ -33,14 +34,16 @@ class HeadlinesFeedBloc extends Bloc<HeadlinesFeedEvent, HeadlinesFeedState> {
3334

3435
final HtHeadlinesRepository _headlinesRepository;
3536

37+
static const _headlinesFetchLimit = 20;
38+
3639
Future<void> _onHeadlinesFeedFilterChanged(
3740
HeadlinesFeedFilterChanged event,
3841
Emitter<HeadlinesFeedState> emit,
3942
) async {
4043
emit(HeadlinesFeedLoading());
4144
try {
4245
final response = await _headlinesRepository.getHeadlines(
43-
limit: 20,
46+
limit: _headlinesFetchLimit,
4447
category: event.category, // Pass category directly
4548
source: event.source, // Pass source directly
4649
eventCountry: event.eventCountry, // Pass eventCountry directly
@@ -86,7 +89,7 @@ class HeadlinesFeedBloc extends Bloc<HeadlinesFeedEvent, HeadlinesFeedState> {
8689
emit(HeadlinesFeedLoading());
8790
try {
8891
final response = await _headlinesRepository.getHeadlines(
89-
limit: 20,
92+
limit: _headlinesFetchLimit,
9093
startAfterId: currentState.cursor,
9194
category: currentState.filter.category, // Use existing filter
9295
source: currentState.filter.source, // Use existing filter
@@ -109,7 +112,7 @@ class HeadlinesFeedBloc extends Bloc<HeadlinesFeedEvent, HeadlinesFeedState> {
109112
emit(HeadlinesFeedLoading());
110113
try {
111114
final response = await _headlinesRepository.getHeadlines(
112-
limit: 20,
115+
limit: _headlinesFetchLimit,
113116
category: state is HeadlinesFeedLoaded
114117
? (state as HeadlinesFeedLoaded).filter.category
115118
: null,

0 commit comments

Comments
 (0)