Skip to content

Commit 934e501

Browse files
committed
refactor(headlines-feed): remove clear all filters functionality
- Remove ClearSourceFiltersRequested event from sources_filter_event.dart - Remove _onClearSourceFiltersRequested handler from sources_filter_bloc.dart - Remove reset filters button from source_filter_page.dart
1 parent 61d5e42 commit 934e501

File tree

3 files changed

+1
-30
lines changed

3 files changed

+1
-30
lines changed

lib/headlines-feed/bloc/sources_filter_bloc.dart

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class SourcesFilterBloc extends Bloc<SourcesFilterEvent, SourcesFilterState> {
2626
on<AllSourceTypesCapsuleToggled>(_onAllSourceTypesCapsuleToggled);
2727
on<SourceTypeCapsuleToggled>(_onSourceTypeCapsuleToggled);
2828
on<SourceCheckboxToggled>(_onSourceCheckboxToggled);
29-
on<ClearSourceFiltersRequested>(_onClearSourceFiltersRequested);
3029
on<SourcesFilterApplyFollowedRequested>(
3130
_onSourcesFilterApplyFollowedRequested,
3231
);
@@ -177,22 +176,6 @@ class SourcesFilterBloc extends Bloc<SourcesFilterEvent, SourcesFilterState> {
177176
emit(state.copyWith(finallySelectedSourceIds: currentSelected));
178177
}
179178

180-
Future<void> _onClearSourceFiltersRequested(
181-
ClearSourceFiltersRequested event,
182-
Emitter<SourcesFilterState> emit,
183-
) async {
184-
emit(
185-
state.copyWith(
186-
selectedCountryIsoCodes: {},
187-
selectedSourceTypes: {},
188-
finallySelectedSourceIds: {},
189-
displayableSources: List.from(state.allAvailableSources),
190-
dataLoadingStatus: SourceFilterDataLoadingStatus.success,
191-
clearErrorMessage: true,
192-
),
193-
);
194-
}
195-
196179
/// Handles the request to apply the user's followed sources as filters.
197180
Future<void> _onSourcesFilterApplyFollowedRequested(
198181
SourcesFilterApplyFollowedRequested event,

lib/headlines-feed/bloc/sources_filter_event.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ class SourceCheckboxToggled extends SourcesFilterEvent {
6262
List<Object> get props => [sourceId, isSelected];
6363
}
6464

65-
class ClearSourceFiltersRequested extends SourcesFilterEvent {
66-
const ClearSourceFiltersRequested();
67-
}
68-
6965
/// {@template sources_filter_apply_followed_requested}
7066
/// Event triggered to request applying the user's followed sources as filters.
7167
/// {@endtemplate}

lib/headlines-feed/view/source_filter_page.dart

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,7 @@ class _SourceFilterView extends StatelessWidget {
9898
);
9999
},
100100
),
101-
IconButton(
102-
icon: const Icon(Icons.clear_all_outlined),
103-
tooltip: l10n.headlinesFeedFilterResetButton,
104-
onPressed: () {
105-
context.read<SourcesFilterBloc>().add(
106-
const ClearSourceFiltersRequested(),
107-
);
108-
},
109-
),
101+
110102
IconButton(
111103
icon: const Icon(Icons.check),
112104
tooltip: l10n.headlinesFeedFilterApplyButton,

0 commit comments

Comments
 (0)