Skip to content

Commit ae92453

Browse files
committed
fix(feed): fix filter reset and type
- Fixed filter reset logic - Changed bool to var - Removed unnecessary params
1 parent 9a9d90d commit ae92453

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

lib/headlines-feed/view/headlines_feed_page.dart

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class _HeadlinesFeedViewState extends State<_HeadlinesFeedView> {
7171
actions: [
7272
BlocBuilder<HeadlinesFeedBloc, HeadlinesFeedState>(
7373
builder: (context, state) {
74-
bool isFilterApplied = false;
74+
var isFilterApplied = false;
7575
if (state is HeadlinesFeedLoaded) {
7676
isFilterApplied = state.filter.category != null ||
7777
state.filter.source != null ||
@@ -204,10 +204,13 @@ class _HeadlinesFilterBottomSheetState
204204
value: selectedCategory,
205205
items: const [
206206
// Placeholder items
207-
const DropdownMenuItem<String>(
208-
value: null, child: Text('All')),
207+
DropdownMenuItem<String>(
208+
child: Text('All'),
209+
),
209210
DropdownMenuItem(
210-
value: 'technology', child: Text('Technology')),
211+
value: 'technology',
212+
child: Text('Technology'),
213+
),
211214
DropdownMenuItem(value: 'business', child: Text('Business')),
212215
DropdownMenuItem(value: 'Politics', child: Text('Sports')),
213216
],
@@ -224,8 +227,9 @@ class _HeadlinesFilterBottomSheetState
224227
value: selectedSource,
225228
items: const [
226229
// Placeholder items
227-
const DropdownMenuItem<String>(
228-
value: null, child: Text('All')),
230+
DropdownMenuItem<String>(
231+
child: Text('All'),
232+
),
229233
DropdownMenuItem(value: 'cnn', child: Text('CNN')),
230234
DropdownMenuItem(value: 'reuters', child: Text('Reuters')),
231235
],
@@ -242,8 +246,9 @@ class _HeadlinesFilterBottomSheetState
242246
value: selectedEventCountry,
243247
items: const [
244248
// Placeholder items
245-
const DropdownMenuItem<String>(
246-
value: null, child: Text('All')),
249+
DropdownMenuItem<String>(
250+
child: Text('All'),
251+
),
247252
DropdownMenuItem(value: 'US', child: Text('United States')),
248253
DropdownMenuItem(value: 'UK', child: Text('United Kingdom')),
249254
DropdownMenuItem(value: 'CA', child: Text('Canada')),
@@ -280,11 +285,7 @@ class _HeadlinesFilterBottomSheetState
280285
selectedEventCountry = null;
281286
});
282287
widget.bloc.add(
283-
const HeadlinesFeedFilterChanged(
284-
category: null,
285-
source: null,
286-
eventCountry: null,
287-
),
288+
const HeadlinesFeedFilterChanged(),
288289
);
289290
Navigator.pop(context);
290291
},

0 commit comments

Comments
 (0)