Skip to content

Commit c0df42a

Browse files
committed
refactor: moved notifications feed entry point from the account to the feed page
1 parent 61db172 commit c0df42a

File tree

4 files changed

+18
-17
lines changed

4 files changed

+18
-17
lines changed

lib/account/view/account_page.dart

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ class _AccountView extends StatelessWidget {
6161
const SizedBox(height: 24),
6262

6363
// --- Action Tiles ---
64-
_buildNotificationsTile(context),
65-
const Divider(),
6664
_buildSettingsTile(context),
6765
const Divider(),
6866
if (isAnonymous)
@@ -171,20 +169,6 @@ class _AccountView extends StatelessWidget {
171169
);
172170
}
173171

174-
/// Builds the ListTile for navigating to Notifications.
175-
Widget _buildNotificationsTile(BuildContext context) {
176-
final l10n = context.l10n;
177-
return ListTile(
178-
leading: const Icon(Icons.notifications_outlined),
179-
title: Text(l10n.accountNotificationsTile),
180-
trailing: const Icon(Icons.chevron_right), // Suggests navigation
181-
onTap: () {
182-
// Navigate to the new notifications route (placeholder)
183-
context.goNamed(Routes.notificationsName);
184-
},
185-
);
186-
}
187-
188172
/// Helper to convert AuthenticationStatus enum to a display string.
189173
String _authenticationStatusToString(
190174
BuildContext context,

lib/headlines-feed/view/headlines_feed_page.dart

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import 'package:flutter/material.dart';
22
import 'package:flutter_bloc/flutter_bloc.dart';
3+
import 'package:go_router/go_router.dart';
34
import 'package:ht_headlines_repository/ht_headlines_repository.dart';
45
import 'package:ht_main/headlines-feed/bloc/headlines_feed_bloc.dart';
56
import 'package:ht_main/headlines-feed/widgets/headline_item_widget.dart';
67
import 'package:ht_main/l10n/l10n.dart';
8+
import 'package:ht_main/router/routes.dart';
79
import 'package:ht_main/shared/constants/constants.dart';
810
import 'package:ht_main/shared/widgets/failure_state_widget.dart';
911
import 'package:ht_main/shared/widgets/loading_state_widget.dart';
@@ -73,7 +75,14 @@ class _HeadlinesFeedViewState extends State<_HeadlinesFeedView> {
7375

7476
return Scaffold(
7577
appBar: AppBar(
76-
// Removed leadingWidth and leading Row
78+
centerTitle: true, // Center the title
79+
leading: IconButton( // Add leading icon button
80+
icon: const Icon(Icons.notifications_outlined),
81+
tooltip: l10n.notificationsTooltip, // Add tooltip for accessibility
82+
onPressed: () {
83+
context.goNamed(Routes.notificationsName);
84+
},
85+
),
7786
title: Text(
7887
'HT', // TODO(fulleni): Localize this title
7988
style: textTheme.titleLarge?.copyWith(fontWeight: FontWeight.bold),

lib/l10n/arb/app_ar.arb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,5 +279,9 @@
279279
"headlinesSearchActionTooltip": "بحث",
280280
"@headlinesSearchActionTooltip": {
281281
"description": "Tooltip text for the search icon button in the search page AppBar"
282+
},
283+
"notificationsTooltip": "عرض الإشعارات",
284+
"@notificationsTooltip": {
285+
"description": "Tooltip text for the notifications icon button in the feed page AppBar"
282286
}
283287
}

lib/l10n/arb/app_en.arb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,5 +279,9 @@
279279
"headlinesSearchActionTooltip": "Search",
280280
"@headlinesSearchActionTooltip": {
281281
"description": "Tooltip text for the search icon button in the search page AppBar"
282+
},
283+
"notificationsTooltip": "View notifications",
284+
"@notificationsTooltip": {
285+
"description": "Tooltip text for the notifications icon button in the feed page AppBar"
282286
}
283287
}

0 commit comments

Comments
 (0)