style: misc

Author: fulleni

analysis_options.yaml

@@ -3,6 +3,7 @@ analyzer:
     avoid_catches_without_on_clauses: ignore
     avoid_print: ignore
     document_ignores: ignore
+    flutter_style_todos: ignore
     lines_longer_than_80_chars: ignore
     use_if_null_to_convert_nulls_to_bools: ignore
 include: package:very_good_analysis/analysis_options.7.0.0.yaml

lib/account/view/content_preferences_page.dart

@@ -234,7 +234,8 @@ class ContentPreferencesPage extends StatelessWidget {
           ElevatedButton.icon(
             icon: const Icon(Icons.add_circle_outline),
             label: Text(l10n.headlinesFeedFilterEventCountryLabel), // "Country"
-            onPressed: null, // TODO: Implement new navigation/management for followed countries
+            onPressed:
+                null, // TODO: Implement new navigation/management for followed countries
           ),
         ],
       );

lib/headlines-feed/bloc/sources_filter_bloc.dart

@@ -9,14 +9,13 @@ import 'package:ht_shared/ht_shared.dart'
 part 'sources_filter_event.dart';
 part 'sources_filter_state.dart';
 
-class SourcesFilterBloc
-    extends Bloc<SourcesFilterEvent, SourcesFilterState> {
+class SourcesFilterBloc extends Bloc<SourcesFilterEvent, SourcesFilterState> {
   SourcesFilterBloc({
     required HtDataRepository<Source> sourcesRepository,
     required HtDataRepository<Country> countriesRepository,
-  })  : _sourcesRepository = sourcesRepository,
-        _countriesRepository = countriesRepository,
-        super(const SourcesFilterState()) {
+  }) : _sourcesRepository = sourcesRepository,
+       _countriesRepository = countriesRepository,
+       super(const SourcesFilterState()) {
     on<LoadSourceFilterData>(_onLoadSourceFilterData);
     on<CountryCapsuleToggled>(_onCountryCapsuleToggled);
     on<AllSourceTypesCapsuleToggled>(_onAllSourceTypesCapsuleToggled); // Added
@@ -34,18 +33,16 @@ class SourcesFilterBloc
     Emitter<SourcesFilterState> emit,
   ) async {
     emit(
-      state.copyWith(
-        dataLoadingStatus: SourceFilterDataLoadingStatus.loading,
-      ),
+      state.copyWith(dataLoadingStatus: SourceFilterDataLoadingStatus.loading),
     );
     try {
       final availableCountries = await _countriesRepository.readAll();
       final initialSelectedSourceIds =
           event.initialSelectedSources.map((s) => s.id).toSet();
-      
+
       // Initialize selected capsules based on initialSelectedSources
-      final Set<String> initialSelectedCountryIsoCodes = {};
-      final Set<SourceType> initialSelectedSourceTypes = {};
+      final initialSelectedCountryIsoCodes = <String>{};
+      final initialSelectedSourceTypes = <SourceType>{};
 
       if (event.initialSelectedSources.isNotEmpty) {
         for (final source in event.initialSelectedSources) {
@@ -84,7 +81,8 @@ class SourcesFilterBloc
     Emitter<SourcesFilterState> emit,
   ) async {
     final currentSelected = Set<String>.from(state.selectedCountryIsoCodes);
-    if (event.countryIsoCode.isEmpty) { // "All Countries" toggled
+    if (event.countryIsoCode.isEmpty) {
+      // "All Countries" toggled
       // If "All" is tapped and it's already effectively "All" (empty set), or if it's tapped to select "All"
       // we clear the set. If specific items are selected and "All" is tapped, it also clears.
       // Essentially, tapping "All" always results in an empty set, meaning no country filter.
@@ -163,23 +161,21 @@ class SourcesFilterBloc
       state.copyWith(
         dataLoadingStatus: SourceFilterDataLoadingStatus.loading,
         displayableSources: [], // Clear previous sources
-        errorMessage: null,
         clearErrorMessage: true,
       ),
     );
     try {
       final queryParameters = <String, dynamic>{};
       if (state.selectedCountryIsoCodes.isNotEmpty) {
-        queryParameters['countries'] =
-            state.selectedCountryIsoCodes.join(',');
+        queryParameters['countries'] = state.selectedCountryIsoCodes.join(',');
       }
       if (state.selectedSourceTypes.isNotEmpty) {
-        queryParameters['sourceTypes'] =
-            state.selectedSourceTypes.map((st) => st.name).join(',');
+        queryParameters['sourceTypes'] = state.selectedSourceTypes
+            .map((st) => st.name)
+            .join(',');
       }
 
-      final response =
-          await _sourcesRepository.readAllByQuery(queryParameters);
+      final response = await _sourcesRepository.readAllByQuery(queryParameters);
       emit(
         state.copyWith(
           displayableSources: response.items,

lib/headlines-feed/bloc/sources_filter_event.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_positional_boolean_parameters
+
 part of 'sources_filter_bloc.dart';
 
 abstract class SourcesFilterEvent extends Equatable {

lib/headlines-feed/bloc/sources_filter_state.dart

@@ -53,13 +53,13 @@ class SourcesFilterState extends Equatable {
 
   @override
   List<Object?> get props => [
-        availableCountries,
-        selectedCountryIsoCodes,
-        availableSourceTypes,
-        selectedSourceTypes,
-        displayableSources,
-        finallySelectedSourceIds,
-        dataLoadingStatus,
-        errorMessage,
-      ];
+    availableCountries,
+    selectedCountryIsoCodes,
+    availableSourceTypes,
+    selectedSourceTypes,
+    displayableSources,
+    finallySelectedSourceIds,
+    dataLoadingStatus,
+    errorMessage,
+  ];
 }

lib/headlines-feed/models/headline_filter.dart

@@ -21,10 +21,7 @@ class HeadlineFilter extends Equatable {
 
   /// Creates a copy of this [HeadlineFilter] with the given fields
   /// replaced with the new values.
-  HeadlineFilter copyWith({
-    List<Category>? categories,
-    List<Source>? sources,
-  }) {
+  HeadlineFilter copyWith({List<Category>? categories, List<Source>? sources}) {
     return HeadlineFilter(
       categories: categories ?? this.categories,
       sources: sources ?? this.sources,

lib/headlines-feed/view/headlines_feed_page.dart

@@ -10,10 +10,7 @@ import 'package:ht_main/headlines-feed/bloc/headlines_feed_bloc.dart';
 import 'package:ht_main/headlines-feed/widgets/headline_item_widget.dart';
 import 'package:ht_main/l10n/l10n.dart';
 import 'package:ht_main/router/routes.dart';
-import 'package:ht_main/shared/constants/constants.dart';
 import 'package:ht_main/shared/shared.dart';
-import 'package:ht_main/shared/widgets/failure_state_widget.dart';
-import 'package:ht_main/shared/widgets/loading_state_widget.dart';
 // Import Source
 
 /// {@template headlines_feed_view}
@@ -171,13 +168,16 @@ class _HeadlinesFeedPageState extends State<HeadlinesFeedPage> {
                 // If the list is empty after filters, show a message
                 // with a "Clear Filters" button using FailureStateWidget.
                 return FailureStateWidget(
-                  message: '${l10n.headlinesFeedEmptyFilteredHeadline}\n${l10n.headlinesFeedEmptyFilteredSubheadline}',
-                  onRetry: () { // This will be our "Clear Filters" action
+                  message:
+                      '${l10n.headlinesFeedEmptyFilteredHeadline}\n${l10n.headlinesFeedEmptyFilteredSubheadline}',
+                  onRetry: () {
+                    // This will be our "Clear Filters" action
                     context.read<HeadlinesFeedBloc>().add(
                       HeadlinesFeedFiltersCleared(),
                     );
                   },
-                  retryButtonText: l10n.headlinesFeedClearFiltersButton, // New l10n string
+                  retryButtonText:
+                      l10n.headlinesFeedClearFiltersButton, // New l10n string
                 );
               }
               // Display the list of headlines with pull-to-refresh