Skip to content

Eadlines feed source filter UI fix #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 30, 2025
Merged

Conversation

fulleni
Copy link
Member

@fulleni fulleni commented May 30, 2025

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

fulleni added 15 commits May 30, 2025 02:05
- Added allAvailableSources property
- Holds all available sources data
- Persist country ISO codes
- Persist source types
- Remove _FetchFilteredSourcesRequested
- Filter in bloc using helper method
- Use initial capsule selections
- Pass data via state.extra
- Simplify SourceFilterPage init
- Pass map to source filter
- Handle map result from source filter
- Pass and return full filter state
- Retry reloads all sources/countries
- Clear filter on refresh event
- Added country ISO code filtering
- Added source type filtering
- Updated HeadlineFilter model
- Initialize source filters from BLoC state
- Pass filter states to HeadlinesFeedBloc
…ple selected category IDs and source IDs as comma-separated strings when making API requests. This aligns with the backend's expectation and should resolve the bug where new filter selections were overriding previous ones instead of being combined. Filtering by multiple categories and/or multiple sources simultaneously should now work as intended.
- Removed explicit type declarations
- Removed unused parameter
- Added top padding to column
@fulleni fulleni merged commit f6942ff into main May 30, 2025
0 of 2 checks passed
@fulleni fulleni deleted the eadlines_feed_source_filter_ui_fix branch May 30, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant