Enhance splash screen #68
Conversation
- Move splash_remover_stub.dart, splash_remover_web.dart, and web_splash.dart into a new splash_screen_remover directory - Rename web_splash.dart to web_splash_remover.dart for consistency - Update import statement in main.dart to reflect the new file structure
- Add splash.css for better styling of the splash screen - Update splash screen HTML structure and CSS - Change app environment to demo in main.dart - Reorder imports in main.dart
- Update launcher icon for Android - Update favicon and web app icons - Change icon source path in flutter_launcher_icons.yaml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on enhancing the web splash screen experience by refactoring its underlying structure and styling. I've introduced a new CSS file for improved visual presentation, including a new loading spinner, and updated the associated HTML and Dart code to support these changes. Additionally, I've made minor adjustments to the launcher icon configuration and the default application environment.
Highlights
- Web Splash Screen Refactor and Enhancement: I've refactored the web splash screen implementation by introducing a new dedicated CSS file (
web/splash/splash.css) for styling and reorganizing the HTML structure inweb/index.html. This includes wrapping the splash image and loading indicator within a newsplash-containerand updating the JavaScript functionremoveSplashFromWebto target this new container for removal. A new spinning loader animation has also been added to the splash screen. - Launcher Icon Configuration Update: The
flutter_launcher_icons.yamlconfiguration has been updated to use a newlogo.pngfor the default image path, replacingheadlines_toolkit.png. Additionally, iOS-specific launcher icon settings have been removed from this configuration file. - Application Environment Change: The default application environment in
lib/main.darthas been switched fromAppEnvironment.developmenttoAppEnvironment.demo. - Splash Screen Service Import Update: The import for the web splash screen service in
lib/main.darthas been updated, replacingweb_splash.dartwithsplash_screen_remover/web_splash_remover.dart, reflecting the refactored approach to handling splash screen removal.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the web splash screen, introducing a dedicated CSS file and updating the HTML structure. The changes are generally good, but I've identified a few issues:
- A configuration change in
flutter_launcher_icons.yamlmight unintentionally enable iOS icon generation. - The application environment in
main.dartis hardcoded todemo, which should be reverted before merging. - There's a duplicated CSS class definition for
.centerthat should be consolidated.
Please address these points to ensure the stability and maintainability of the codebase.
| # adaptive_icon_monochrome: "assets/icon/monochrome.png" | ||
|
|
||
| ios: false | ||
| # image_path_ios: "assets/icon/headlines_toolkit.png" | ||
| remove_alpha_channel_ios: true | ||
| # image_path_ios_dark_transparent: "assets/icon/icon_dark.png" | ||
| # image_path_ios_tinted_grayscale: "assets/icon/icon_tinted.png" | ||
| # desaturate_tinted_to_grayscale_ios: true |
There was a problem hiding this comment.
Removing this ios configuration block will cause the flutter_launcher_icons tool to default to generating icons for iOS (as ios defaults to true). This is a significant change from explicitly disabling it with ios: false. Was this intentional? If not, this could introduce unexpected changes or failures in the iOS build process.
If you intend to keep iOS icon generation disabled, this block should be restored, or at least ios: false should be present in the configuration.
| import 'package:flutter_news_app_mobile_client_full_source_code/bootstrap.dart'; | ||
|
|
||
| // Define the current application environment (production/development/demo). | ||
| const appEnvironment = AppEnvironment.development; | ||
| const appEnvironment = AppEnvironment.demo; |
There was a problem hiding this comment.
The application environment has been switched to demo. While this is likely for development and testing this feature, it should be reverted to the appropriate environment (e.g., development) before this pull request is merged. Merging this change could lead to deploying the wrong application variant.
const appEnvironment = AppEnvironment.development;
| .center { | ||
| margin: 0; | ||
| position: absolute; | ||
| top: 50%; | ||
| left: 50%; | ||
| -ms-transform: translate(-50%, -50%); | ||
| transform: translate(-50%, -50%); | ||
| } |
There was a problem hiding this comment.
This .center class is a duplicate of a class with the same name and properties defined inside a <style> tag in web/index.html (lines 48-55). To improve maintainability and avoid redundancy, please remove the duplicated style from index.html. Having a single source of truth for styles makes the code easier to manage.
Description
Type of Change