Skip to content

Commit 07cbc45

Browse files
committed
refactor: the content within the expandable sections (ExpansionTiles) now has the desired inner padding.
1 parent 2767661 commit 07cbc45

File tree

1 file changed

+37
-19
lines changed

1 file changed

+37
-19
lines changed

lib/settings/view/settings_page.dart

Lines changed: 37 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -159,22 +159,29 @@ class _SettingsView extends StatelessWidget {
159159
children: [
160160
ExpansionTile(
161161
title: Text(l10n.themeSettingsLabel),
162+
childrenPadding:
163+
const EdgeInsets.symmetric(
164+
horizontal: AppSpacing.xxl,
165+
),
162166
children: [
163167
_buildSettingSection(
164168
context,
165169
title: l10n.baseThemeLabel,
166-
description: l10n.baseThemeDescription,
170+
description:
171+
l10n.baseThemeDescription,
167172
child: DropdownButton<AppBaseTheme>(
168173
value: userAppSettings
169174
.displaySettings
170175
.baseTheme,
171176
onChanged: (value) {
172177
if (value != null) {
173-
context.read<SettingsBloc>().add(
174-
SettingsBaseThemeChanged(
175-
value,
176-
),
177-
);
178+
context
179+
.read<SettingsBloc>()
180+
.add(
181+
SettingsBaseThemeChanged(
182+
value,
183+
),
184+
);
178185
}
179186
},
180187
items: AppBaseTheme.values
@@ -232,22 +239,29 @@ class _SettingsView extends StatelessWidget {
232239
),
233240
ExpansionTile(
234241
title: Text(l10n.fontSettingsLabel),
242+
childrenPadding:
243+
const EdgeInsets.symmetric(
244+
horizontal: AppSpacing.xxl,
245+
),
235246
children: [
236247
_buildSettingSection(
237248
context,
238249
title: l10n.fontFamilyLabel,
239-
description: l10n.fontFamilyDescription,
250+
description:
251+
l10n.fontFamilyDescription,
240252
child: DropdownButton<String>(
241253
value: userAppSettings
242254
.displaySettings
243255
.fontFamily,
244256
onChanged: (value) {
245257
if (value != null) {
246-
context.read<SettingsBloc>().add(
247-
SettingsFontFamilyChanged(
248-
value,
249-
),
250-
);
258+
context
259+
.read<SettingsBloc>()
260+
.add(
261+
SettingsFontFamilyChanged(
262+
value,
263+
),
264+
);
251265
}
252266
},
253267
items: _supportedFontFamilies
@@ -305,18 +319,21 @@ class _SettingsView extends StatelessWidget {
305319
_buildSettingSection(
306320
context,
307321
title: l10n.fontWeightLabel,
308-
description: l10n.fontWeightDescription,
322+
description:
323+
l10n.fontWeightDescription,
309324
child: DropdownButton<AppFontWeight>(
310325
value: userAppSettings
311326
.displaySettings
312327
.fontWeight,
313328
onChanged: (value) {
314329
if (value != null) {
315-
context.read<SettingsBloc>().add(
316-
SettingsFontWeightChanged(
317-
value,
318-
),
319-
);
330+
context
331+
.read<SettingsBloc>()
332+
.add(
333+
SettingsFontWeightChanged(
334+
value,
335+
),
336+
);
320337
}
321338
},
322339
items: AppFontWeight.values
@@ -367,7 +384,8 @@ class _SettingsView extends StatelessWidget {
367384
_getLanguageName(lang, l10n),
368385
),
369386
),
370-
).toList(), // Added .toList() here
387+
)
388+
.toList(),
371389
isExpanded: true,
372390
),
373391
),

0 commit comments

Comments
 (0)