Skip to content

Commit 239a758

Browse files
committed
refactor(app_configuration): remove account action config section
- Remove ExpansionTile for feed actions configuration - Delete _buildAccountActionConfigSection method - Add const SizedBox.shrink() as a placeholder
1 parent 14d4c4a commit 239a758

File tree

2 files changed

+17
-72
lines changed

2 files changed

+17
-72
lines changed

lib/app_configuration/view/app_configuration_page.dart

Lines changed: 1 addition & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -157,15 +157,7 @@ class _AppConfigurationPageState extends State<AppConfigurationPage>
157157
),
158158
],
159159
),
160-
ExpansionTile(
161-
title: Text(l10n.feedActionsTitle),
162-
childrenPadding: const EdgeInsets.symmetric(
163-
horizontal: AppSpacing.xxl,
164-
),
165-
children: [
166-
_buildAccountActionConfigSection(context, remoteConfig),
167-
],
168-
),
160+
const SizedBox.shrink(),
169161
],
170162
),
171163
ListView(
@@ -434,61 +426,6 @@ class _AppConfigurationPageState extends State<AppConfigurationPage>
434426
);
435427
}
436428

437-
Widget _buildAccountActionConfigSection(
438-
BuildContext context,
439-
RemoteConfig remoteConfig,
440-
) {
441-
final l10n = AppLocalizationsX(context).l10n;
442-
return Column(
443-
crossAxisAlignment: CrossAxisAlignment.start,
444-
children: [
445-
Text(
446-
l10n.feedActionsDescription,
447-
style: Theme.of(context).textTheme.bodySmall?.copyWith(
448-
color: Theme.of(context).colorScheme.onSurface.withOpacity(0.7),
449-
),
450-
),
451-
const SizedBox(height: AppSpacing.lg),
452-
ExpansionTile(
453-
title: Text(l10n.guestUserTab),
454-
childrenPadding: const EdgeInsets.symmetric(
455-
horizontal: AppSpacing.xxl,
456-
),
457-
children: [
458-
_AccountActionConfigForm(
459-
userRole: AppUserRole.guestUser,
460-
remoteConfig: remoteConfig,
461-
onConfigChanged: (newConfig) {
462-
context.read<AppConfigurationBloc>().add(
463-
AppConfigurationFieldChanged(remoteConfig: newConfig),
464-
);
465-
},
466-
buildIntField: _buildIntField,
467-
),
468-
],
469-
),
470-
ExpansionTile(
471-
title: Text(l10n.standardUserAdTab),
472-
childrenPadding: const EdgeInsets.symmetric(
473-
horizontal: AppSpacing.xxl,
474-
),
475-
children: [
476-
_AccountActionConfigForm(
477-
userRole: AppUserRole.standardUser,
478-
remoteConfig: remoteConfig,
479-
onConfigChanged: (newConfig) {
480-
context.read<AppConfigurationBloc>().add(
481-
AppConfigurationFieldChanged(remoteConfig: newConfig),
482-
);
483-
},
484-
buildIntField: _buildIntField,
485-
),
486-
],
487-
),
488-
],
489-
);
490-
}
491-
492429
Widget _buildMaintenanceSection(
493430
BuildContext context,
494431
RemoteConfig remoteConfig,

pubspec.lock

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ packages:
3232
description:
3333
path: "."
3434
ref: HEAD
35-
resolved-ref: f48dc0555b1a28ed3c51215f3a93403dbbc46ea0
35+
resolved-ref: "9c25c6bff76c554e5220368536fcb9370758f48f"
3636
url: "https://github.com/flutter-news-app-full-source-code/auth-inmemory"
3737
source: git
3838
version: "0.0.0"
@@ -90,7 +90,7 @@ packages:
9090
description:
9191
path: "."
9292
ref: HEAD
93-
resolved-ref: f648500814ec636a2930498756029d29b363194a
93+
resolved-ref: "0da5bb63501a62f8c0848add164c593901186551"
9494
url: "https://github.com/flutter-news-app-full-source-code/core.git"
9595
source: git
9696
version: "0.0.0"
@@ -166,10 +166,10 @@ packages:
166166
dependency: transitive
167167
description:
168168
name: dio
169-
sha256: "253a18bbd4851fecba42f7343a1df3a9a4c1d31a2c1b37e221086b4fa8c8dbc9"
169+
sha256: d90ee57923d1828ac14e492ca49440f65477f4bb1263575900be731a3dac66a9
170170
url: "https://pub.dev"
171171
source: hosted
172-
version: "5.8.0+1"
172+
version: "5.9.0"
173173
dio_web_adapter:
174174
dependency: transitive
175175
description:
@@ -285,10 +285,10 @@ packages:
285285
dependency: transitive
286286
description:
287287
name: http
288-
sha256: "2c11f3f94c687ee9bad77c171151672986360b2b001d109814ee7140b2cf261b"
288+
sha256: bb2ce4590bc2667c96f318d68cac1b5a7987ec819351d32b1c987239a815e007
289289
url: "https://pub.dev"
290290
source: hosted
291-
version: "1.4.0"
291+
version: "1.5.0"
292292
http_client:
293293
dependency: "direct main"
294294
description:
@@ -364,6 +364,14 @@ packages:
364364
url: "https://pub.dev"
365365
source: hosted
366366
version: "1.16.0"
367+
mime:
368+
dependency: transitive
369+
description:
370+
name: mime
371+
sha256: "41a20518f0cb1256669420fdba0cd90d21561e560ac240f26ef8322e45bb7ed6"
372+
url: "https://pub.dev"
373+
source: hosted
374+
version: "2.0.0"
367375
nested:
368376
dependency: transitive
369377
description:
@@ -472,10 +480,10 @@ packages:
472480
dependency: transitive
473481
description:
474482
name: shared_preferences_android
475-
sha256: "20cbd561f743a342c76c151d6ddb93a9ce6005751e7aa458baad3858bfbfb6ac"
483+
sha256: "5bcf0772a761b04f8c6bf814721713de6f3e5d9d89caf8d3fe031b02a342379e"
476484
url: "https://pub.dev"
477485
source: hosted
478-
version: "2.4.10"
486+
version: "2.4.11"
479487
shared_preferences_foundation:
480488
dependency: transitive
481489
description:

0 commit comments

Comments
 (0)