Skip to content

Commit 9b8083c

Browse files
committed
refactor(settings): Simplify SettingsState
- Added userAppSettings to base state - Removed redundant props overrides
1 parent 2e475a5 commit 9b8083c

File tree

1 file changed

+20
-29
lines changed

1 file changed

+20
-29
lines changed

lib/settings/bloc/settings_state.dart

Lines changed: 20 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,88 +1,79 @@
11
part of 'settings_bloc.dart';
22

33
sealed class SettingsState extends Equatable {
4-
const SettingsState();
4+
const SettingsState({this.userAppSettings});
5+
6+
/// The current user application settings. Null if not loaded or unauthenticated.
7+
final UserAppSettings? userAppSettings;
58

69
@override
7-
List<Object?> get props => [];
10+
List<Object?> get props => [userAppSettings];
811
}
912

1013
/// {@template settings_initial}
1114
/// The initial settings state.
1215
/// {@endtemplate}
13-
final class SettingsInitial extends SettingsState {}
16+
final class SettingsInitial extends SettingsState {
17+
/// {@macro settings_initial}
18+
const SettingsInitial({super.userAppSettings});
19+
}
1420

1521
/// {@template settings_load_in_progress}
1622
/// State indicating that user settings are being loaded.
1723
/// {@endtemplate}
18-
final class SettingsLoadInProgress extends SettingsState {}
24+
final class SettingsLoadInProgress extends SettingsState {
25+
/// {@macro settings_load_in_progress}
26+
const SettingsLoadInProgress({super.userAppSettings});
27+
}
1928

2029
/// {@template settings_load_success}
2130
/// State indicating that user settings have been successfully loaded.
2231
/// {@endtemplate}
2332
final class SettingsLoadSuccess extends SettingsState {
2433
/// {@macro settings_load_success}
25-
const SettingsLoadSuccess({required this.userAppSettings});
26-
27-
/// The loaded user application settings.
28-
final UserAppSettings userAppSettings;
29-
30-
@override
31-
List<Object?> get props => [userAppSettings];
34+
const SettingsLoadSuccess({required super.userAppSettings});
3235
}
3336

3437
/// {@template settings_load_failure}
3538
/// State indicating that loading user settings failed.
3639
/// {@endtemplate}
3740
final class SettingsLoadFailure extends SettingsState {
3841
/// {@macro settings_load_failure}
39-
const SettingsLoadFailure(this.errorMessage);
42+
const SettingsLoadFailure(this.errorMessage, {super.userAppSettings});
4043

4144
/// The error message describing the failure.
4245
final String errorMessage;
4346

4447
@override
45-
List<Object?> get props => [errorMessage];
48+
List<Object?> get props => [errorMessage, userAppSettings];
4649
}
4750

4851
/// {@template settings_update_in_progress}
4952
/// State indicating that user settings are being updated.
5053
/// {@endtemplate}
5154
final class SettingsUpdateInProgress extends SettingsState {
5255
/// {@macro settings_update_in_progress}
53-
const SettingsUpdateInProgress({required this.userAppSettings});
54-
55-
/// The user application settings being updated.
56-
final UserAppSettings userAppSettings;
57-
58-
@override
59-
List<Object?> get props => [userAppSettings];
56+
const SettingsUpdateInProgress({required super.userAppSettings});
6057
}
6158

6259
/// {@template settings_update_success}
6360
/// State indicating that user settings have been successfully updated.
6461
/// {@endtemplate}
6562
final class SettingsUpdateSuccess extends SettingsState {
6663
/// {@macro settings_update_success}
67-
const SettingsUpdateSuccess({required this.userAppSettings});
68-
69-
/// The updated user application settings.
70-
final UserAppSettings userAppSettings;
71-
72-
@override
73-
List<Object?> get props => [userAppSettings];
64+
const SettingsUpdateSuccess({required super.userAppSettings});
7465
}
7566

7667
/// {@template settings_update_failure}
7768
/// State indicating that updating user settings failed.
7869
/// {@endtemplate}
7970
final class SettingsUpdateFailure extends SettingsState {
8071
/// {@macro settings_update_failure}
81-
const SettingsUpdateFailure(this.errorMessage);
72+
const SettingsUpdateFailure(this.errorMessage, {super.userAppSettings});
8273

8374
/// The error message describing the failure.
8475
final String errorMessage;
8576

8677
@override
87-
List<Object?> get props => [errorMessage];
78+
List<Object?> get props => [errorMessage, userAppSettings];
8879
}

0 commit comments

Comments
 (0)