lint: misc

Author: fulleni

analysis_options.yaml

@@ -2,9 +2,11 @@ analyzer:
   errors:
     avoid_catches_without_on_clauses: ignore
     avoid_print: ignore
+    avoid_redundant_argument_values: ignore
     deprecated_member_use: ignore
     document_ignores: ignore
     lines_longer_than_80_chars: ignore
+    unnecessary_null_checks: ignore
 include: package:very_good_analysis/analysis_options.9.0.0.yaml
 linter:
   rules:

lib/app_configuration/view/app_configuration_page.dart

@@ -211,7 +211,7 @@ class _AppConfigurationPageState extends State<AppConfigurationPage> {
               onPressed: isDirty
                   ? () async {
                       final confirmed = await _showConfirmationDialog(context);
-                      if (confirmed && appConfig != null) {
+                      if (context.mounted && confirmed && appConfig != null) {
                         context.read<AppConfigurationBloc>().add(
                           AppConfigurationUpdated(appConfig),
                         );

lib/content_management/view/content_management_page.dart

@@ -33,15 +33,18 @@ class _ContentManagementPageState extends State<ContentManagementPage>
 
   @override
   void dispose() {
-    _tabController.removeListener(_onTabChanged);
-    _tabController.dispose();
+    _tabController
+      ..removeListener(_onTabChanged)
+      ..dispose();
     super.dispose();
   }
 
   void _onTabChanged() {
     if (!_tabController.indexIsChanging) {
       final tab = ContentManagementTab.values[_tabController.index];
-      context.read<ContentManagementBloc>().add(ContentManagementTabChanged(tab));
+      context.read<ContentManagementBloc>().add(
+        ContentManagementTabChanged(tab),
+      );
     }
   }
 
@@ -56,8 +59,9 @@ class _ContentManagementPageState extends State<ContentManagementPage>
         appBar: AppBar(
           title: Text(l10n.contentManagement),
           bottom: PreferredSize(
-            preferredSize:
-                const Size.fromHeight(kTextTabBarHeight + AppSpacing.lg),
+            preferredSize: const Size.fromHeight(
+              kTextTabBarHeight + AppSpacing.lg,
+            ),
             child: Column(
               crossAxisAlignment: CrossAxisAlignment.start,
               children: [
@@ -70,8 +74,8 @@ class _ContentManagementPageState extends State<ContentManagementPage>
                   child: Text(
                     l10n.contentManagementPageDescription,
                     style: Theme.of(context).textTheme.bodyMedium?.copyWith(
-                          color: Theme.of(context).colorScheme.onSurfaceVariant,
-                        ),
+                      color: Theme.of(context).colorScheme.onSurfaceVariant,
+                    ),
                   ),
                 ),
                 TabBar(
@@ -98,8 +102,10 @@ class _ContentManagementPageState extends State<ContentManagementPage>
         ),
         floatingActionButton: FloatingActionButton(
           onPressed: () {
-            final currentTab =
-                context.read<ContentManagementBloc>().state.activeTab;
+            final currentTab = context
+                .read<ContentManagementBloc>()
+                .state
+                .activeTab;
             switch (currentTab) {
               case ContentManagementTab.headlines:
                 context.goNamed(Routes.createHeadlineName);