Skip to content

Commit cf962e5

Browse files
fullenifulleni
committed
lint: misc
1 parent 35e8663 commit cf962e5

File tree

12 files changed

+83
-84
lines changed

12 files changed

+83
-84
lines changed

‎lib/app/view/app.dart

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,26 +37,26 @@ class App extends StatelessWidget {
3737
required KVStorageService storageService,
3838
required AppEnvironment environment,
3939
super.key,
40-
}) : _authenticationRepository = authenticationRepository,
41-
_headlinesRepository = headlinesRepository,
42-
_topicsRepository = topicsRepository,
43-
_sourcesRepository = sourcesRepository,
44-
_userAppSettingsRepository = userAppSettingsRepository,
45-
_userContentPreferencesRepository = userContentPreferencesRepository,
46-
_remoteConfigRepository = remoteConfigRepository,
47-
_kvStorageService = storageService,
48-
_dashboardSummaryRepository = dashboardSummaryRepository,
49-
_countriesRepository = countriesRepository,
50-
_languagesRepository = languagesRepository,
51-
_environment = environment;
40+
}) : _authenticationRepository = authenticationRepository,
41+
_headlinesRepository = headlinesRepository,
42+
_topicsRepository = topicsRepository,
43+
_sourcesRepository = sourcesRepository,
44+
_userAppSettingsRepository = userAppSettingsRepository,
45+
_userContentPreferencesRepository = userContentPreferencesRepository,
46+
_remoteConfigRepository = remoteConfigRepository,
47+
_kvStorageService = storageService,
48+
_dashboardSummaryRepository = dashboardSummaryRepository,
49+
_countriesRepository = countriesRepository,
50+
_languagesRepository = languagesRepository,
51+
_environment = environment;
5252

5353
final AuthRepository _authenticationRepository;
5454
final DataRepository<Headline> _headlinesRepository;
5555
final DataRepository<Topic> _topicsRepository;
5656
final DataRepository<Source> _sourcesRepository;
5757
final DataRepository<UserAppSettings> _userAppSettingsRepository;
5858
final DataRepository<UserContentPreferences>
59-
_userContentPreferencesRepository;
59+
_userContentPreferencesRepository;
6060
final DataRepository<RemoteConfig> _remoteConfigRepository;
6161
final DataRepository<DashboardSummary> _dashboardSummaryRepository;
6262
final DataRepository<Country> _countriesRepository;

‎lib/authentication/bloc/authentication_state.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ final class AuthenticationState extends Equatable {
7272
user: user ?? this.user,
7373
email: email ?? this.email,
7474
exception: exception ?? this.exception,
75-
cooldownEndTime:
76-
clearCooldownEndTime ? null : cooldownEndTime ?? this.cooldownEndTime,
75+
cooldownEndTime: clearCooldownEndTime
76+
? null
77+
: cooldownEndTime ?? this.cooldownEndTime,
7778
);
7879
}
7980
}

‎lib/authentication/view/request_code_page.dart

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -232,10 +232,10 @@ class _EmailLinkFormState extends State<_EmailLinkForm> {
232232
void _submitForm() {
233233
if (_formKey.currentState!.validate()) {
234234
context.read<AuthenticationBloc>().add(
235-
AuthenticationRequestSignInCodeRequested(
236-
email: _emailController.text.trim(),
237-
),
238-
);
235+
AuthenticationRequestSignInCodeRequested(
236+
email: _emailController.text.trim(),
237+
),
238+
);
239239
}
240240
}
241241

@@ -276,13 +276,15 @@ class _EmailLinkFormState extends State<_EmailLinkForm> {
276276
}
277277
return null;
278278
},
279-
onFieldSubmitted:
280-
widget.isLoading || _cooldownSeconds > 0 ? null : (_) => _submitForm(),
279+
onFieldSubmitted: widget.isLoading || _cooldownSeconds > 0
280+
? null
281+
: (_) => _submitForm(),
281282
),
282283
const SizedBox(height: AppSpacing.lg),
283284
ElevatedButton(
284-
onPressed:
285-
widget.isLoading || _cooldownSeconds > 0 ? null : _submitForm,
285+
onPressed: widget.isLoading || _cooldownSeconds > 0
286+
? null
287+
: _submitForm,
286288
style: ElevatedButton.styleFrom(
287289
padding: const EdgeInsets.symmetric(vertical: AppSpacing.md),
288290
textStyle: textTheme.labelLarge,
@@ -297,12 +299,12 @@ class _EmailLinkFormState extends State<_EmailLinkForm> {
297299
),
298300
)
299301
: _cooldownSeconds > 0
300-
? Text(
301-
l10n.requestCodeResendButtonCooldown(
302-
_cooldownSeconds,
303-
),
304-
)
305-
: Text(l10n.requestCodeSendCodeButton),
302+
? Text(
303+
l10n.requestCodeResendButtonCooldown(
304+
_cooldownSeconds,
305+
),
306+
)
307+
: Text(l10n.requestCodeSendCodeButton),
306308
),
307309
],
308310
),

‎lib/bootstrap.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,12 @@ Future<Widget> bootstrap(
264264
final dashboardSummaryRepository = DataRepository<DashboardSummary>(
265265
dataClient: dashboardSummaryClient,
266266
);
267-
final countriesRepository =
268-
DataRepository<Country>(dataClient: countriesClient);
269-
final languagesRepository =
270-
DataRepository<Language>(dataClient: languagesClient);
267+
final countriesRepository = DataRepository<Country>(
268+
dataClient: countriesClient,
269+
);
270+
final languagesRepository = DataRepository<Language>(
271+
dataClient: languagesClient,
272+
);
271273

272274
return App(
273275
authenticationRepository: authenticationRepository,

‎lib/content_management/bloc/create_headline/create_headline_bloc.dart

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:bloc/bloc.dart';
2-
import 'package:bloc_concurrency/bloc_concurrency.dart';
32
import 'package:core/core.dart';
43
import 'package:data_repository/data_repository.dart';
54
import 'package:equatable/equatable.dart';
@@ -13,8 +12,6 @@ final class _FetchNextCountryPage extends CreateHeadlineEvent {
1312
const _FetchNextCountryPage();
1413
}
1514

16-
const _searchDebounceDuration = Duration(milliseconds: 300);
17-
1815
/// A BLoC to manage the state of creating a new headline.
1916
class CreateHeadlineBloc
2017
extends Bloc<CreateHeadlineEvent, CreateHeadlineState> {
@@ -24,11 +21,11 @@ class CreateHeadlineBloc
2421
required DataRepository<Source> sourcesRepository,
2522
required DataRepository<Topic> topicsRepository,
2623
required DataRepository<Country> countriesRepository,
27-
}) : _headlinesRepository = headlinesRepository,
28-
_sourcesRepository = sourcesRepository,
29-
_topicsRepository = topicsRepository,
30-
_countriesRepository = countriesRepository,
31-
super(const CreateHeadlineState()) {
24+
}) : _headlinesRepository = headlinesRepository,
25+
_sourcesRepository = sourcesRepository,
26+
_topicsRepository = topicsRepository,
27+
_countriesRepository = countriesRepository,
28+
super(const CreateHeadlineState()) {
3229
on<CreateHeadlineDataLoaded>(_onDataLoaded);
3330
on<CreateHeadlineTitleChanged>(_onTitleChanged);
3431
on<CreateHeadlineExcerptChanged>(_onExcerptChanged);
@@ -177,6 +174,7 @@ class CreateHeadlineBloc
177174
try {
178175
emit(state.copyWith(countriesIsLoadingMore: true));
179176

177+
// ignore: inference_failure_on_instance_creation
180178
await Future.delayed(const Duration(milliseconds: 400));
181179

182180
final nextCountries = await _countriesRepository.readAll(

‎lib/content_management/bloc/create_source/create_source_bloc.dart

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:bloc/bloc.dart';
2-
import 'package:bloc_concurrency/bloc_concurrency.dart';
32
import 'package:core/core.dart';
43
import 'package:data_repository/data_repository.dart';
54
import 'package:equatable/equatable.dart';
@@ -17,19 +16,17 @@ final class _FetchNextLanguagePage extends CreateSourceEvent {
1716
const _FetchNextLanguagePage();
1817
}
1918

20-
const _searchDebounceDuration = Duration(milliseconds: 300);
21-
2219
/// A BLoC to manage the state of creating a new source.
2320
class CreateSourceBloc extends Bloc<CreateSourceEvent, CreateSourceState> {
2421
/// {@macro create_source_bloc}
2522
CreateSourceBloc({
2623
required DataRepository<Source> sourcesRepository,
2724
required DataRepository<Country> countriesRepository,
2825
required DataRepository<Language> languagesRepository,
29-
}) : _sourcesRepository = sourcesRepository,
30-
_countriesRepository = countriesRepository,
31-
_languagesRepository = languagesRepository,
32-
super(const CreateSourceState()) {
26+
}) : _sourcesRepository = sourcesRepository,
27+
_countriesRepository = countriesRepository,
28+
_languagesRepository = languagesRepository,
29+
super(const CreateSourceState()) {
3330
on<CreateSourceDataLoaded>(_onDataLoaded);
3431
on<CreateSourceNameChanged>(_onNameChanged);
3532
on<CreateSourceDescriptionChanged>(_onDescriptionChanged);
@@ -168,6 +165,7 @@ class CreateSourceBloc extends Bloc<CreateSourceEvent, CreateSourceState> {
168165
try {
169166
emit(state.copyWith(countriesIsLoadingMore: true));
170167

168+
// ignore: inference_failure_on_instance_creation
171169
await Future.delayed(const Duration(milliseconds: 400));
172170

173171
final nextCountries = await _countriesRepository.readAll(
@@ -202,6 +200,7 @@ class CreateSourceBloc extends Bloc<CreateSourceEvent, CreateSourceState> {
202200
try {
203201
emit(state.copyWith(languagesIsLoadingMore: true));
204202

203+
// ignore: inference_failure_on_instance_creation
205204
await Future.delayed(const Duration(milliseconds: 400));
206205

207206
final nextLanguages = await _languagesRepository.readAll(

‎lib/content_management/bloc/edit_headline/edit_headline_bloc.dart

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:bloc/bloc.dart';
2-
import 'package:bloc_concurrency/bloc_concurrency.dart';
32
import 'package:core/core.dart';
43
import 'package:data_repository/data_repository.dart';
54
import 'package:equatable/equatable.dart';
@@ -12,8 +11,6 @@ final class _FetchNextCountryPage extends EditHeadlineEvent {
1211
const _FetchNextCountryPage();
1312
}
1413

15-
const _searchDebounceDuration = Duration(milliseconds: 300);
16-
1714
/// A BLoC to manage the state of editing a single headline.
1815
class EditHeadlineBloc extends Bloc<EditHeadlineEvent, EditHeadlineState> {
1916
/// {@macro edit_headline_bloc}
@@ -23,12 +20,12 @@ class EditHeadlineBloc extends Bloc<EditHeadlineEvent, EditHeadlineState> {
2320
required DataRepository<Topic> topicsRepository,
2421
required DataRepository<Country> countriesRepository,
2522
required String headlineId,
26-
}) : _headlinesRepository = headlinesRepository,
27-
_sourcesRepository = sourcesRepository,
28-
_topicsRepository = topicsRepository,
29-
_countriesRepository = countriesRepository,
30-
_headlineId = headlineId,
31-
super(const EditHeadlineState()) {
23+
}) : _headlinesRepository = headlinesRepository,
24+
_sourcesRepository = sourcesRepository,
25+
_topicsRepository = topicsRepository,
26+
_countriesRepository = countriesRepository,
27+
_headlineId = headlineId,
28+
super(const EditHeadlineState()) {
3229
on<EditHeadlineLoaded>(_onLoaded);
3330
on<EditHeadlineTitleChanged>(_onTitleChanged);
3431
on<EditHeadlineExcerptChanged>(_onExcerptChanged);
@@ -215,6 +212,7 @@ class EditHeadlineBloc extends Bloc<EditHeadlineEvent, EditHeadlineState> {
215212
try {
216213
emit(state.copyWith(countriesIsLoadingMore: true));
217214

215+
// ignore: inference_failure_on_instance_creation
218216
await Future.delayed(const Duration(milliseconds: 400));
219217

220218
final nextCountries = await _countriesRepository.readAll(

‎lib/content_management/bloc/edit_source/edit_source_bloc.dart

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:bloc/bloc.dart';
2-
import 'package:bloc_concurrency/bloc_concurrency.dart';
32
import 'package:core/core.dart';
43
import 'package:data_repository/data_repository.dart';
54
import 'package:equatable/equatable.dart';
@@ -16,8 +15,6 @@ final class _FetchNextLanguagePage extends EditSourceEvent {
1615
const _FetchNextLanguagePage();
1716
}
1817

19-
const _searchDebounceDuration = Duration(milliseconds: 300);
20-
2118
/// A BLoC to manage the state of editing a single source.
2219
class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
2320
/// {@macro edit_source_bloc}
@@ -26,11 +23,11 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
2623
required DataRepository<Country> countriesRepository,
2724
required DataRepository<Language> languagesRepository,
2825
required String sourceId,
29-
}) : _sourcesRepository = sourcesRepository,
30-
_countriesRepository = countriesRepository,
31-
_languagesRepository = languagesRepository,
32-
_sourceId = sourceId,
33-
super(const EditSourceState()) {
26+
}) : _sourcesRepository = sourcesRepository,
27+
_countriesRepository = countriesRepository,
28+
_languagesRepository = languagesRepository,
29+
_sourceId = sourceId,
30+
super(const EditSourceState()) {
3431
on<EditSourceLoaded>(_onLoaded);
3532
on<EditSourceNameChanged>(_onNameChanged);
3633
on<EditSourceDescriptionChanged>(_onDescriptionChanged);
@@ -74,7 +71,7 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
7471
// Find the equivalent language object from the full list.
7572
// This ensures the DropdownButton can identify it by reference.
7673
selectedLanguage = languagesPaginated.items.firstWhere(
77-
(listLanguage) => listLanguage.id == source.language?.id,
74+
(listLanguage) => listLanguage.id == source.language.id,
7875
);
7976
} catch (_) {
8077
selectedLanguage = source.language;
@@ -212,6 +209,7 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
212209
try {
213210
emit(state.copyWith(countriesIsLoadingMore: true));
214211

212+
// ignore: inference_failure_on_instance_creation
215213
await Future.delayed(const Duration(milliseconds: 400));
216214

217215
final nextCountries = await _countriesRepository.readAll(
@@ -246,6 +244,7 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> {
246244
try {
247245
emit(state.copyWith(languagesIsLoadingMore: true));
248246

247+
// ignore: inference_failure_on_instance_creation
249248
await Future.delayed(const Duration(milliseconds: 400));
250249

251250
final nextLanguages = await _languagesRepository.readAll(

‎lib/content_management/view/create_headline_page.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,9 @@ class _CreateHeadlineViewState extends State<_CreateHeadlineView> {
250250
],
251251
onChanged: state.countriesIsLoadingMore
252252
? null
253-
: (value) => context
254-
.read<CreateHeadlineBloc>()
255-
.add(CreateHeadlineCountryChanged(value)),
253+
: (value) => context.read<CreateHeadlineBloc>().add(
254+
CreateHeadlineCountryChanged(value),
255+
),
256256
),
257257
const SizedBox(height: AppSpacing.lg),
258258
DropdownButtonFormField<ContentStatus>(

‎lib/content_management/view/create_source_page.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -181,9 +181,9 @@ class _CreateSourceViewState extends State<_CreateSourceView> {
181181
],
182182
onChanged: state.languagesIsLoadingMore
183183
? null
184-
: (value) => context
185-
.read<CreateSourceBloc>()
186-
.add(CreateSourceLanguageChanged(value)),
184+
: (value) => context.read<CreateSourceBloc>().add(
185+
CreateSourceLanguageChanged(value),
186+
),
187187
),
188188
const SizedBox(height: AppSpacing.lg),
189189
DropdownButtonFormField<SourceType?>(
@@ -242,9 +242,9 @@ class _CreateSourceViewState extends State<_CreateSourceView> {
242242
],
243243
onChanged: state.countriesIsLoadingMore
244244
? null
245-
: (value) => context
246-
.read<CreateSourceBloc>()
247-
.add(CreateSourceHeadquartersChanged(value)),
245+
: (value) => context.read<CreateSourceBloc>().add(
246+
CreateSourceHeadquartersChanged(value),
247+
),
248248
),
249249
const SizedBox(height: AppSpacing.lg),
250250
DropdownButtonFormField<ContentStatus>(

0 commit comments

Comments
 (0)