Sync engine 3.29.0 source code

Author: JSUYA

flutter/shell/platform/common/BUILD.gn

@@ -57,11 +57,13 @@ source_set("common_cpp_input") {
 source_set("common_cpp_accessibility") {
   public = [
     "accessibility_bridge.h",
+    "alert_platform_node_delegate.h",
     "flutter_platform_node_delegate.h",
   ]
 
   sources = [
     "accessibility_bridge.cc",
+    "alert_platform_node_delegate.cc",
     "flutter_platform_node_delegate.cc",
   ]
 

flutter/shell/platform/common/accessibility_bridge.cc

@@ -163,6 +163,17 @@ void AccessibilityBridge::OnRoleChanged(ui::AXTree* tree,
                                         ax::mojom::Role old_role,
                                         ax::mojom::Role new_role) {}
 
+void AccessibilityBridge::OnNodeDataChanged(
+    ui::AXTree* tree,
+    const ui::AXNodeData& old_node_data,
+    const ui::AXNodeData& new_node_data) {
+  auto platform_view =
+      GetFlutterPlatformNodeDelegateFromID(new_node_data.id).lock();
+  if (platform_view) {
+    platform_view->NodeDataChanged(old_node_data, new_node_data);
+  }
+}
+
 void AccessibilityBridge::OnNodeCreated(ui::AXTree* tree, ui::AXNode* node) {
   BASE_DCHECK(node);
   id_wrapper_map_[node->id()] = CreateFlutterPlatformNodeDelegate();

flutter/shell/platform/common/accessibility_bridge.h

@@ -260,6 +260,11 @@ class AccessibilityBridge
                      ax::mojom::Role old_role,
                      ax::mojom::Role new_role) override;
 
+  // |AXTreeObserver|
+  void OnNodeDataChanged(ui::AXTree* tree,
+                         const ui::AXNodeData& old_node_data,
+                         const ui::AXNodeData& new_node_data) override;
+
   // |AXTreeObserver|
   void OnAtomicUpdateFinished(
       ui::AXTree* tree,

flutter/shell/platform/common/client_wrapper/include/flutter/event_channel.h

@@ -67,9 +67,9 @@ class EventChannel {
     BinaryMessageHandler binary_handler =
         [shared_handler, codec, channel_name, messenger,
          // Mutable state to track the handler's listening status.
-         is_listening = bool(false)](const uint8_t* message,
-                                     const size_t message_size,
-                                     const BinaryReply& reply) mutable {
+         is_listening = false](const uint8_t* message,
+                               const size_t message_size,
+                               const BinaryReply& reply) mutable {
           constexpr char kOnListenMethod[] = "listen";
           constexpr char kOnCancelMethod[] = "cancel";
 

flutter/shell/platform/common/flutter_platform_node_delegate.h

@@ -139,6 +139,12 @@ class FlutterPlatformNodeDelegate : public ui::AXPlatformNodeDelegateBase {
   ///             Subclasses must call super.
   virtual void Init(std::weak_ptr<OwnerBridge> bridge, ui::AXNode* node);
 
+  //------------------------------------------------------------------------------
+  // @brief       Called when node was updated. Subclasses can override this
+  //              to update platform nodes.
+  virtual void NodeDataChanged(const ui::AXNodeData& old_node_data,
+                               const ui::AXNodeData& new_node_data) {}
+
   //------------------------------------------------------------------------------
   /// @brief      Gets the underlying ax node for this platform node delegate.
   ui::AXNode* GetAXNode() const;

flutter/shell/platform/embedder/test_utils/proc_table_replacement.h

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#ifndef FLUTTER_SHELL_PLATFORM_EMBEDDER_TEST_UTILS_PROC_TABLE_REPLACEMENT_H_
+#define FLUTTER_SHELL_PLATFORM_EMBEDDER_TEST_UTILS_PROC_TABLE_REPLACEMENT_H_
+
 #include "flutter/shell/platform/embedder/embedder.h"
 
 // Wraps capturing lambas with non-capturing version that can be assigned to
@@ -22,3 +25,5 @@
     static auto non_capturing = [](auto... args) { return closure(args...); }; \
     return non_capturing;                                                      \
   })()
+
+#endif  // FLUTTER_SHELL_PLATFORM_EMBEDDER_TEST_UTILS_PROC_TABLE_REPLACEMENT_H_