Implement merged UI and platform thread (#104)

Author: seungsoo47

flutter/shell/platform/tizen/flutter_project_bundle.cc

@@ -50,6 +50,9 @@ FlutterProjectBundle::FlutterProjectBundle(
         std::string(properties.dart_entrypoint_argv[i]));
   }
 
+  ui_thread_policy_ =
+      static_cast<FlutterUIThreadPolicy>(properties.ui_thread_policy);
+
   // Resolve any relative paths.
   if (assets_path_.is_relative() || icu_path_.is_relative() ||
       (!aot_library_path_.empty() && aot_library_path_.is_relative())) {

flutter/shell/platform/tizen/flutter_project_bundle.h

@@ -18,6 +18,12 @@ namespace flutter {
 using UniqueAotDataPtr =
     std::unique_ptr<_FlutterEngineAOTData, FlutterEngineCollectAOTDataFnPtr>;
 
+enum class FlutterUIThreadPolicy {
+  kDefault,
+  kRunOnPlatformThread,
+  kRunOnSeparateThread,
+};
+
 // The data associated with a Flutter project needed to run it in an engine.
 class FlutterProjectBundle {
  public:
@@ -67,6 +73,9 @@ class FlutterProjectBundle {
     return dart_entrypoint_arguments_;
   }
 
+  // Returns thread policy for running the UI isolate.
+  FlutterUIThreadPolicy ui_thread_policy() { return ui_thread_policy_; }
+
  private:
   std::filesystem::path assets_path_;
   std::filesystem::path icu_path_;
@@ -80,6 +89,9 @@ class FlutterProjectBundle {
 
   // Dart entrypoint arguments.
   std::vector<std::string> dart_entrypoint_arguments_;
+
+  // Thread policy for running the UI isolate.
+  FlutterUIThreadPolicy ui_thread_policy_;
 };
 
 }  // namespace flutter

flutter/shell/platform/tizen/flutter_tizen_engine.cc

@@ -177,6 +177,11 @@ bool FlutterTizenEngine::RunEngine() {
     custom_task_runners.render_task_runner = &render_task_runner;
   }
 
+  if (project_->ui_thread_policy() !=
+      FlutterUIThreadPolicy::kRunOnSeparateThread) {
+    custom_task_runners.ui_task_runner = &platform_task_runner;
+  }
+
   FlutterProjectArgs args = {};
   args.struct_size = sizeof(FlutterProjectArgs);
   args.assets_path = assets_path_string.c_str();

flutter/shell/platform/tizen/flutter_tizen_engine_unittest.cc

@@ -23,6 +23,8 @@ class FlutterTizenEngineTest : public ::testing::Test {
     engine_prop.assets_path = "/foo/flutter_assets";
     engine_prop.icu_data_path = "/foo/icudtl.dat";
     engine_prop.aot_library_path = "/foo/libapp.so";
+    engine_prop.ui_thread_policy =
+        FlutterDesktopUIThreadPolicy::kRunOnPlatformThread;
 
     FlutterProjectBundle project(engine_prop);
     auto engine = std::make_unique<FlutterTizenEngine>(project);
@@ -64,6 +66,8 @@ TEST_F(FlutterTizenEngineTest, RunDoesExpectedInitialization) {
         EXPECT_EQ(args->dart_entrypoint_argc, 0);
         EXPECT_NE(args->platform_message_callback, nullptr);
         EXPECT_NE(args->custom_task_runners, nullptr);
+        EXPECT_EQ(args->custom_task_runners->platform_task_runner,
+                  args->custom_task_runners->ui_task_runner);
         EXPECT_EQ(args->custom_dart_entrypoint, nullptr);
 
         return kSuccess;

flutter/shell/platform/tizen/public/flutter_tizen.h

@@ -45,6 +45,16 @@ typedef enum {
   kHDMI,
 } FlutterDesktopExternalOutputType;
 
+// Configures the thread policy for running the UI isolate.
+typedef enum {
+  // Default value. Currently run the UI isolate on platform thread.
+  kDefault,
+  // Run the UI isolate on platform thread.
+  kRunOnPlatformThread,
+  // Run the UI isolate on a separate thread.
+  kRunOnSeparateThread,
+} FlutterDesktopUIThreadPolicy;
+
 // Properties for configuring the initial settings of a Flutter window.
 typedef struct {
   // The x-coordinate of the top left corner of the window.
@@ -104,6 +114,8 @@ typedef struct {
   // Array of Dart entrypoint arguments. This is deep copied during the call
   // to FlutterDesktopRunEngine.
   const char** dart_entrypoint_argv;
+  // Policy for the thread that runs UI isolate.
+  FlutterDesktopUIThreadPolicy ui_thread_policy;
 } FlutterDesktopEngineProperties;
 
 // ========== Engine ==========

tools/generate_sysroot.py

@@ -144,8 +144,8 @@ def generate_sysroot(sysroot: Path, api_version: float, arch: str, quiet=False):
     sys.exit('Unknown arch: ' + arch)
 
   if api_version >= 10.0:
-    base_repo = 'http://download.tizen.org/snapshots/TIZEN/Tizen/Tizen-Base/reference/repos/standard/packages/'
-    unified_repo = 'http://download.tizen.org/snapshots/TIZEN/Tizen/Tizen-Unified/reference/repos//{}/packages'.format(
+    base_repo = 'http://download.tizen.org/snapshots/TIZEN/Tizen/Tizen-Base/reference/repos/standard/packages'
+    unified_repo = 'http://download.tizen.org/snapshots/TIZEN/Tizen/Tizen-Unified/reference/repos/{}/packages'.format(
       target)
   else:
     base_repo = 'http://download.tizen.org/snapshots/TIZEN/Tizen-{}/Tizen-{}-Base/reference/repos/standard/packages'.format(