Fix coverity issues (#196)

* Fix static analysis issue (coverity)

* Improper use of negative value

Signed-off-by: MuHong Byun <[email protected]>

* Fix static analysis issue (coverity)

* Uninitialized scalar field

Signed-off-by: MuHong Byun <[email protected]>

* Fix static analysis issue (coverity)

* Logically dead code

Signed-off-by: MuHong Byun <[email protected]>

* Fix static analysis issue (coverity)

* Uninitialized pointer field

Signed-off-by: MuHong Byun <[email protected]>

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>

Author: bwikbs

shell/platform/tizen/channels/text_input_channel.cc

@@ -272,7 +272,8 @@ void TextInputChannel::HandleMethodCall(
       size_t cursor_offset = selection_base_value - composing_start;
 
       active_model_->SetComposingRange(
-          flutter::TextRange(composing_base_value, composing_extent_value),
+          flutter::TextRange(static_cast<size_t>(composing_base_value),
+                             static_cast<size_t>(composing_extent_value)),
           cursor_offset);
     }
     SendStateUpdate(*active_model_);

shell/platform/tizen/flutter_tizen_engine.cc

@@ -77,6 +77,8 @@ FlutterTizenEngine::FlutterTizenEngine(const FlutterProjectBundle& project)
 
   plugin_registrar_ = std::make_unique<FlutterDesktopPluginRegistrar>();
   plugin_registrar_->engine = this;
+
+  transformation_ = {1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0};
 }
 
 FlutterTizenEngine::~FlutterTizenEngine() {

shell/platform/tizen/flutter_tizen_engine_unittest.cc

@@ -37,7 +37,7 @@ class FlutterTizenEngineTest : public ::testing::Test {
     engine_ = nullptr;
   }
 
-  FlutterTizenEngine* engine_;
+  FlutterTizenEngine* engine_ = nullptr;
 };
 
 class FlutterTizenEngineTestHeaded : public FlutterTizenEngineTest {

shell/platform/tizen/flutter_tizen_texture_registrar_unittests.cc

@@ -40,7 +40,7 @@ class FlutterTizenTextureRegistrarTest : public ::testing::Test {
     engine_ = nullptr;
   }
 
-  FlutterTizenEngine* engine_;
+  FlutterTizenEngine* engine_ = nullptr;
 };
 
 TEST_F(FlutterTizenTextureRegistrarTest, CreateDestroy) {

shell/platform/tizen/tizen_input_method_context.cc

@@ -13,13 +13,10 @@ const char* GetEcoreImfContextAvailableId() {
   Eina_List* modules;
 
   modules = ecore_imf_context_available_ids_get();
-  if (!modules) {
-    return nullptr;
+  if (modules) {
+    void* module;
+    EINA_LIST_FREE(modules, module) { return static_cast<const char*>(module); }
   }
-
-  void* module;
-  EINA_LIST_FREE(modules, module) { return static_cast<const char*>(module); }
-
   return nullptr;
 }