Format files to pass CI checks

Author: swift-kim

ci/tizen/check-symbol.py

@@ -9,74 +9,76 @@
 
 
 class Symbol:
-    def __init__(self, addr, type, name):
-        self.addr = addr
-        self.type = type
-        self.name = name
 
-    def __str__(self):
-        return '{} {} {}'.format(self.addr, self.type, self.name)
+  def __init__(self, addr, type, name):
+    self.addr = addr
+    self.type = type
+    self.name = name
 
-    @staticmethod
-    def parse(line):
-        return Symbol(line[:8].strip(), line[9], line[11:].strip())
+  def __str__(self):
+    return '{} {} {}'.format(self.addr, self.type, self.name)
+
+  @staticmethod
+  def parse(line):
+    return Symbol(line[:8].strip(), line[9], line[11:].strip())
 
 
 def check_symbol(sofile, allowlist):
-    if not os.access(sofile, os.R_OK):
-        raise Exception('{} is not readable'.format(sofile))
-    if not os.access(allowlist, os.R_OK):
-        raise Exception('{} is not readable'.format(allowlist))
-
-    try:
-        symbols_raw = subprocess.check_output(
-            ['nm', '-gDC', sofile]).decode('utf-8').splitlines()
-        symbols = [Symbol.parse(line) for line in symbols_raw]
-    except subprocess.CalledProcessError as e:
-        raise Exception('nm failed: {}'.format(e))
-
-    with open(allowlist, 'r') as f:
-        allowlist = [line.strip() for line in f.readlines()]
-
-    not_allowed = []
-    for symbol in symbols:
-        if symbol.addr:
-            continue
-        if symbol.name.startswith('FlutterEngine'):
-            continue
-        if symbol.name in allowlist:
-            continue
-        not_allowed.append(symbol)
-
-    if not_allowed:
-        print('Symbols not allowed ({}):'.format(sofile))
-        for symbol in not_allowed:
-            print(symbol)
-        return False
-
-    return True
+  if not os.access(sofile, os.R_OK):
+    raise Exception('{} is not readable'.format(sofile))
+  if not os.access(allowlist, os.R_OK):
+    raise Exception('{} is not readable'.format(allowlist))
+
+  try:
+    symbols_raw = subprocess.check_output(['nm', '-gDC',
+                                           sofile]).decode('utf-8').splitlines()
+    symbols = [Symbol.parse(line) for line in symbols_raw]
+  except subprocess.CalledProcessError as e:
+    raise Exception('nm failed: {}'.format(e))
+
+  with open(allowlist, 'r') as f:
+    allowlist = [line.strip() for line in f.readlines()]
+
+  not_allowed = []
+  for symbol in symbols:
+    if symbol.addr:
+      continue
+    if symbol.name.startswith('FlutterEngine'):
+      continue
+    if symbol.name in allowlist:
+      continue
+    not_allowed.append(symbol)
+
+  if not_allowed:
+    print('Symbols not allowed ({}):'.format(sofile))
+    for symbol in not_allowed:
+      print(symbol)
+    return False
+
+  return True
 
 
 def main():
-    import optparse
-    parser = optparse.OptionParser(usage='%prog [options] [sofile ..]')
-    parser.add_option('--allowlist', dest='allowlist',
-                      help='Path to the allowlist file')
-    (options, args) = parser.parse_args()
+  import optparse
+  parser = optparse.OptionParser(usage='%prog [options] [sofile ..]')
+  parser.add_option(
+      '--allowlist', dest='allowlist', help='Path to the allowlist file'
+  )
+  (options, args) = parser.parse_args()
 
-    if not options.allowlist:
-        print('--allowlist is required')
-        return 1
-    if not args:
-        print('sofile is required')
-        return 1
+  if not options.allowlist:
+    print('--allowlist is required')
+    return 1
+  if not args:
+    print('sofile is required')
+    return 1
 
-    for sofile in args:
-        if not check_symbol(sofile, options.allowlist):
-            return 1
+  for sofile in args:
+    if not check_symbol(sofile, options.allowlist):
+      return 1
 
-    return 0
+  return 0
 
 
 if __name__ == '__main__':
-    sys.exit(main())
+  sys.exit(main())

ci/tizen/gclient-shallow-sync.py

@@ -10,56 +10,58 @@
 
 
 def run_git(args, cwd):
-    if not args:
-        raise Exception('Please provide a git command to run.')
-    return subprocess.call(['git'] + args, cwd=cwd) == 0
+  if not args:
+    raise Exception('Please provide a git command to run.')
+  return subprocess.call(['git'] + args, cwd=cwd) == 0
 
 
 def checkout_shallow_git(path, url, revision):
-    """Checks out a shallow reference, then sets the expected branch to be
+  """Checks out a shallow reference, then sets the expected branch to be
     checked out."""
 
-    os.makedirs(path, exist_ok=True)
-    run_git(['init', '--quiet'], path)
-    run_git(['config', 'advice.detachedHead', 'false'], path)
-    run_git(['remote', 'add', 'origin', url], path)
-    run_git(['fetch', '--depth', '1', 'origin', revision], path)
-    run_git(['checkout', 'FETCH_HEAD'], path)
+  os.makedirs(path, exist_ok=True)
+  run_git(['init', '--quiet'], path)
+  run_git(['config', 'advice.detachedHead', 'false'], path)
+  run_git(['remote', 'add', 'origin', url], path)
+  run_git(['fetch', '--depth', '1', 'origin', revision], path)
+  run_git(['checkout', 'FETCH_HEAD'], path)
 
 
 def checkout_deps(deps):
-    """Checks out the shallow refs specified in the DEPS file."""
-    with concurrent.futures.ThreadPoolExecutor(max_workers=8) as executor:
-        futures = []
-        for deps_name, deps_data in deps.items():
-            if deps_data.get('dep_type') == 'git':
-                url = deps_data['url'].split('@')[0]
-                revision = deps_data['url'].split('@')[1]
-                futures.append(executor.submit(
-                    checkout_shallow_git, deps_name, url, revision))
-        for future in concurrent.futures.as_completed(futures):
-            future.result()
+  """Checks out the shallow refs specified in the DEPS file."""
+  with concurrent.futures.ThreadPoolExecutor(max_workers=8) as executor:
+    futures = []
+    for deps_name, deps_data in deps.items():
+      if deps_data.get('dep_type') == 'git':
+        url = deps_data['url'].split('@')[0]
+        revision = deps_data['url'].split('@')[1]
+        futures.append(
+            executor.submit(checkout_shallow_git, deps_name, url, revision)
+        )
+    for future in concurrent.futures.as_completed(futures):
+      future.result()
 
 
 def main(argv):
-    if (len(argv) < 1):
-        raise Exception('Please provide a DEPS file to update.')
-    deps_file = argv[0]
-    if not os.path.exists(deps_file):
-        raise Exception('The DEPS file does not exist.')
+  if (len(argv) < 1):
+    raise Exception('Please provide a DEPS file to update.')
+  deps_file = argv[0]
+  if not os.path.exists(deps_file):
+    raise Exception('The DEPS file does not exist.')
 
-    host_os = 'linux'
-    if platform.system() == 'Windows':
-        host_os = 'win'
-    if platform.system() == 'Darwin':
-        host_os = 'mac'
+  host_os = 'linux'
+  if platform.system() == 'Windows':
+    host_os = 'win'
+  if platform.system() == 'Darwin':
+    host_os = 'mac'
 
-    deps_contents = gclient_utils.FileRead(deps_file)
-    local_scope = gclient_eval.Parse(
-        deps_contents, deps_file, builtin_vars={'host_os': host_os})
+  deps_contents = gclient_utils.FileRead(deps_file)
+  local_scope = gclient_eval.Parse(
+      deps_contents, deps_file, builtin_vars={'host_os': host_os}
+  )
 
-    checkout_deps(local_scope['deps'])
+  checkout_deps(local_scope['deps'])
 
 
 if '__main__' == __name__:
-    sys.exit(main(sys.argv[1:]))
+  sys.exit(main(sys.argv[1:]))

shell/platform/embedder/BUILD.gn

@@ -374,7 +374,7 @@ shared_library("flutter_engine_library") {
       [ "-Wl,--version-script=" + rebase_path("flutter_engine_exports.lst") ]
 
   if (is_mac && !embedder_for_target) {
-    ldflags = [ "-Wl,-install_name,@rpath/FlutterEmbedder.framework/$_framework_binary_subpath" ]
+    ldflags += [ "-Wl,-install_name,@rpath/FlutterEmbedder.framework/$_framework_binary_subpath" ]
   }
 
   deps = [ ":embedder" ]

shell/platform/tizen/tizen_input_method_context.cc

@@ -14,7 +14,9 @@ const char* GetEcoreImfContextAvailableId() {
   modules = ecore_imf_context_available_ids_get();
   if (modules) {
     void* module;
-    EINA_LIST_FREE(modules, module) { return static_cast<const char*>(module); }
+    EINA_LIST_FREE(modules, module) {
+      return static_cast<const char*>(module);
+    }
   }
   return nullptr;
 }

third_party/accessibility/ax/platform/atk_util_auralinux_gtk.cc

@@ -4,7 +4,7 @@
 
 #include <atk-bridge.h>
 
-//#include "base/environment.h"
+// #include "base/environment.h"
 #include "atk_util_auralinux.h"
 
 namespace ui {

tools/gn

@@ -504,8 +504,8 @@ def to_gn_args(args):
 
   # Enable pointer compression on 64-bit mobile targets. iOS is excluded due to
   # its inability to allocate address space without allocating memory.
-  if args.target_os in ['android', 'linux'] and gn_args['target_cpu'] in ['x64', 'arm64'
-                                                                          ]:
+  if args.target_os in ['android', 'linux'
+                       ] and gn_args['target_cpu'] in ['x64', 'arm64']:
     gn_args['dart_use_compressed_pointers'] = True
 
   if args.fuchsia_target_api_level is not None: