[Impeller] keep device holder and allocator alive until last vk image is destroyed. (flutter#166725)

Fixes flutter#166410

keep the potentially shutdown context alive until the last texture is
reclaimed, to work around issues where pending UI tasks aren't flushed
during platform view shutdown.

Author: Jonah Williams

engine/src/flutter/impeller/renderer/backend/vulkan/allocator_vk.cc

@@ -5,13 +5,15 @@
 #include "impeller/renderer/backend/vulkan/allocator_vk.h"
 
 #include <memory>
+#include <utility>
 
 #include "flutter/fml/memory/ref_ptr.h"
 #include "flutter/fml/trace_event.h"
 #include "impeller/base/allocation_size.h"
 #include "impeller/core/formats.h"
 #include "impeller/renderer/backend/vulkan/capabilities_vk.h"
 #include "impeller/renderer/backend/vulkan/device_buffer_vk.h"
+#include "impeller/renderer/backend/vulkan/device_holder_vk.h"
 #include "impeller/renderer/backend/vulkan/formats_vk.h"
 #include "impeller/renderer/backend/vulkan/texture_vk.h"
 #include "vulkan/vulkan_enums.hpp"
@@ -405,9 +407,10 @@ class AllocatedTextureSourceVK final : public TextureSourceVK {
       return;
     }
 
-    resource_.Swap(ImageResource(ImageVMA{allocator, allocation, image},
-                                 std::move(image_view),
-                                 std::move(rt_image_view)));
+    resource_.Swap(ImageResource(
+        ImageVMA{allocator, allocation, image}, std::move(image_view),
+        std::move(rt_image_view), context.GetResourceAllocator(),
+        context.GetDeviceHolder()));
     is_valid_ = true;
   }
 
@@ -429,6 +432,8 @@ class AllocatedTextureSourceVK final : public TextureSourceVK {
 
  private:
   struct ImageResource {
+    std::shared_ptr<DeviceHolderVK> device_holder;
+    std::shared_ptr<Allocator> allocator;
     UniqueImageVMA image;
     vk::UniqueImageView image_view;
     vk::UniqueImageView rt_image_view;
@@ -437,8 +442,12 @@ class AllocatedTextureSourceVK final : public TextureSourceVK {
 
     ImageResource(ImageVMA p_image,
                   vk::UniqueImageView p_image_view,
-                  vk::UniqueImageView p_rt_image_view)
-        : image(p_image),
+                  vk::UniqueImageView p_rt_image_view,
+                  std::shared_ptr<Allocator> allocator,
+                  std::shared_ptr<DeviceHolderVK> device_holder)
+        : device_holder(std::move(device_holder)),
+          allocator(std::move(allocator)),
+          image(p_image),
           image_view(std::move(p_image_view)),
           rt_image_view(std::move(p_rt_image_view)) {}
 

engine/src/flutter/impeller/renderer/backend/vulkan/allocator_vk_unittests.cc

@@ -5,6 +5,7 @@
 #include "flutter/testing/testing.h"  // IWYU pragma: keep
 #include "gtest/gtest.h"
 #include "impeller/base/allocation_size.h"
+#include "impeller/core/allocator.h"
 #include "impeller/core/device_buffer.h"
 #include "impeller/core/device_buffer_descriptor.h"
 #include "impeller/core/formats.h"
@@ -73,6 +74,25 @@ TEST(AllocatorVKTest, MemoryTypeSelectionTwoHeap) {
   EXPECT_EQ(AllocatorVK::FindMemoryTypeIndex(4, properties), -1);
 }
 
+TEST(AllocatorVKTest, ImageResourceKeepsVulkanDeviceAlive) {
+  std::shared_ptr<Texture> texture;
+  std::weak_ptr<Allocator> weak_allocator;
+  {
+    auto const context = MockVulkanContextBuilder().Build();
+    weak_allocator = context->GetResourceAllocator();
+    auto allocator = context->GetResourceAllocator();
+
+    texture = allocator->CreateTexture(TextureDescriptor{
+        .storage_mode = StorageMode::kDevicePrivate,
+        .format = PixelFormat::kR8G8B8A8UNormInt,
+        .size = {1, 1},
+    });
+    context->Shutdown();
+  }
+
+  ASSERT_TRUE(weak_allocator.lock());
+}
+
 #ifdef IMPELLER_DEBUG
 
 TEST(AllocatorVKTest, RecreateSwapchainWhenSizeChanges) {

engine/src/flutter/impeller/renderer/backend/vulkan/texture_source_vk.h

@@ -12,7 +12,6 @@
 #include "impeller/renderer/backend/vulkan/shared_object_vk.h"
 #include "impeller/renderer/backend/vulkan/vk.h"
 #include "impeller/renderer/backend/vulkan/yuv_conversion_vk.h"
-#include "vulkan/vulkan_handles.hpp"
 
 namespace impeller {