Skip to content

Commit 236c2dc

Browse files
committed
Add ConvertDisplayMode and ConvertDisplayRotationType method
1 parent 5a3fe9e commit 236c2dc

File tree

3 files changed

+37
-9
lines changed

3 files changed

+37
-9
lines changed

packages/video_player_avplay/tizen/src/plus_player.cc

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,8 @@ bool PlusPlayer::SetDisplay() {
409409
}
410410
plusplayer_geometry_s roi{x, y, width, height};
411411
if (plusplayer_set_display_subsurface(
412-
player_, plusplayer_display_type_e::PLUSPLAYER_DISPLAY_TYPE_OVERLAY,
413-
resource_id, roi) != PLUSPLAYER_ERROR_TYPE_NONE) {
412+
player_, PLUSPLAYER_DISPLAY_TYPE_OVERLAY, resource_id, roi) !=
413+
PLUSPLAYER_ERROR_TYPE_NONE) {
414414
LOG_ERROR("[PlusPlayer] Player fail to set display.");
415415
return false;
416416
}
@@ -820,8 +820,8 @@ bool PlusPlayer::SetDisplayRotate(int64_t rotation) {
820820

821821
LOG_INFO("[PlusPlayer] rotation: %lld", rotation);
822822
return plusplayer_set_display_rotation(
823-
player_, static_cast<plusplayer_display_rotation_type_e>(
824-
rotation)) != PLUSPLAYER_ERROR_TYPE_NONE;
823+
player_, ConvertDisplayRotationType(rotation)) !=
824+
PLUSPLAYER_ERROR_TYPE_NONE;
825825
}
826826

827827
bool PlusPlayer::SetDisplayMode(int64_t display_mode) {
@@ -836,8 +836,7 @@ bool PlusPlayer::SetDisplayMode(int64_t display_mode) {
836836
return false;
837837
}
838838
LOG_INFO("[PlusPlayer] display_mode: %lld", display_mode);
839-
if (plusplayer_set_display_mode(
840-
player_, static_cast<plusplayer_display_mode_e>(display_mode)) !=
839+
if (plusplayer_set_display_mode(player_, ConvertDisplayMode(display_mode)) !=
841840
PLUSPLAYER_ERROR_TYPE_NONE) {
842841
LOG_ERROR("[PlusPlayer] Player fail to set display mode.");
843842
return false;
@@ -1186,14 +1185,12 @@ void PlusPlayer::OnSubtitleData(const plusplayer_subtitle_type_e type,
11861185
int attr_size, void *userdata) {}
11871186

11881187
void PlusPlayer::OnResourceConflicted(void *user_data) {
1189-
LOG_ERROR("[PlusPlayer] Resource conflicted.");
11901188
PlusPlayer *self = reinterpret_cast<PlusPlayer *>(user_data);
11911189

11921190
self->SendIsPlayingState(false);
11931191
}
11941192

11951193
void PlusPlayer::OnError(plusplayer_error_type_e error_type, void *user_data) {
1196-
LOG_ERROR("[PlusPlayer] Error code: %d", error_type);
11971194
PlusPlayer *self = reinterpret_cast<PlusPlayer *>(user_data);
11981195

11991196
self->SendError("[PlusPlayer] error",
@@ -1202,7 +1199,6 @@ void PlusPlayer::OnError(plusplayer_error_type_e error_type, void *user_data) {
12021199

12031200
void PlusPlayer::OnErrorMsg(plusplayer_error_type_e error_type,
12041201
const char *error_msg, void *user_data) {
1205-
LOG_ERROR("[PlusPlayer] Error code: %d, message: %s.", error_type, error_msg);
12061202
PlusPlayer *self = reinterpret_cast<PlusPlayer *>(user_data);
12071203

12081204
self->SendError("PlusPlayer error", std::string("Error: ") + error_msg);

packages/video_player_avplay/tizen/src/plus_player_util.cc

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,35 @@ static std::unordered_map<std::string, plusplayer_property_e>
4040
{"DASH_STREAM_INFO", PLUSPLAYER_PROPERTY_DASH_STREAM_INFO},
4141
{"HTTP_HEADER", PLUSPLAYER_PROPERTY_HTTP_HEADER}};
4242

43+
static const std::vector<plusplayer_display_rotation_type_e>
44+
kConvertDisplayRotationVec = {PLUSPLAYER_DISPLAY_ROTATION_TYPE_NONE,
45+
PLUSPLAYER_DISPLAY_ROTATION_TYPE_90,
46+
PLUSPLAYER_DISPLAY_ROTATION_TYPE_180,
47+
PLUSPLAYER_DISPLAY_ROTATION_TYPE_270};
48+
49+
static const std::vector<plusplayer_display_mode_e> kConvertDisplayModeMap = {
50+
PLUSPLAYER_DISPLAY_MODE_LETTER_BOX,
51+
PLUSPLAYER_DISPLAY_MODE_ORIGIN_SIZE,
52+
PLUSPLAYER_DISPLAY_MODE_FULL_SCREEN,
53+
PLUSPLAYER_DISPLAY_MODE_CROPPED_FULL,
54+
PLUSPLAYER_DISPLAY_MODE_ORIGIN_OR_LETTER,
55+
PLUSPLAYER_DISPLAY_MODE_DST_ROI,
56+
PLUSPLAYER_DISPLAY_MODE_AUTO_ASPECT_RATIO,
57+
PLUSPLAYER_DISPLAY_MODE_ROI_AUTO_ASPECT_RATIO};
58+
59+
plusplayer_display_rotation_type_e ConvertDisplayRotationType(
60+
const int64_t &rotation_type) {
61+
int index = static_cast<int>(rotation_type);
62+
return kConvertDisplayRotationVec[index];
63+
}
64+
65+
plusplayer_display_mode_e ConvertDisplayMode(const int64_t &display_mode) {
66+
int index = static_cast<int>(display_mode);
67+
return (index >= 0 && index < kConvertDisplayModeMap.size())
68+
? kConvertDisplayModeMap[index]
69+
: static_cast<plusplayer_display_mode_e>(-1);
70+
}
71+
4372
plusplayer_track_type_e ConvertTrackType(const std::string &track_type) {
4473
auto it = kTrackMap.find(track_type);
4574
if (it != kTrackMap.end()) {

packages/video_player_avplay/tizen/src/plus_player_util.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,8 @@ plusplayer_track_type_e ConvertTrackType(const std::string &track_type);
3030
plusplayer_property_e ConvertPropertyType(const std::string &type_value);
3131
std::vector<std::string> Split(const std::string &s, char delim);
3232
std::string GetErrorMessage(plusplayer_error_type_e error_code);
33+
plusplayer_display_mode_e ConvertDisplayMode(const int64_t &display_mode);
34+
plusplayer_display_rotation_type_e ConvertDisplayRotationType(
35+
const int64_t &rotation_type);
3336
} // namespace video_player_avplay_tizen
3437
#endif

0 commit comments

Comments
 (0)