Skip to content

Commit 8e40681

Browse files
authored
[webview_flutter] Fix canGoBack/Forward error (#485)
For EncodableValue(), the result of Eina_bool type must be explicitly changed to bool type.
1 parent 5a898a3 commit 8e40681

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

packages/webview_flutter/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.6.1
2+
3+
* Fix canGoBack/Forward error
4+
15
## 0.6.0
26

37
* Change the backing web engine from LWE to EFL WebKit (EWK).

packages/webview_flutter/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ This package is not an _endorsed_ implementation of `webview_flutter`. Therefore
2222
```yaml
2323
dependencies:
2424
webview_flutter: ^3.0.4
25-
webview_flutter_tizen: ^0.6.0
25+
webview_flutter_tizen: ^0.6.1
2626
```
2727
2828
## Example

packages/webview_flutter/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: webview_flutter_tizen
22
description: Tizen implementation of the webview plugin
33
homepage: https://github.com/flutter-tizen/plugins
44
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/webview_flutter
5-
version: 0.6.0
5+
version: 0.6.1
66

77
environment:
88
sdk: ">=2.17.0 <3.0.0"

packages/webview_flutter/tizen/src/webview.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -402,11 +402,11 @@ void WebView::HandleMethodCall(const FlMethodCall& method_call,
402402
}
403403
result->Success();
404404
} else if (method_name == "canGoBack") {
405-
result->Success(
406-
flutter::EncodableValue(ewk_view_back_possible(webview_instance_)));
405+
result->Success(flutter::EncodableValue(
406+
static_cast<bool>(ewk_view_back_possible(webview_instance_))));
407407
} else if (method_name == "canGoForward") {
408-
result->Success(
409-
flutter::EncodableValue(ewk_view_forward_possible(webview_instance_)));
408+
result->Success(flutter::EncodableValue(
409+
static_cast<bool>(ewk_view_forward_possible(webview_instance_))));
410410
} else if (method_name == "goBack") {
411411
ewk_view_back(webview_instance_);
412412
result->Success();

0 commit comments

Comments
 (0)