[tizen_app_manager] Add threading to prevent app freezing (#521)

Author: swift-kim

packages/tizen_app_manager/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.2.2
+
+* Add threading to `AppManager.getInstalledApps` to prevent app freezing.
+
 ## 0.2.1
 
 * Revise the example app.

packages/tizen_app_manager/README.md

@@ -10,7 +10,7 @@ To use this package, add `tizen_app_manager` as a dependency in your `pubspec.ya
 
 ```yaml
 dependencies:
-  tizen_app_manager: ^0.2.1
+  tizen_app_manager: ^0.2.2
 ```
 
 ### Retrieving current app info

packages/tizen_app_manager/example/lib/main.dart

@@ -53,11 +53,14 @@ class _MyHomePageState extends State<MyHomePage> {
       child: Scaffold(
         appBar: AppBar(
           title: const Text('App Manager Demo'),
-          bottom: const TabBar(tabs: <Tab>[
-            Tab(text: 'This app'),
-            Tab(text: 'App list'),
-            Tab(text: 'App events'),
-          ]),
+          bottom: const TabBar(
+            isScrollable: true,
+            tabs: <Tab>[
+              Tab(text: 'This app'),
+              Tab(text: 'App list'),
+              Tab(text: 'App events'),
+            ],
+          ),
         ),
         body: const TabBarView(
           children: <Widget>[
@@ -110,6 +113,8 @@ class _CurrentAppScreenState extends State<_CurrentAppScreen> {
               _infoTile('State', appContext.appState.name),
             ],
           );
+        } else if (snapshot.hasError) {
+          return Center(child: Text(snapshot.error.toString()));
         } else {
           return const Center(child: CircularProgressIndicator());
         }
@@ -125,9 +130,15 @@ class _AppListScreen extends StatefulWidget {
   State<_AppListScreen> createState() => _AppListScreenState();
 }
 
-class _AppListScreenState extends State<_AppListScreen> {
+class _AppListScreenState extends State<_AppListScreen>
+    with AutomaticKeepAliveClientMixin {
+  @override
+  bool get wantKeepAlive => true;
+
   @override
   Widget build(BuildContext context) {
+    super.build(context);
+
     return FutureBuilder<List<AppInfo>>(
       future: AppManager.getInstalledApps(),
       builder: (BuildContext context, AsyncSnapshot<List<AppInfo>> snapshot) {
@@ -155,6 +166,8 @@ class _AppListScreenState extends State<_AppListScreen> {
               );
             },
           );
+        } else if (snapshot.hasError) {
+          return Center(child: Text(snapshot.error.toString()));
         } else {
           return const Center(child: CircularProgressIndicator());
         }
@@ -182,12 +195,16 @@ class _AppEventsScreen extends StatefulWidget {
   State<_AppEventsScreen> createState() => _AppEventsScreenState();
 }
 
-class _AppEventsScreenState extends State<_AppEventsScreen> {
+class _AppEventsScreenState extends State<_AppEventsScreen>
+    with AutomaticKeepAliveClientMixin {
   late final StreamSubscription<AppRunningContext>? _launchSubscription;
   late final StreamSubscription<AppRunningContext>? _terminateSubscription;
   final List<_AppEvent> _appEvents = <_AppEvent>[];
   String _settingsAppId = settingsAppId;
 
+  @override
+  bool get wantKeepAlive => true;
+
   @override
   void initState() {
     super.initState();
@@ -230,6 +247,8 @@ class _AppEventsScreenState extends State<_AppEventsScreen> {
 
   @override
   Widget build(BuildContext context) {
+    super.build(context);
+
     return Column(
       mainAxisSize: MainAxisSize.min,
       children: <Widget>[

packages/tizen_app_manager/pubspec.yaml

@@ -2,7 +2,7 @@ name: tizen_app_manager
 description: Tizen application manager APIs. Used for getting app info and getting app running context on a Tizen device.
 homepage: https://github.com/flutter-tizen/plugins
 repository: https://github.com/flutter-tizen/plugins/tree/master/packages/tizen_app_manager
-version: 0.2.1
+version: 0.2.2
 
 environment:
   sdk: ">=2.15.1 <3.0.0"

packages/tizen_app_manager/tizen/src/tizen_app_manager_plugin.cc

@@ -4,6 +4,7 @@
 
 #include "tizen_app_manager_plugin.h"
 
+#include <Ecore.h>
 #include <app.h>
 #include <flutter/event_channel.h>
 #include <flutter/event_sink.h>
@@ -253,23 +254,38 @@ class TizenAppManagerPlugin : public flutter::Plugin {
   }
 
   void GetInstalledApps(std::unique_ptr<FlMethodResult> result) {
-    flutter::EncodableList list;
-    for (const auto &app_info :
-         TizenAppManager::GetInstance().GetAllAppsInfo()) {
-      AppInfoToEncodableMap(
-          app_info.get(),
-          [&list](flutter::EncodableMap map) {
-            list.push_back(flutter::EncodableValue(map));
-          },
-          [app_info = app_info.get()](int error_code,
-                                      std::string error_string) {
-            std::optional<std::string> app_id = app_info->GetAppId();
-            LOG_ERROR("Failed to get app info [%s]: %s",
-                      app_id.has_value() ? app_id->c_str() : "",
-                      error_string.c_str());
-          });
-    }
-    result->Success(flutter::EncodableValue(list));
+    // TizenAppManager::GetAllAppsInfo() is an expensive operation and might
+    // cause unresponsiveness on low-end devices if run on the platform thread.
+    ecore_thread_run(
+        [](void *data, Ecore_Thread *thread) {
+          auto *result = static_cast<FlMethodResult *>(data);
+
+          flutter::EncodableList list;
+          for (const auto &app_info :
+               TizenAppManager::GetInstance().GetAllAppsInfo()) {
+            AppInfoToEncodableMap(
+                app_info.get(),
+                [&list](flutter::EncodableMap map) {
+                  list.push_back(flutter::EncodableValue(map));
+                },
+                [app_info = app_info.get()](int error_code,
+                                            std::string error_string) {
+                  std::optional<std::string> app_id = app_info->GetAppId();
+                  LOG_ERROR("Failed to get app info [%s]: %s",
+                            app_id.has_value() ? app_id->c_str() : "",
+                            error_string.c_str());
+                });
+          }
+          result->Success(flutter::EncodableValue(list));
+          delete result;
+        },
+        nullptr,
+        [](void *data, Ecore_Thread *thread) {
+          auto *result = static_cast<FlMethodResult *>(data);
+          result->Error("Operation failed", "Failed to start a thread.");
+          delete result;
+        },
+        result.release());
   }
 
   void IsAppRunning(const flutter::EncodableMap *arguments,