Skip to content

Commit f66bba5

Browse files
authored
Fix some error (#167)
* pubspec: Use double quotation instead of single. * api: Sort import. * api, event: Remove unused asset which never has null.
1 parent 67b2e21 commit f66bba5

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

lib/src/api.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
import 'dart:async';
22
import 'dart:io';
3-
import 'package:flutter/services.dart';
3+
44
import 'package:flutter/material.dart'
55
show
66
AlertDialog,
77
BuildContext,
8-
FlatButton,
98
Navigator,
109
Text,
1110
TextButton,
1211
Widget,
1312
showDialog;
14-
import 'package:flutter/services.dart' show MethodChannel;
13+
import 'package:flutter/services.dart' show MethodCall, MethodChannel;
1514

1615
import 'actions.dart';
1716
import 'event.dart';
@@ -181,8 +180,7 @@ class FlutterCallkeep extends EventManager {
181180
if (resp != null) {
182181
var uuids = <String>[];
183182
resp.forEach((element) {
184-
if (element != null && element is String)
185-
uuids.add(element);
183+
if (element is String) uuids.add(element);
186184
});
187185
return uuids;
188186
}

lib/src/event.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ class EventManager {
4343
/// -- do something here
4444
/// });
4545
void on<T extends EventType>(T eventType, void Function(T event) listener) {
46-
assert(listener != null, 'Null listener');
47-
assert(eventType != null, 'Null eventType');
4846
_addListener(eventType.runtimeType, listener);
4947
}
5048

@@ -53,7 +51,6 @@ class EventManager {
5351
/// all the methods that call it enforce the types!!!!
5452
void _addListener(Type runtimeType, dynamic listener) {
5553
assert(listener != null, 'Null listener');
56-
assert(runtimeType != null, 'Null runtimeType');
5754
try {
5855
var targets = listeners[runtimeType];
5956
if (targets == null) {

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ version: 0.3.3
44
homepage: https://github.com/flutter-webrtc/callkeep
55

66
environment:
7-
sdk: '>=2.12.0 <3.0.0'
8-
flutter: '>=1.22.0'
7+
sdk: ">=2.12.0 <3.0.0"
8+
flutter: ">=1.22.0"
99

1010
dependencies:
1111
flutter:

0 commit comments

Comments
 (0)