Skip to content

Commit f06c660

Browse files
authored
Merge pull request #21 from flutter-webrtc/fix/bug-for-firefox
fix bug for FF.
2 parents 6237805 + 4d48cc0 commit f06c660

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

lib/src/rtc_rtp_parameters_impl.dart

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,19 @@ class RTCRtpParametersWeb {
55
static RTCRtpParameters fromJsObject(Object object) {
66
return RTCRtpParameters(
77
transactionId: jsutil.getProperty(object, 'transactionId'),
8-
rtcp: RTCRTCPParametersWeb.fromJsObject(
9-
jsutil.getProperty(object, 'rtcp')),
8+
rtcp: jsutil.hasProperty(object, 'transactionId')
9+
? RTCRTCPParametersWeb.fromJsObject(
10+
jsutil.getProperty(object, 'rtcp'))
11+
: null,
1012
headerExtensions: headerExtensionsFromJsObject(object),
1113
encodings: encodingsFromJsObject(object),
1214
codecs: codecsFromJsObject(object));
1315
}
1416

1517
static List<RTCHeaderExtension> headerExtensionsFromJsObject(Object object) {
16-
var headerExtensions = jsutil.getProperty(object, 'headerExtensions');
18+
var headerExtensions = jsutil.hasProperty(object, 'headerExtensions')
19+
? jsutil.getProperty(object, 'headerExtensions')
20+
: [];
1721
var list = <RTCHeaderExtension>[];
1822
headerExtensions.forEach((e) {
1923
list.add(RTCHeaderExtensionWeb.fromJsObject(e));
@@ -22,7 +26,9 @@ class RTCRtpParametersWeb {
2226
}
2327

2428
static List<RTCRtpEncoding> encodingsFromJsObject(Object object) {
25-
var encodings = jsutil.getProperty(object, 'encodings');
29+
var encodings = jsutil.hasProperty(object, 'encodings')
30+
? jsutil.getProperty(object, 'encodings')
31+
: [];
2632
var list = <RTCRtpEncoding>[];
2733
encodings.forEach((e) {
2834
list.add(RTCRtpEncodingWeb.fromJsObject(e));
@@ -31,7 +37,9 @@ class RTCRtpParametersWeb {
3137
}
3238

3339
static List<RTCRTPCodec> codecsFromJsObject(Object object) {
34-
var encodings = jsutil.getProperty(object, 'codecs');
40+
var encodings = jsutil.hasProperty(object, 'codecs')
41+
? jsutil.getProperty(object, 'codecs')
42+
: [];
3543
var list = <RTCRTPCodec>[];
3644
encodings.forEach((e) {
3745
list.add(RTCRTPCodecWeb.fromJsObject(e));

0 commit comments

Comments
 (0)