Skip to content

Commit 91cc68f

Browse files
gmackallGray Mackall
andauthored
[Reland] Unmodified android sdk bundle (flutter#179920)
Relands flutter#179647 There were only two failing tests (there were also two bringup failures, the `mac_arm64_mokey` versions of these) https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_mokey%20run_release_test/3866/overview https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_mokey%20run_debug_test_android/5454/overview They failed with the same logs ``` Task result: { "success": false, "reason": "Task failed: flutter run had unexpected output on standard error." } ``` The stderr in question: ``` [2025-12-15 14:06:56.311794] [STDOUT] run:stderr: - integration_test requires Android NDK 28.2.13676358 [2025-12-15 14:06:56.311989] [STDOUT] run:stderr: Fix this issue by using the highest Android NDK version (they are backward compatible). [2025-12-15 14:06:56.312019] [STDOUT] run:stderr: Add the following to /opt/s/w/ir/x/w/rc/tmpr6kj09d_/flutter sdk/dev/integration_tests/ui/android/app/build.gradle: [2025-12-15 14:06:56.312074] [STDOUT] run:stderr: [2025-12-15 14:06:56.312092] [STDOUT] run:stderr: android { [2025-12-15 14:06:56.312144] [STDOUT] run:stderr: ndkVersion = "28.2.13676358" [2025-12-15 14:06:56.312162] [STDOUT] run:stderr: ... [2025-12-15 14:06:56.312205] [STDOUT] run:stderr: } ``` We can just set the ndk version to `flutter.ndkVersion`, which is this value. It's also what is set in the templates, so it isn't a hack that doesn't represent a real flutter app. Verified the tests pass now with ``` ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t run_release_test ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t run_debug_test_android ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
1 parent bfc63db commit 91cc68f

File tree

46 files changed

+266
-421
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+266
-421
lines changed

.ci.yaml

Lines changed: 104 additions & 104 deletions
Large diffs are not rendered by default.

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@ deps = {
615615
'packages': [
616616
{
617617
'package': 'flutter/android/sdk/all/${{platform}}',
618-
'version': 'version:36v3'
618+
'version': 'version:36v4unmodified'
619619
}
620620
],
621621
'condition': 'download_android_deps',

dev/a11y_assessments/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,6 @@ android {
3636
namespace = "com.example.a11y_assessments"
3737
compileSdk = flutter.compileSdkVersion
3838

39-
// Flutter's CI installs the NDK at a non-standard path.
40-
// This non-standard structure is initially created by
41-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
42-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
43-
if (systemNdkPath != null) {
44-
ndkVersion = flutter.ndkVersion
45-
ndkPath = systemNdkPath
46-
}
4739

4840
compileOptions {
4941
sourceCompatibility = JavaVersion.VERSION_17

dev/benchmarks/complex_layout/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ android {
2929
namespace = "com.yourcompany.complexLayout"
3030
compileSdk = flutter.compileSdkVersion
3131

32-
// Flutter's CI installs the NDK at a non-standard path.
33-
// This non-standard structure is initially created by
34-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
35-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
36-
if (systemNdkPath != null) {
37-
ndkVersion = flutter.ndkVersion
38-
ndkPath = systemNdkPath
39-
}
4032

4133
compileOptions {
4234
sourceCompatibility JavaVersion.VERSION_17

dev/benchmarks/macrobenchmarks/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ android {
2929
namespace = "com.example.macrobenchmarks"
3030
compileSdk = flutter.compileSdkVersion
3131

32-
// Flutter's CI installs the NDK at a non-standard path.
33-
// This non-standard structure is initially created by
34-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
35-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
36-
if (systemNdkPath != null) {
37-
ndkVersion = flutter.ndkVersion
38-
ndkPath = systemNdkPath
39-
}
4032

4133
compileOptions {
4234
sourceCompatibility JavaVersion.VERSION_17

dev/benchmarks/microbenchmarks/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ android {
2929
namespace = "com.yourcompany.microbenchmarks"
3030
compileSdk = flutter.compileSdkVersion
3131

32-
// Flutter's CI installs the NDK at a non-standard path.
33-
// This non-standard structure is initially created by
34-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
35-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
36-
if (systemNdkPath != null) {
37-
ndkVersion = flutter.ndkVersion
38-
ndkPath = systemNdkPath
39-
}
4032

4133
compileOptions {
4234
sourceCompatibility JavaVersion.VERSION_17

dev/benchmarks/multiple_flutters/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,6 @@ android {
1616
namespace = "dev.flutter.multipleflutters"
1717
compileSdk = 36
1818

19-
// Flutter's CI installs the NDK at a non-standard path.
20-
// This non-standard structure is initially created by
21-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
22-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
23-
if (systemNdkPath != null) {
24-
ndkVersion = "28.2.13676358" // This version must exactly match the version of the NDK that the recipe pulls from CIPD.
25-
ndkPath = systemNdkPath
26-
}
2719

2820
compileOptions {
2921
sourceCompatibility = JavaVersion.VERSION_17

dev/benchmarks/platform_views_layout/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ android {
2929
namespace = "dev.benchmarks.platform_views_layout"
3030
compileSdk = flutter.compileSdkVersion
3131

32-
// Flutter's CI installs the NDK at a non-standard path.
33-
// This non-standard structure is initially created by
34-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
35-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
36-
if (systemNdkPath != null) {
37-
ndkVersion = flutter.ndkVersion
38-
ndkPath = systemNdkPath
39-
}
4032

4133
compileOptions {
4234
sourceCompatibility JavaVersion.VERSION_17

dev/benchmarks/platform_views_layout_hybrid_composition/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ android {
2929
namespace = "dev.benchmarks.platform_views_layout_hybrid_composition"
3030
compileSdk = flutter.compileSdkVersion
3131

32-
// Flutter's CI installs the NDK at a non-standard path.
33-
// This non-standard structure is initially created by
34-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
35-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
36-
if (systemNdkPath != null) {
37-
ndkVersion = flutter.ndkVersion
38-
ndkPath = systemNdkPath
39-
}
4032

4133
compileOptions {
4234
sourceCompatibility JavaVersion.VERSION_17

dev/benchmarks/test_apps/stocks/android/app/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ android {
2929
namespace = "io.flutter.examples.stocks"
3030
compileSdk = flutter.compileSdkVersion
3131

32-
// Flutter's CI installs the NDK at a non-standard path.
33-
// This non-standard structure is initially created by
34-
// https://github.com/flutter/engine/blob/3.27.0/tools/android_sdk/create_cipd_packages.sh.
35-
String systemNdkPath = System.getenv("ANDROID_NDK_PATH")
36-
if (systemNdkPath != null) {
37-
ndkVersion = flutter.ndkVersion
38-
ndkPath = systemNdkPath
39-
}
4032

4133
compileOptions {
4234
sourceCompatibility JavaVersion.VERSION_17

0 commit comments

Comments
 (0)