Skip to content

Commit 46f784d

Browse files
committed
remainingBuilds and failedBuilds fields of PresubmitGuard class are required
1 parent 277b44d commit 46f784d

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

app_dart/lib/src/model/firestore/presubmit_guard.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ final class PresubmitGuard extends AppDocument<PresubmitGuard> {
136136
required CiStage stage,
137137
required int creationTime,
138138
required String author,
139-
int? remainingBuilds,
140-
int? failedBuilds,
139+
required int remainingBuilds,
140+
required int failedBuilds,
141141
Map<String, TaskStatus>? builds,
142142
}) {
143143
return PresubmitGuard._(
@@ -146,8 +146,8 @@ final class PresubmitGuard extends AppDocument<PresubmitGuard> {
146146
fieldCreationTime: creationTime.toValue(),
147147
fieldAuthor: author.toValue(),
148148
fieldCheckRun: json.encode(checkRun.toJson()).toValue(),
149-
fieldRemainingBuilds: ?remainingBuilds?.toValue(),
150-
fieldFailedBuilds: ?failedBuilds?.toValue(),
149+
fieldRemainingBuilds: remainingBuilds.toValue(),
150+
fieldFailedBuilds: failedBuilds.toValue(),
151151
if (builds != null)
152152
fieldBuilds: Value(
153153
mapValue: MapValue(

app_dart/test/model/firestore/presubmit_guard_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ void main() {
116116
stage: CiStage.fusionEngineBuild,
117117
creationTime: 1000,
118118
author: 'author',
119+
remainingBuilds: 0,
120+
failedBuilds: 0,
119121
);
120122

121123
expect(guard.slug, slug);

app_dart/test/service/scheduler_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1185,6 +1185,7 @@ targets:
11851185
author: 'dash',
11861186
builds: {'Linux A': TaskStatus.failed},
11871187
failedBuilds: 1,
1188+
remainingBuilds: 0,
11881189
);
11891190

11901191
final check = PresubmitCheck(

0 commit comments

Comments
 (0)