Skip to content

Commit fa7b1bc

Browse files
authored
fix: unsupress not working (#4923)
added test that failed before fix applied. fixes flutter/flutter#181296
1 parent 9b4f9da commit fa7b1bc

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

app_dart/lib/src/request_handlers/update_suppressed_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ final class UpdateSuppressedTest extends ApiRequestHandler {
5858
_paramTestName,
5959
_paramRepository,
6060
_paramAction,
61-
_paramIssueLink,
6261
]);
6362

6463
final testName = body[_paramTestName];

app_dart/test/request_handlers/update_suppressed_test_test.dart

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,33 @@ void main() {
108108
);
109109
});
110110

111+
test('throws if missing issue link for suppression', () async {
112+
tester.request.body = jsonEncode({
113+
'testName': 'my_test',
114+
'repository': 'flutter/flutter',
115+
'action': 'SUPPRESS',
116+
});
117+
118+
await expectLater(
119+
tester.post(handler),
120+
throwsA(isA<BadRequestException>()),
121+
);
122+
});
123+
124+
test('does not throw if missing issue link for unsuppression', () async {
125+
tester.request.body = jsonEncode({
126+
'testName': 'my_test',
127+
'repository': 'flutter/flutter',
128+
'action': 'UNSUPPRESS',
129+
});
130+
131+
await expectLater(
132+
tester.post(handler),
133+
completes,
134+
reason: 'Issue link is not required for UNSUPPRESS action',
135+
);
136+
});
137+
111138
test('throws BadRequestException if issue not found (SUPPRESS)', () async {
112139
githubService.issueResponse = null; // Issue not found
113140

0 commit comments

Comments
 (0)