Skip to content

Commit 546a95f

Browse files
Re-enable Intro to FlutterGPU on master (#2270)
This is a PR to track the state of `intro_flutter_gpu`. Blocked on: bdero/flutter_scene#48 ## Pre-launch Checklist - [x] I read the [Effective Dart: Style] _recently_, and have followed its advice. - [x] I signed the [CLA]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-devrel channel on [Discord]. <!-- Links --> [Effective Dart: Style]: https://dart.dev/guides/language/effective-dart/style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
1 parent 693b5ca commit 546a95f

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

flutter_ci_script_beta.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ declare -a CODELABS=(
2525
"haiku_generator"
2626
"homescreen_codelab"
2727
"in_app_purchases"
28-
# TODO(domesticmouse): Add after beta is above Dart 3.7.0-0
28+
# TODO(domesticmouse): Add after beta is above Dart 3.8.0-0
2929
# "intro_flutter_gpu"
3030
"namer"
3131
"next-gen-ui"

flutter_ci_script_master.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ declare -a CODELABS=(
2525
"haiku_generator"
2626
"homescreen_codelab"
2727
"in_app_purchases"
28-
# TODO(domesticmouse): Building assets for package:flutter_scene_importer failed.
29-
# "intro_flutter_gpu"
28+
"intro_flutter_gpu"
3029
"namer"
3130
"next-gen-ui"
3231
"testing_codelab"

flutter_ci_script_shared.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ function ci_codelabs () {
5050

5151
# intro_flutter_gpu only runs with Impeller
5252
if [ $CODELAB = 'intro_flutter_gpu' ]; then
53-
if [ $RUNNER_OS = 'macOS' ] || [ $RUNNER_OS = 'Windows' ]; then
54-
flutter config --enable-native-assets
55-
flutter build `echo $RUNNER_OS | tr '[:upper:]' '[:lower:]'` --debug
56-
flutter test --enable-impeller
53+
if [ $RUNNER_OS = 'macOS' ] || [ $RUNNER_OS = 'Linux' ]; then
54+
flutter config --enable-native-assets
55+
flutter build `echo $RUNNER_OS | tr '[:upper:]' '[:lower:]'` --debug
56+
flutter test --enable-impeller
5757
else
5858
echo "Skipping $CODELAB on $RUNNER_OS"
5959
fi

0 commit comments

Comments
 (0)