Cleanup intro_flutter_gpu (#2276)

Author: domesticmouse

intro_flutter_gpu/codelab_rebuild.yaml

@@ -33,6 +33,7 @@ class TrianglePainter extends CustomPainter {
 
   @override
   void paint(Canvas canvas, Size size) {
+    // Create a texture to render to
     final texture = gpu.gpuContext.createTexture(
       gpu.StorageMode.devicePrivate,
       size.width.ceil(),
@@ -42,13 +43,16 @@ class TrianglePainter extends CustomPainter {
       throw Exception('Failed to create texture');
     }
 
+    // Create a render target for the texture
     final renderTarget = gpu.RenderTarget.singleColor(
       gpu.ColorAttachment(texture: texture),
     );
 
+    // Create a command buffer and render pass
     final commandBuffer = gpu.gpuContext.createCommandBuffer();
     final renderPass = commandBuffer.createRenderPass(renderTarget);
 
+    // Load our shaders
     final vert = shaderLibrary['SimpleVertex'];
     if (vert == null) {
       throw Exception('Failed to load SimpleVertex vertex shader');
@@ -59,22 +63,22 @@ class TrianglePainter extends CustomPainter {
       throw Exception('Failed to load SimpleFragment fragment shader');
     }
 
+    // Create the rendering pipeline
     final pipeline = gpu.gpuContext.createRenderPipeline(vert, frag);
 
+    // Define our triangle vertices
     const floatsPerVertex = 2;
-    final vertices = Float32List.fromList([
-      -0.5, -0.5, // First vertex
-      0.5, -0.5, // Second vertex
-      0.0, 0.5, // Third vertex
-    ]);
+    final vertices = Float32List.fromList([-0.5, -0.5, 0.5, -0.5, 0.0, 0.5]);
 
+    // Create a GPU buffer for our vertices
     final verticesDeviceBuffer = gpu.gpuContext.createDeviceBufferWithCopy(
       ByteData.sublistView(vertices),
     );
     if (verticesDeviceBuffer == null) {
       throw Exception('Failed to create vertices device buffer');
     }
 
+    // Bind the pipeline and vertex buffer
     renderPass.bindPipeline(pipeline);
 
     final verticesView = gpu.BufferView(
@@ -87,8 +91,10 @@ class TrianglePainter extends CustomPainter {
       vertices.length ~/ floatsPerVertex,
     );
 
+    // Draw the triangle
     renderPass.draw();
 
+    // Submit commands to GPU and render to screen
     commandBuffer.submit();
     final image = texture.asImage();
     canvas.drawImage(image, Offset.zero, Paint());

intro_flutter_gpu/step_01/lib/main.dart

@@ -4,7 +4,7 @@ publish_to: 'none'
 version: 0.1.0
 
 environment:
-  sdk: ^3.7.0-0
+  sdk: ^3.8.0-0
 
 dependencies:
   flutter:

intro_flutter_gpu/step_01/pubspec.yaml

@@ -61,9 +61,9 @@ class TrianglePainter extends CustomPainter {
 
     final pipeline = gpu.gpuContext.createRenderPipeline(vert, frag);
 
-    const floatsPerVertex = 5;
+    const floatsPerVertex = 5; // Now 2 for position + 3 for color
     final vertices = Float32List.fromList([
-      // Format: x, y, r, g, b,
+      // Format: x, y, r, g, b
       -0.5, -0.5, 1.0, 0.0, 0.0,
       0.5, -0.5, 0.0, 1.0, 0.0,
       0.0, 0.5, 0.0, 0.0, 1.0,

intro_flutter_gpu/step_02/lib/main.dart

@@ -4,7 +4,7 @@ publish_to: 'none'
 version: 0.1.0
 
 environment:
-  sdk: ^3.7.0-0
+  sdk: ^3.8.0-0
 
 dependencies:
   flutter:

intro_flutter_gpu/step_02/pubspec.yaml

@@ -63,16 +63,16 @@ class TrianglePainter extends CustomPainter {
 
     const floatsPerVertex = 5;
     final vertices = Float32List.fromList([
-      // Format: x, y, r, g, b,
-
-      // Traingle #1
-      -0.5, -0.5, 1.0, 0.0, 0.0, // bottom left
-      0.5, -0.5, 0.0, 1.0, 0.0, // bottom right
-      -0.5, 0.5, 0.0, 0.0, 1.0, // top left
-      // Traingle #2
-      0.5, -0.5, 0.0, 1.0, 0.0, // bottom right
-      0.5, 0.5, 1.0, 1.0, 0.0, // top right
-      -0.5, 0.5, 0.0, 0.0, 1.0, // top left
+      // Format: x, y, r, g, b
+
+      // Triangle #1
+      -0.5, -0.5, 1.0, 0.0, 0.0,
+      0.5, -0.5, 0.0, 1.0, 0.0,
+      -0.5, 0.5, 0.0, 0.0, 1.0,
+      // Triangle #2
+      0.5, -0.5, 0.0, 1.0, 0.0,
+      0.5, 0.5, 1.0, 1.0, 0.0,
+      -0.5, 0.5, 0.0, 0.0, 1.0,
     ]);
 
     final verticesDeviceBuffer = gpu.gpuContext.createDeviceBufferWithCopy(

intro_flutter_gpu/step_03/lib/main.dart

@@ -4,7 +4,7 @@ publish_to: 'none'
 version: 0.1.0
 
 environment:
-  sdk: ^3.7.0-0
+  sdk: ^3.8.0-0
 
 dependencies:
   flutter:

intro_flutter_gpu/step_03/pubspec.yaml

@@ -63,16 +63,16 @@ class TrianglePainter extends CustomPainter {
 
     const floatsPerVertex = 5;
     final vertices = Float32List.fromList([
-      // Format: x, y, r, g, b,
-
-      // Traingle #1
-      -0.5, -0.5, 0.0, 0.0, 1.0, // bottom left
-      0.5, -0.5, 1.0, 1.0, 0.0, // bottom right
-      -0.5, 0.5, 1.0, 0.0, 0.0, // top left
-      // Traingle #2
-      0.5, -0.5, 1.0, 1.0, 0.0, // bottom right
-      0.5, 0.5, 0.0, 1.0, 0.0, // top right
-      -0.5, 0.5, 1.0, 0.0, 0.0, // top left
+      // Format: x, y, r, g, b
+
+      // Triangle #1
+      -0.5, -0.5, 0.0, 0.0, 1.0,
+      0.5, -0.5, 1.0, 1.0, 0.0,
+      -0.5, 0.5, 1.0, 0.0, 0.0,
+      // Triangle #2
+      0.5, -0.5, 1.0, 1.0, 0.0,
+      0.5, 0.5, 0.0, 1.0, 0.0,
+      -0.5, 0.5, 1.0, 0.0, 0.0,
     ]);
 
     final verticesDeviceBuffer = gpu.gpuContext.createDeviceBufferWithCopy(

intro_flutter_gpu/step_04/lib/main.dart

@@ -4,7 +4,7 @@ publish_to: 'none'
 version: 0.1.0
 
 environment:
-  sdk: ^3.7.0-0
+  sdk: ^3.8.0-0
 
 dependencies:
   flutter:

intro_flutter_gpu/step_04/pubspec.yaml

@@ -61,18 +61,18 @@ class TrianglePainter extends CustomPainter {
 
     final pipeline = gpu.gpuContext.createRenderPipeline(vert, frag);
 
-    const floatsPerVertex = 4;
+    const floatsPerVertex = 4; // Now 2 for position + 2 for UV
     final vertices = Float32List.fromList([
-      // Format: x, y, u, v,
-
-      // Traingle #1
-      -0.5, -0.5, 0.0, 0.0, // bottom left
-      0.5, -0.5, 1.0, 0.0, // bottom right
-      -0.5, 0.5, 0.0, 1.0, // top left
-      // Traingle #2
-      0.5, -0.5, 1.0, 0.0, // bottom right
-      0.5, 0.5, 1.0, 1.0, // top right
-      -0.5, 0.5, 0.0, 1.0, // top left
+      // Format: x, y, u, v
+
+      // Triangle #1
+      -0.5, -0.5, 0.0, 0.0,
+      0.5, -0.5, 1.0, 0.0,
+      -0.5, 0.5, 0.0, 1.0,
+      // Triangle #2
+      0.5, -0.5, 1.0, 0.0,
+      0.5, 0.5, 1.0, 1.0,
+      -0.5, 0.5, 0.0, 1.0,
     ]);
 
     final verticesDeviceBuffer = gpu.gpuContext.createDeviceBufferWithCopy(