Skip to content

Conversation

@domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@craiglabenz
Copy link

Feedback list while stepping through the codelab. (I will update this issue as I proceed.)

  • It would be nice if the UP arrow cycled through past chat history. I realize this is not necessarily a quick feature to implement, so do with the thought what you will
    • Related: enabling text selection in the app would be nice. While I wait for VertexAI to turn on, I find myself wanting to copy-paste my previous prompt into the input to test it again.

@domesticmouse
Copy link
Contributor Author

Feedback list while stepping through the codelab. (I will update this issue as I proceed.)

  • It would be nice if the UP arrow cycled through past chat history. I realize this is not necessarily a quick feature to implement, so do with the thought what you will

    • Related: enabling text selection in the app would be nice. While I wait for VertexAI to turn on, I find myself wanting to copy-paste my previous prompt into the input to test it again.

I've implemented text selection in colorist_ui v0.0.4. I don't think I'm going to attempt to implement the up arrow functionality, that would require a fair bit more work to implement, and it doesn't really support what the app is about.

So, done?

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the separate UI code or the codelab text, but what's in this PR looks good to me :)

@domesticmouse domesticmouse merged commit f468366 into flutter:main Apr 4, 2025
10 checks passed
@domesticmouse domesticmouse deleted the colorist branch April 4, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants