Skip to content

Commit 628af31

Browse files
committed
Remove calls to ParsingDiagnostics.registerParse(..)
These calls do not add any functionality to users, and are experimental in the IntellijJ framework.
1 parent ab7fc44 commit 628af31

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

third_party/src/main/java/com/jetbrains/lang/dart/DartTokenTypesSets.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
import com.intellij.lang.*;
55
import com.intellij.openapi.util.Pair;
6-
import com.intellij.psi.ParsingDiagnostics;
76
import com.intellij.psi.PsiElement;
87
import com.intellij.psi.PsiFile;
98
import com.intellij.psi.TokenType;
@@ -249,11 +248,12 @@ protected ASTNode doParseContents(@NotNull ASTNode lazyParseableBlock, @NotNull
249248
if (isSyncOrAsync(lazyParseableBlock)) {
250249
builder.putUserData(DartGeneratedParserUtilBase.INSIDE_SYNC_OR_ASYNC_FUNCTION, true);
251250
}
252-
var startTime = System.nanoTime();
251+
// var startTime = System.nanoTime();
253252
new DartParser().parseLight(BLOCK, builder);
254-
var result = builder.getTreeBuilt().getFirstChildNode();
255-
ParsingDiagnostics.registerParse(builder, getLanguage(), System.nanoTime() - startTime);
256-
return result;
253+
return builder.getTreeBuilt().getFirstChildNode();
254+
// The following is removed as it is experimental and does not provide any functionality in the IDE for Dart developers:
255+
// ParsingDiagnostics.registerParse(builder, getLanguage(), System.nanoTime() - startTime);
256+
// return result; (set by builder.getTreeBuilt().getFirstChildNode()
257257
}
258258

259259
private static boolean isSyncOrAsync(final @NotNull ASTNode newBlock) {
@@ -271,11 +271,12 @@ public DartEmbeddedContentElementType() {
271271
@Override
272272
protected ASTNode doParseContents(@NotNull ASTNode chameleon, @NotNull PsiElement psi) {
273273
PsiBuilder builder = PsiBuilderFactory.getInstance().createBuilder(psi.getProject(), chameleon);
274-
var startTime = System.nanoTime();
274+
// var startTime = System.nanoTime();
275275
new DartParser().parseLight(DartParserDefinition.DART_FILE, builder);
276-
var result = builder.getTreeBuilt().getFirstChildNode();
277-
ParsingDiagnostics.registerParse(builder, getLanguage(), System.nanoTime() - startTime);
278-
return result;
276+
return builder.getTreeBuilt().getFirstChildNode();
277+
// The following is removed as it is experimental and does not provide any functionality in the IDE for Dart developers:
278+
// ParsingDiagnostics.registerParse(builder, getLanguage(), System.nanoTime() - startTime);
279+
// return result; (set by builder.getTreeBuilt().getFirstChildNode()
279280
}
280281

281282
@Override

third_party/src/main/java/com/jetbrains/lang/dart/psi/impl/DartExpressionCodeFragmentImpl.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,15 +111,16 @@ private static class DartFragmentElementType extends IFileElementType {
111111
protected ASTNode doParseContents(@NotNull ASTNode chameleon, @NotNull PsiElement psi) {
112112
final PsiBuilderFactory factory = PsiBuilderFactory.getInstance();
113113
final PsiBuilder psiBuilder = factory.createBuilder(((TreeElement)chameleon).getManager().getProject(), chameleon);
114-
var startTime = System.nanoTime();
114+
// var startTime = System.nanoTime();
115115
final PsiBuilder builder = adapt_builder_(DartTokenTypes.STATEMENTS, psiBuilder, new DartParser(), DartParser.EXTENDS_SETS_);
116116

117117
PsiBuilder.Marker marker = enter_section_(builder, 0, _COLLAPSE_, "<code fragment>");
118118
boolean result = DartParser.expression(builder, 0);
119119
exit_section_(builder, 0, marker, DartTokenTypes.STATEMENTS, result, true, TRUE_CONDITION);
120-
var treeBuilt = builder.getTreeBuilt();
121-
ParsingDiagnostics.registerParse(builder, getLanguage(), System.nanoTime() - startTime);
122-
return treeBuilt;
120+
return builder.getTreeBuilt();
121+
// The following is removed as it is experimental and does not provide any functionality in the IDE for Dart developers:
122+
// ParsingDiagnostics.registerParse(builder, getLanguage(), System.nanoTime() - startTime);
123+
// return treeBuilt; (set by builder.getTreeBuilt())
123124
}
124125
}
125126
}

0 commit comments

Comments
 (0)