Remove more now unused code

Author: parlough

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartPubActionBase.kt

@@ -36,7 +36,6 @@ import com.intellij.openapi.util.Disposer
 import com.intellij.openapi.util.Key
 import com.intellij.openapi.util.NlsContexts
 import com.intellij.openapi.util.io.FileUtil
-import com.intellij.openapi.util.text.StringUtil
 import com.intellij.openapi.vfs.VfsUtil
 import com.intellij.openapi.vfs.VirtualFile
 import com.intellij.openapi.wm.ToolWindowId
@@ -77,7 +76,7 @@ abstract class DartPubActionBase : AnAction(), DumbAware {
     e.presentation.isEnabled = visible && !isInProgress
   }
 
-  protected abstract fun getTitle(project: Project, pubspecYamlFile: VirtualFile): String
+  protected abstract fun getTitle(pubspecYamlFile: VirtualFile): String
 
   protected abstract fun calculatePubParameters(project: Project, pubspecYamlFile: VirtualFile): Array<String>?
 
@@ -92,7 +91,7 @@ abstract class DartPubActionBase : AnAction(), DumbAware {
     if (sdk == null && allowModalDialogs) {
       val answer = Messages.showDialog(module.project,
                                        DartBundle.message("dart.sdk.is.not.configured"),
-                                       getTitle(module.project, pubspecYamlFile),
+                                       getTitle(pubspecYamlFile),
                                        arrayOf(DartBundle.message("setup.dart.sdk"), CommonBundle.getCancelButtonText()),
                                        Messages.OK,
                                        Messages.getErrorIcon())
@@ -110,7 +109,7 @@ abstract class DartPubActionBase : AnAction(), DumbAware {
       if (allowModalDialogs) {
         val answer = Messages.showDialog(module.project,
                                          DartBundle.message("dart.sdk.bad.dartpub.path", exeFile.path),
-                                         getTitle(module.project, pubspecYamlFile),
+                                         getTitle(pubspecYamlFile),
                                          arrayOf(DartBundle.message("setup.dart.sdk"), CommonBundle.getCancelButtonText()),
                                          Messages.OK,
                                          Messages.getErrorIcon())
@@ -134,7 +133,7 @@ abstract class DartPubActionBase : AnAction(), DumbAware {
       setupPubExePath(command, sdk)
       command.addParameters(*pubParameters)
 
-      doPerformPubAction(module, pubspecYamlFile, command, getTitle(module.project, pubspecYamlFile))
+      doPerformPubAction(module, pubspecYamlFile, command, getTitle(pubspecYamlFile))
     }
   }
 

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartPubBuildAction.java

@@ -23,7 +23,7 @@ public void update(@NotNull AnActionEvent e) {
   }
 
   @Override
-  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull Project project, final @NotNull VirtualFile pubspecYamlFile) {
+  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull VirtualFile pubspecYamlFile) {
     final String projectName = PubspecYamlUtil.getDartProjectName(pubspecYamlFile);
     final String prefix = projectName == null ? "" : ("[" + projectName + "] ");
     return prefix + DartBundle.message("dart.webdev.build.title");

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartPubCacheRepairAction.java

@@ -12,7 +12,7 @@
 
 public class DartPubCacheRepairAction extends DartPubActionBase {
   @Override
-  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull Project project, final @NotNull VirtualFile pubspecYamlFile) {
+  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull VirtualFile pubspecYamlFile) {
     return DartBundle.message("dart.pub.cache.repair.title");
   }
 

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartPubGetAction.java

@@ -11,7 +11,7 @@
 
 public class DartPubGetAction extends DartPubActionBase {
   @Override
-  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull Project project, final @NotNull VirtualFile pubspecYamlFile) {
+  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull VirtualFile pubspecYamlFile) {
     final String projectName = PubspecYamlUtil.getDartProjectName(pubspecYamlFile);
     final String prefix = projectName == null ? "" : ("[" + projectName + "] ");
     return prefix + DartBundle.message("dart.pub.get.title");

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartPubOutdatedAction.java

@@ -25,7 +25,7 @@ public void update(@NotNull AnActionEvent e) {
   }
 
   @Override
-  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull Project project, final @NotNull VirtualFile pubspecYamlFile) {
+  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull VirtualFile pubspecYamlFile) {
     final String projectName = PubspecYamlUtil.getDartProjectName(pubspecYamlFile);
     final String prefix = projectName == null ? "" : ("[" + projectName + "] ");
     return prefix + DartBundle.message("dart.pub.outdated.title");

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartPubUpgradeAction.java

@@ -11,7 +11,7 @@
 
 public class DartPubUpgradeAction extends DartPubActionBase {
   @Override
-  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull Project project, final @NotNull VirtualFile pubspecYamlFile) {
+  protected @NotNull @NlsContexts.DialogTitle String getTitle(final @NotNull VirtualFile pubspecYamlFile) {
     final String projectName = PubspecYamlUtil.getDartProjectName(pubspecYamlFile);
     final String prefix = projectName == null ? "" : ("[" + projectName + "] ");
     return prefix + DartBundle.message("dart.pub.upgrade.title");

third_party/src/main/java/com/jetbrains/lang/dart/sdk/DartSdkUtil.java

@@ -200,12 +200,4 @@ public static void updateKnownSdkPaths(final @NotNull Project project, final @No
   public static @NotNull String getDartExePath(@NotNull String sdkRoot) {
     return sdkRoot + (SystemInfo.isWindows ? "/bin/dart.exe" : "/bin/dart");
   }
-
-  public static @NotNull String getPubPath(@NotNull DartSdk sdk) {
-    return getPubPath(sdk.getHomePath());
-  }
-
-  public static @NotNull String getPubPath(@NotNull String sdkRoot) {
-    return sdkRoot + (SystemInfo.isWindows ? "/bin/pub.bat" : "/bin/pub");
-  }
 }