Skip to content

Commit fb30333

Browse files
authored
Move the plugin name, id, since and until builds into the gradle.properties file. (#24)
TODOs added for adding a changelog, see #23
1 parent b4363aa commit fb30333

File tree

3 files changed

+31
-10
lines changed

3 files changed

+31
-10
lines changed

third_party/build.gradle.kts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,14 @@ repositories {
3131

3232
intellijPlatform {
3333
pluginConfiguration {
34-
version = "1"
34+
name = providers.gradleProperty("pluginName")
35+
id = providers.gradleProperty("pluginId")
36+
version = providers.gradleProperty("pluginVersion")
37+
// TODO(https://github.com/flutter/dart-intellij-third-party/issues/23) Add a changelog:
38+
// val changelog = ...
3539
ideaVersion {
36-
sinceBuild = "251"
37-
untilBuild = "251.*"
40+
sinceBuild = providers.gradleProperty("pluginSinceBuild")
41+
untilBuild = providers.gradleProperty("pluginUntilBuild")
3842
}
3943
}
4044
pluginVerification {
@@ -113,7 +117,7 @@ tasks {
113117
test {
114118
// TODO figure out how to not need the sdk path hard coded:
115119
// Replace the [Dart SDK Path] to run the Dart Analysis Server tests
116-
jvmArgs("-Ddart.sdk=[Dart SDK path]]")
120+
jvmArgs("-Ddart.sdk=[Dart SDK path]")
117121
}
118122
}
119123

third_party/gradle.properties

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,33 @@
1-
# This file was generated by the Gradle 'init' task.
1+
# IntelliJ Platform Artifacts Repositories -> https://plugins.jetbrains.com/docs/intellij/intellij-artifacts.html
2+
3+
# This file was originally generated by the Gradle 'init' task.
24
# https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_configuration_properties
35

6+
pluginName = Dart
7+
pluginId = Dart
8+
9+
# SemVer format -> https://semver.org
10+
pluginVersion = 251.30000.0
11+
12+
# TODO(https://github.com/flutter/dart-intellij-third-party/issues/23) Add a changelog
13+
# Not currently used in the build.gradle.kts file:
14+
# pluginRepositoryUrl = https://github.com/flutter/dart-intellij-third-party
15+
16+
# Supported build number ranges and IntelliJ Platform versions -> https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
17+
pluginSinceBuild = 251
18+
pluginUntilBuild = 251.*
19+
420
# Gradle Releases -> https://github.com/gradle/gradle/releases
521
gradleVersion = 8.13
622

23+
# Opt-out flag for bundling Kotlin standard library -> https://jb.gg/intellij-platform-kotlin-stdlib
24+
kotlin.stdlib.default.dependency = false
25+
726
# Enable Gradle Configuration Cache -> https://docs.gradle.org/current/userguide/configuration_cache.html
827
org.gradle.configuration-cache = true
928

1029
# Enable Gradle Build Cache -> https://docs.gradle.org/current/userguide/build_cache.html
1130
org.gradle.caching = true
1231

1332
# Allocate additional JVM space for assembing this project
14-
org.gradle.jvmargs=-Xmx2048m -XX:MaxMetaspaceSize=1024m -Dfile.encoding=UTF-8
33+
org.gradle.jvmargs=-Xmx2048m -XX:MaxMetaspaceSize=1024m -Dfile.encoding=UTF-8

third_party/src/main/resources/META-INF/plugin.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
</ul>
1616
1717
<h2>Getting started</h2>
18-
<p>For information on getting started, head over to the <a href="https://www.jetbrains.com/help/">documentation</a> for your IDE.
19-
For IntelliJ IDEA, you can check out this section in the
20-
<a href="https://www.jetbrains.com/help/idea/dart.html">documentation</a>.
18+
<p>For information on getting started, head over to the <a href="https://dart.dev/tools/jetbrains-plugin">documentation</a>.
2119
]]></description>
22-
<vendor>JetBrains</vendor>
20+
<vendor url="https://google.com">Google</vendor>
2321
<category>Languages</category>
2422
<depends>com.intellij.modules.xml</depends>
2523
<depends optional="true" config-file="dart-yaml.xml">org.jetbrains.plugins.yaml</depends>

0 commit comments

Comments
 (0)