Skip to content

Add presubmit workflow badge to the README #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

Add presubmit workflow badge to the README #90

merged 1 commit into from
Nov 18, 2025

Conversation

@pq
Copy link
Collaborator

@pq pq commented Nov 18, 2025 •
edited
Loading

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from helin24 and jwren and removed request for helin24 November 18, 2025 18:30
@gemini-code-assist
Copy link

gemini-code-assist bot commented Nov 18, 2025

Summary of Changes

Hello @pq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's README.md by integrating a visual status badge for the presubmit workflow, making the continuous integration status immediately apparent to anyone viewing the repository. Additionally, it addresses a minor formatting detail by ensuring the README.md file properly terminates with a newline character.

Highlights

  • Add Presubmit Workflow Badge: A new badge linking to the presubmit.yaml workflow on GitHub Actions has been added to the README.md file, providing a quick visual status of the presubmit checks for the project.
  • Fix Newline at End of File: The README.md file was updated to ensure it properly ends with a newline character, which is a common best practice for text files and can prevent issues with some tools.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 18, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a presubmit workflow status badge to the README.md and adds a missing newline at the end of the file. These are good improvements. I have one suggestion to make the badge's alt text more descriptive for better accessibility. In the future, please also remember to fill out the pull request description to explain the changes. Thanks for your contribution!

README.md
@@ -1,5 +1,7 @@
# Dart IntelliJ Plugin

[![presubmit](https://github.com/flutter/dart-intellij-third-party/actions/workflows/presubmit.yaml/badge.svg)](https://github.com/flutter/dart-intellij-third-party/actions/workflows/presubmit.yaml)
Copy link

@gemini-code-assist gemini-code-assist bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better accessibility and clarity, consider using a more descriptive alt text for the status badge. This helps people using screen readers understand the purpose of the image and aligns with the project's readability principle.1

Suggested change
[![presubmit](https://github.com/flutter/dart-intellij-third-party/actions/workflows/presubmit.yaml/badge.svg)](https://github.com/flutter/dart-intellij-third-party/actions/workflows/presubmit.yaml)
[![Presubmit workflow](https://github.com/flutter/dart-intellij-third-party/actions/workflows/presubmit.yaml/badge.svg)](https://github.com/flutter/dart-intellij-third-party/actions/workflows/presubmit.yaml)

Style Guide References

Footnotes

  1. Using descriptive alt text for images improves readability and accessibility, which is a key principle of the style guide. ↩

@pq pq added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Nov 18, 2025
@pq pq merged commit 53920c1 into main Nov 18, 2025
9 checks passed
@pq pq deleted the pq-patch-1 branch November 18, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwren jwren jwren approved these changes

@helin24 helin24 helin24 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pq @jwren @helin24