Skip to content

Commit 22c619f

Browse files
authored
Fix dt serve command as part of the release process (#9603)
1 parent 77e37d7 commit 22c619f

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

tool/lib/commands/serve.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,8 @@ class ServeCommand extends Command {
154154
results[SharedCommandArgs.updatePerfetto.flagName] as bool;
155155
final useWasm = results[SharedCommandArgs.wasm.flagName] as bool;
156156
final noStripWasm = results[SharedCommandArgs.noStripWasm.flagName] as bool;
157-
final noMinifyWasm = results[SharedCommandArgs.noMinifyWasm.flagName] as bool;
157+
final noMinifyWasm =
158+
results[SharedCommandArgs.noMinifyWasm.flagName] as bool;
158159
final runPubGet = results[SharedCommandArgs.pubGet.flagName] as bool;
159160
final devToolsAppBuildMode =
160161
results[SharedCommandArgs.buildMode.flagName] as String;
@@ -241,10 +242,10 @@ class ServeCommand extends Command {
241242
logStatus('completed building DevTools: $devToolsBuildLocation');
242243
}
243244

244-
logStatus('running pub get for DDS in the local dart sdk');
245+
logStatus('running gclient sync in the local dart sdk');
245246
await processManager.runProcess(
246-
CliCommand.dart(['pub', 'get']),
247-
workingDirectory: path.join(localDartSdkLocation, 'pkg', 'dds'),
247+
CliCommand.gclient(['sync']),
248+
workingDirectory: localDartSdkLocation,
248249
);
249250

250251
logStatus('serving DevTools with a local devtools server...');

tool/lib/utils.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,14 @@ class CliCommand {
8181
return CliCommand('git', args, throwOnException: throwOnException);
8282
}
8383

84+
/// CliCommand helper for running gclient commands.
85+
factory CliCommand.gclient(
86+
List<String> args, {
87+
bool throwOnException = true,
88+
}) {
89+
return CliCommand('gclient', args, throwOnException: throwOnException);
90+
}
91+
8492
factory CliCommand.tool(List<String> args, {bool throwOnException = true}) {
8593
var toolPath = Platform.script.toFilePath();
8694
if (!File(toolPath).existsSync()) {

0 commit comments

Comments
 (0)