Remove new inspector welcome banner (#9569)

Author: elliette

packages/devtools_app/lib/src/screens/inspector_v2/inspector_screen_body.dart

@@ -14,7 +14,6 @@ import '../../shared/analytics/constants.dart' as gac;
 import '../../shared/analytics/metrics.dart';
 import '../../shared/console/eval/inspector_tree_v2.dart';
 import '../../shared/globals.dart';
-import '../../shared/managers/banner_messages.dart';
 import '../../shared/managers/error_badge_manager.dart';
 import '../../shared/primitives/blocking_action_mixin.dart';
 import '../../shared/ui/common_widgets.dart';
@@ -56,8 +55,6 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
   static const inspectorTreeKey = Key('Inspector Tree');
   static const minScreenWidthForText = 900.0;
 
-  static const _welcomeShownStorageId = 'inspectorV2WelcomeShown';
-
   @override
   void initState() {
     super.initState();
@@ -107,12 +104,6 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
     }
 
     _inspectorTreeController.setSearchTarget(searchTarget);
-
-    unawaited(
-      _maybeShowWelcomeMessage(context).catchError((_) {
-        // Ignore errors.
-      }),
-    );
   }
 
   @override
@@ -223,16 +214,6 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
       }),
     );
   }
-
-  Future<void> _maybeShowWelcomeMessage(BuildContext context) async {
-    final welcomeAlreadyShown = await storage.getValue(_welcomeShownStorageId);
-    if (welcomeAlreadyShown == 'true') return;
-    // Mark the welcome message as shown.
-    await storage.setValue(_welcomeShownStorageId, 'true');
-    if (context.mounted) {
-      pushWelcomeToNewInspectorMessage(InspectorScreen.id);
-    }
-  }
 }
 
 class InspectorTreeControls extends StatelessWidget {

packages/devtools_app/lib/src/shared/analytics/constants.dart

@@ -131,7 +131,6 @@ const inspectorHoverEvalMode = 'inspectorHoverEvalMode';
 const inspectorV2Enabled = 'inspectorV2Enabled';
 const inspectorV2Disabled = 'inspectorV2Disabled';
 const inspectorAutoRefreshEnabled = 'inspectorAutoRefreshEnabled';
-const inspectorV2Docs = 'inspectorV2Docs';
 const clearLogs = 'clearLogs';
 const copyLogs = 'copyLogs';
 

packages/devtools_app/lib/src/shared/managers/banner_messages.dart

@@ -521,30 +521,6 @@ The $codeType DevTools debugger is in maintenance mode. For the best debugging e
       );
 }
 
-class WelcomeToNewInspectorMessage extends BannerInfo {
-  WelcomeToNewInspectorMessage({required super.screenId})
-    : super(
-        key: Key('WelcomeToNewInspectorMessage - $screenId'),
-        buildTextSpans: (context) => [
-          const TextSpan(
-            text: '''
-👋 Welcome to the new Flutter inspector! To get started, check out the ''',
-          ),
-          GaLinkTextSpan(
-            link: GaLink(
-              display: 'documentation',
-              url: 'https://docs.flutter.dev/tools/devtools/inspector#new',
-              gaScreenName: screenId,
-              gaSelectedItemDescription: gac.inspectorV2Docs,
-            ),
-            context: context,
-            style: Theme.of(context).linkTextStyle,
-          ),
-          const TextSpan(text: '.'),
-        ],
-      );
-}
-
 void maybePushDebugModePerformanceMessage(String screenId) {
   if (offlineDataController.showingOfflineData.value) return;
   if (serviceConnection.serviceManager.connectedApp?.isDebugFlutterAppNow ??
@@ -573,10 +549,6 @@ void pushDebuggerIdeRecommendationMessage(String screenId) {
   );
 }
 
-void pushWelcomeToNewInspectorMessage(String screenId) {
-  bannerMessages.addMessage(WelcomeToNewInspectorMessage(screenId: screenId));
-}
-
 extension BannerMessageThemeExtension on ThemeData {
   TextStyle get warningMessageLinkStyle => regularTextStyle.copyWith(
     decoration: TextDecoration.underline,