Skip to content

Commit 896c500

Browse files
authored
RELEASE_INSTRUCTIONS: Fix text around fields in CR (#9350)
Also remove the text about a Cherry-pick issue. AFAICT, there are no more cherry-pick issues, only CRs.
1 parent f1c26fc commit 896c500

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

tool/RELEASE_INSTRUCTIONS.md

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -333,28 +333,24 @@ Once your CL is uploaded to Gerrit, modify your changelist commit message to mee
333333
the cherry-pick
334334
[requirements](https://github.com/dart-lang/sdk/blob/main/docs/Cherry-picks-to-a-release-channel.md#how-to-cherry-pick-a-changelist).
335335

336-
The CL description should look like this (you can use TBA for "Bug" and "Cherry-pick-request"
337-
until you've created the cherry pick request issue and have a link to use):
336+
The CL description should look like this:
337+
338338
```
339339
[stable or beta] Cherry-pick DevTools <new version number> into the SDK <stable or beta> branch.
340340
341-
Bug: https://github.com/dart-lang/sdk/issues/56270 # can temporarily be TBA
341+
Issue description: When attempting to use foo under certain conditions, users are unable to
342+
compile.
343+
What is the fix: foo is now evaluated at runtime.
344+
Why cherry-pick: Users of foo are no longer able to compile to bar.
345+
Risk: Low, this fix has landed on the main channel and is tested on the same infrastructure.
346+
Issue link(s): https://github.com/dart-lang/sdk/issues/12345678
342347
Cherry-pick: https://github.com/flutter/devtools/compare/<previous DevTools tag>...<new version number>
343-
Cherry-pick-request: https://github.com/dart-lang/sdk/issues/56270 # can temporarily be TBA
344348
Change-Id: Id75075a7e697559263742bc25972ef47532c39cb
345349
```
346350

347351
Then trigger a CQ Dry Run, add reviewers, and wait for approval. **DO NOT** merge
348352
the CL yet.
349353

350-
### Create the cherry-pick issue in the Dart SDK
351-
352-
Follow the [Request cherry-pick approval](https://github.com/dart-lang/sdk/blob/main/docs/Cherry-picks-to-a-release-channel.md#request-cherry-pick-approval)
353-
instructions to create a cherry-pick request against the Dart SDK.
354-
355-
Once the Dart release engineers (listed in [OWNERS](https://github.com/dart-lang/sdk/blob/main/OWNERS)) approve both your cherry-pick issue and your
356-
cherry-pick CL, you can merge the CL you created above.
357-
358354
**Do not move on to the next steps unless your cherry-pick CL has been approved
359355
and merged.**
360356

0 commit comments

Comments
 (0)