Skip to content

Commit b4d453b

Browse files
committed
remove and inline the use of package:ansi_up
1 parent 0a77055 commit b4d453b

File tree

8 files changed

+402
-56
lines changed

8 files changed

+402
-56
lines changed

packages/devtools_app/lib/src/screens/logging/_message_column.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class MessageColumn extends ColumnData<LogData>
6969
text: TextSpan(
7070
children: [
7171
if (hasSummary)
72-
...processAnsiTerminalCodes(
72+
...textSpansFromAnsi(
7373
// TODO(helin24): Recompute summary length considering ansi codes.
7474
// The current summary is generally the first 200 chars of details.
7575
data.summary!,
@@ -78,7 +78,7 @@ class MessageColumn extends ColumnData<LogData>
7878
if (hasSummary && hasDetails())
7979
TextSpan(text: ' • ', style: theme.subtleTextStyle),
8080
if (hasDetails())
81-
...processAnsiTerminalCodes(
81+
...textSpansFromAnsi(
8282
detailsComputed ? data.details! : '<fetching>',
8383
theme.subtleTextStyle,
8484
),

packages/devtools_app/lib/src/screens/vm_developer/object_inspector/vm_instance_display.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,8 @@ class DisplayProvider extends StatelessWidget {
165165
if (variable.text != null) {
166166
return SelectableText.rich(
167167
TextSpan(
168-
children: processAnsiTerminalCodes(
169-
variable.text,
168+
children: textSpansFromAnsi(
169+
variable.text ?? '',
170170
theme.subtleFixedFontStyle,
171171
),
172172
),

packages/devtools_app/lib/src/shared/console/console.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ class _ConsoleOutputState extends State<_ConsoleOutput>
183183
TextSpan(
184184
// TODO(jacobr): consider caching the processed ansi terminal
185185
// codes.
186-
children: processAnsiTerminalCodes(
186+
children: textSpansFromAnsi(
187187
line.text,
188188
theme.regularTextStyle,
189189
),

packages/devtools_app/lib/src/shared/console/widgets/display_provider.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ class _DisplayProviderState extends State<DisplayProvider> {
4848
menuButtons: _getMenuButtons(context),
4949
child: Text.rich(
5050
TextSpan(
51-
children: processAnsiTerminalCodes(
52-
widget.variable.text,
51+
children: textSpansFromAnsi(
52+
widget.variable.text!,
5353
theme.subtleFixedFontStyle,
5454
),
5555
),

0 commit comments

Comments
 (0)